[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver

[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver

[Chris Spencer]

From: Chris Spencer <christopher.spencer@sea.co.uk>

The Ethernet controller is not able to initialise correctly without the
pinctrl driver.

This config setting was enabled in the initial version of this file,
but was removed by a savedefconfig resync because the parameter did not
actually exist at that point.

Fixes: 1bac199e8c87 ("configs: Resync with savedefconfig")
Signed-off-by: Chris Spencer <christopher.spencer@sea.co.uk>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
Depends on this patch: https://patchwork.ozlabs.org/patch/1031817/

Changes in v2:
- Added Fabio's Reviewed-by.
- Corrected From address.
---
 configs/imx8mq_evk_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
index 53025e45bc..68656b0cd3 100644
--- a/configs/imx8mq_evk_defconfig
+++ b/configs/imx8mq_evk_defconfig
@@ -29,6 +29,7 @@ CONFIG_SYS_I2C_MXC=y
 CONFIG_DM_MMC=y
 CONFIG_DM_ETH=y
 CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX8M=y
 CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
-- 
2.17.1

[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver

[Chris Spencer]

On Mon, 4 Feb 2019 at 10:05, Chris Spencer <spencercw@gmail.com> wrote:
> From: Chris Spencer <christopher.spencer@sea.co.uk>
>
> The Ethernet controller is not able to initialise correctly without the
> pinctrl driver.
>
> This config setting was enabled in the initial version of this file,
> but was removed by a savedefconfig resync because the parameter did not
> actually exist at that point.
>
> Fixes: 1bac199e8c87 ("configs: Resync with savedefconfig")
> Signed-off-by: Chris Spencer <christopher.spencer@sea.co.uk>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> Depends on this patch: https://patchwork.ozlabs.org/patch/1031817/
>
> Changes in v2:
> - Added Fabio's Reviewed-by.
> - Corrected From address.

Since there hasn't been any activity on the i.MX8MM patch series for a
while, I wonder if the pinctrl driver [1] could be committed in
isolation? This patch could then be applied so we can get the Ethernet
working on the i.MX8MQ.

Thanks,
Chris

[1] https://patchwork.ozlabs.org/patch/1031817/

[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver

[Peng Fan]

> -----Original Message-----
> From: Chris Spencer [mailto:spencercw at gmail.com]
> Sent: 2019年3月1日 20:25
> To: Stefano Babic <sbabic@denx.de>; Fabio Estevam <festevam@gmail.com>
> Cc: dl-uboot-imx <uboot-imx@nxp.com>; U-Boot-Denx
> <u-boot@lists.denx.de>; Chris Spencer <christopher.spencer@sea.co.uk>
> Subject: Re: [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver
> 
> On Mon, 4 Feb 2019 at 10:05, Chris Spencer <spencercw@gmail.com> wrote:
> > From: Chris Spencer <christopher.spencer@sea.co.uk>
> >
> > The Ethernet controller is not able to initialise correctly without
> > the pinctrl driver.
> >
> > This config setting was enabled in the initial version of this file,
> > but was removed by a savedefconfig resync because the parameter did
> > not actually exist at that point.
> >
> > Fixes: 1bac199e8c87 ("configs: Resync with savedefconfig")
> > Signed-off-by: Chris Spencer <christopher.spencer@sea.co.uk>
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > Depends on this patch:
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >
> chwork.ozlabs.org%2Fpatch%2F1031817%2F&amp;data=02%7C01%7Cpeng.f
> an%40n
> >
> xp.com%7Cffae7c0ab2494a20159008d69e40ed2d%7C686ea1d3bc2b4c6fa92
> cd99c5c
> >
> 301635%7C0%7C0%7C636870399030578148&amp;sdata=0tJenqE8zP4dFhLs
> HJJ5WO3n
> > Tmiyz%2FAZWeclKFp8wso%3D&amp;reserved=0
> >
> > Changes in v2:
> > - Added Fabio's Reviewed-by.
> > - Corrected From address.
> 
> Since there hasn't been any activity on the i.MX8MM patch series for a while,
> I wonder if the pinctrl driver [1] could be committed in isolation? This patch
> could then be applied so we can get the Ethernet working on the i.MX8MQ.
> 

The blocking issue for i.MX8MM is clock part, for the pinctrl that
could be reused by i.MX8MQ, I think it could be committed, but need Stefano
to decide.

Regards,
Peng. 

> Thanks,
> Chris
> 
> [1]
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hwork.ozlabs.org%2Fpatch%2F1031817%2F&amp;data=02%7C01%7Cpeng.fa
> n%40nxp.com%7Cffae7c0ab2494a20159008d69e40ed2d%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C636870399030588157&amp;sdata=RT
> W%2FOHqbWlAfOfDdjulHP8CcFbNp75OJLS1ciqgJC1I%3D&amp;reserved=0

[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver

[Chris Spencer]

On Sat, 2 Mar 2019 at 06:27, Peng Fan <peng.fan@nxp.com> wrote:
> > On Mon, 4 Feb 2019 at 10:05, Chris Spencer <spencercw@gmail.com> wrote:
> > > From: Chris Spencer <christopher.spencer@sea.co.uk>
> > >
> > > The Ethernet controller is not able to initialise correctly without
> > > the pinctrl driver.
> > >
> > > This config setting was enabled in the initial version of this file,
> > > but was removed by a savedefconfig resync because the parameter did
> > > not actually exist at that point.
> > >
> > > Fixes: 1bac199e8c87 ("configs: Resync with savedefconfig")
> > > Signed-off-by: Chris Spencer <christopher.spencer@sea.co.uk>
> > > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > > ---
> > > Depends on this patch:
> > >
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> > >
> > chwork.ozlabs.org%2Fpatch%2F1031817%2F&amp;data=02%7C01%7Cpeng.f
> > an%40n
> > >
> > xp.com%7Cffae7c0ab2494a20159008d69e40ed2d%7C686ea1d3bc2b4c6fa92
> > cd99c5c
> > >
> > 301635%7C0%7C0%7C636870399030578148&amp;sdata=0tJenqE8zP4dFhLs
> > HJJ5WO3n
> > > Tmiyz%2FAZWeclKFp8wso%3D&amp;reserved=0
> > >
> > > Changes in v2:
> > > - Added Fabio's Reviewed-by.
> > > - Corrected From address.
> >
> > Since there hasn't been any activity on the i.MX8MM patch series for a while,
> > I wonder if the pinctrl driver [1] could be committed in isolation? This patch
> > could then be applied so we can get the Ethernet working on the i.MX8MQ.
> >
>
> The blocking issue for i.MX8MM is clock part, for the pinctrl that
> could be reused by i.MX8MQ, I think it could be committed, but need Stefano
> to decide.
>
> Regards,
> Peng.

Any thoughts on this, Stefano? Would be good to get the pinctrl driver
+ defconfig change into 2019.04 if we can.

Thanks,
Chris

[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Enable pinctrl driver

[Stefano Babic]

On 11/03/19 18:36, Chris Spencer wrote:
> On Sat, 2 Mar 2019 at 06:27, Peng Fan <peng.fan@nxp.com> wrote:
>>> On Mon, 4 Feb 2019 at 10:05, Chris Spencer <spencercw@gmail.com> wrote:
>>>> From: Chris Spencer <christopher.spencer@sea.co.uk>
>>>>
>>>> The Ethernet controller is not able to initialise correctly without
>>>> the pinctrl driver.
>>>>
>>>> This config setting was enabled in the initial version of this file,
>>>> but was removed by a savedefconfig resync because the parameter did
>>>> not actually exist at that point.
>>>>
>>>> Fixes: 1bac199e8c87 ("configs: Resync with savedefconfig")
>>>> Signed-off-by: Chris Spencer <christopher.spencer@sea.co.uk>
>>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>>> ---
>>>> Depends on this patch:
>>>>
>>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>>>
>>> chwork.ozlabs.org%2Fpatch%2F1031817%2F&amp;data=02%7C01%7Cpeng.f
>>> an%40n
>>>>
>>> xp.com%7Cffae7c0ab2494a20159008d69e40ed2d%7C686ea1d3bc2b4c6fa92
>>> cd99c5c
>>>>
>>> 301635%7C0%7C0%7C636870399030578148&amp;sdata=0tJenqE8zP4dFhLs
>>> HJJ5WO3n
>>>> Tmiyz%2FAZWeclKFp8wso%3D&amp;reserved=0
>>>>
>>>> Changes in v2:
>>>> - Added Fabio's Reviewed-by.
>>>> - Corrected From address.
>>>
>>> Since there hasn't been any activity on the i.MX8MM patch series for a while,
>>> I wonder if the pinctrl driver [1] could be committed in isolation? This patch
>>> could then be applied so we can get the Ethernet working on the i.MX8MQ.
>>>
>>
>> The blocking issue for i.MX8MM is clock part, for the pinctrl that
>> could be reused by i.MX8MQ, I think it could be committed, but need Stefano
>> to decide.
>>
>> Regards,
>> Peng.
> 
> Any thoughts on this, Stefano? Would be good to get the pinctrl driver
> + defconfig change into 2019.04 if we can.
> 

Fine with me - I have picked up pinctrl driver (pathc 19/20) and this
one for my last PR to Tom before release.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================