[PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

[PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

[Rob Herring]

On UML builds, mdio-mux-mmioreg.c fails to compile:

drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

This is due to CONFIG_OF now being user selectable. Add a dependency on
HAS_IOMEM to fix this.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
---
 drivers/net/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index cf18940..cb86d7a 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
 
 config MDIO_BUS_MUX_MMIOREG
 	tristate "Support for MMIO device-controlled MDIO bus multiplexers"
-	depends on OF_MDIO
+	depends on OF_MDIO && HAS_IOMEM
 	select MDIO_BUS_MUX
 	help
 	  This module provides a driver for MDIO bus multiplexers that
-- 
2.1.0

Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

[Florian Fainelli]

2015-07-05 10:16 GMT-07:00 Rob Herring <robh@kernel.org>:
> On UML builds, mdio-mux-mmioreg.c fails to compile:
>
> drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>
> This is due to CONFIG_OF now being user selectable. Add a dependency on
> HAS_IOMEM to fix this.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
>  drivers/net/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index cf18940..cb86d7a 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -191,7 +191,7 @@ config MDIO_BUS_MUX_GPIO
>
>  config MDIO_BUS_MUX_MMIOREG
>         tristate "Support for MMIO device-controlled MDIO bus multiplexers"
> -       depends on OF_MDIO
> +       depends on OF_MDIO && HAS_IOMEM
>         select MDIO_BUS_MUX
>         help
>           This module provides a driver for MDIO bus multiplexers that
> --
> 2.1.0
>



-- 
Florian

Re: [PATCH] net: phy: add dependency on HAS_IOMEM to MDIO_BUS_MUX_MMIOREG

[David Miller]

From: Rob Herring <robh@kernel.org>
Date: Sun,  5 Jul 2015 12:16:27 -0500

> On UML builds, mdio-mux-mmioreg.c fails to compile:
> 
> drivers/net/phy/mdio-mux-mmioreg.c:50:3: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
> drivers/net/phy/mdio-mux-mmioreg.c:63:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> 
> This is due to CONFIG_OF now being user selectable. Add a dependency on
> HAS_IOMEM to fix this.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied, thanks.