All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Bruce Korb <bruce.korb@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Dan Carpenter <error27@gmail.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"John L. Hammond" <john.hammond@intel.com>,
	Emoly Liu <emoly.liu@intel.com>,
	Vitaly Fertman <vitaly_fertman@xyratex.com>,
	Bruno Faccini <bruno.faccini@intel.com>,
	devel@driverdev.osuosl.org
Subject: Re: Designated initializers, struct randomization and addressing?
Date: Tue, 3 Jan 2017 16:13:44 -0800	[thread overview]
Message-ID: <CAGXu5j+uvo3CDaKRwFm9p-GxDhZDqoWC7mOt7eo=HaNJUE8WPQ@mail.gmail.com> (raw)
In-Reply-To: <CAKRnqNLs_1zy1v5Ngk0fZ-VBXrh3i2ihqUMVUU1BYeEBd3zAEQ@mail.gmail.com>

On Tue, Jan 3, 2017 at 3:55 PM, Bruce Korb <bruce.korb@gmail.com> wrote:
> On Tue, Jan 3, 2017 at 3:47 PM, Kees Cook <keescook@chromium.org> wrote:
>>> how is the code to be verified so that
>>> any use of things like offsetof and any
>>> address/indexing is not impacted?
>
> As a tangential party, I am a bit curious: does the randomization
> plugin result in a compact structure?  I ask because I know many/most
> programmers don't bother with it and so doing so ought to make the
> data more compact.

http://git.kernel.org/cgit/linux/kernel/git/kees/linux.git/tree/scripts/gcc-plugins/randomize_layout_plugin.c?h=kspp/gcc-plugin/randstruct

See full_shuffle() and performance_shuffle(). The latter keeps
variables in the same cacheline. Neither attempt any kind of
compaction.

-Kees

-- 
Kees Cook
Nexus Security

  reply	other threads:[~2017-01-04  0:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17  1:00 [PATCH] staging: lustre: ldlm: use designated initializers Kees Cook
2016-12-17  1:00 ` [lustre-devel] " Kees Cook
2016-12-19 16:22 ` James Simmons
2016-12-19 16:22   ` [lustre-devel] " James Simmons
2016-12-19 16:47   ` Bruce Korb
2016-12-19 16:48     ` [lustre-devel] " Bruce Korb
2016-12-19 17:12     ` James Simmons
2016-12-19 17:12       ` [lustre-devel] " James Simmons
2016-12-20  7:10     ` Dan Carpenter
2016-12-20  7:10       ` [lustre-devel] " Dan Carpenter
2016-12-20 14:57       ` Hammond, John
2016-12-20 14:57         ` [lustre-devel] " Hammond, John
2016-12-20 16:47         ` Bruce Korb
2016-12-20 16:48           ` [lustre-devel] " Bruce Korb
2016-12-20 18:52           ` Dan Carpenter
2016-12-20 18:52             ` [lustre-devel] " Dan Carpenter
2016-12-20 19:07         ` Dan Carpenter
2016-12-20 19:07           ` [lustre-devel] " Dan Carpenter
2016-12-20 19:46           ` Kees Cook
2016-12-20 19:46             ` [lustre-devel] " Kees Cook
2016-12-19 16:50   ` Patrick Farrell
2016-12-19 17:11     ` James Simmons
2016-12-19 17:11       ` James Simmons
2016-12-20 10:40   ` Dan Carpenter
2016-12-20 10:40     ` [lustre-devel] " Dan Carpenter
2016-12-20 17:29 ` Designated initializers, struct randomization and addressing? Joe Perches
2016-12-20 17:29   ` [lustre-devel] " Joe Perches
2017-01-03 23:47   ` Kees Cook
2017-01-03 23:55     ` Bruce Korb
2017-01-04  0:13       ` Kees Cook [this message]
2017-01-04  6:27     ` Julia Lawall
2017-01-04  6:35       ` Kees Cook
2017-01-04 16:55         ` Stephen Hemminger
2017-01-04 17:37           ` Julia Lawall
2017-01-04 22:30           ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGXu5j+uvo3CDaKRwFm9p-GxDhZDqoWC7mOt7eo=HaNJUE8WPQ@mail.gmail.com' \
    --to=keescook@chromium.org \
    --cc=andreas.dilger@intel.com \
    --cc=bruce.korb@gmail.com \
    --cc=bruno.faccini@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=emoly.liu@intel.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=john.hammond@intel.com \
    --cc=jsimmons@infradead.org \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=vitaly_fertman@xyratex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.