* [PATCH] security: fix documentation for the path_chmod hook
@ 2018-10-23 11:16 efremov
2018-10-23 19:29 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: efremov @ 2018-10-23 11:16 UTC (permalink / raw)
To: Al Viro
Cc: Denis Efremov, James Morris, Serge E. Hallyn, Eric Paris,
Paul Moore, Kees Cook, John Johansen, linux-kernel
From: Denis Efremov <efremov@linux.com>
The path_chmod hook was changed in the commit
"switch security_path_chmod() to struct path *" (cdcf116d44e7).
The argument @mnt was removed from the hook, @dentry was changed
to @path. This patch updates the documentation accordingly.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
include/linux/lsm_hooks.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index a598e601ccb3..596351f7c3d1 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h
@@ -304,8 +304,7 @@
* Return 0 if permission is granted.
* @path_chmod:
* Check for permission to change DAC's permission of a file or directory.
- * @dentry contains the dentry structure.
- * @mnt contains the vfsmnt structure.
+ * @path contains the path structure.
* @mode contains DAC's mode.
* Return 0 if permission is granted.
* @path_chown:
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] security: fix documentation for the path_chmod hook
2018-10-23 11:16 [PATCH] security: fix documentation for the path_chmod hook efremov
@ 2018-10-23 19:29 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2018-10-23 19:29 UTC (permalink / raw)
To: efremov
Cc: Al Viro, James Morris, Serge E. Hallyn, Eric Paris, Paul Moore,
John Johansen, LKML
On Tue, Oct 23, 2018 at 4:16 AM, <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> The path_chmod hook was changed in the commit
> "switch security_path_chmod() to struct path *" (cdcf116d44e7).
> The argument @mnt was removed from the hook, @dentry was changed
> to @path. This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> include/linux/lsm_hooks.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index a598e601ccb3..596351f7c3d1 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -304,8 +304,7 @@
> * Return 0 if permission is granted.
> * @path_chmod:
> * Check for permission to change DAC's permission of a file or directory.
> - * @dentry contains the dentry structure.
> - * @mnt contains the vfsmnt structure.
> + * @path contains the path structure.
> * @mode contains DAC's mode.
> * Return 0 if permission is granted.
> * @path_chown:
> --
> 2.17.2
>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-23 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 11:16 [PATCH] security: fix documentation for the path_chmod hook efremov
2018-10-23 19:29 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.