From: Kees Cook <keescook@chromium.org>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "Zheng, Lv" <lv.zheng@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>
Subject: Re: [PATCH] ACPICA: use designated initializers
Date: Mon, 3 Apr 2017 10:29:00 -0700 [thread overview]
Message-ID: <CAGXu5jJLQmxEcG6nLKn6fsib5meNpw4y1ZLO2F4ezA+jqF-6DA@mail.gmail.com> (raw)
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F104@ORSMSX110.amr.corp.intel.com>
On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert <robert.moore@intel.com> wrote:
> Acpica is built with many compilers, even very old ones. It runs on at least 12 known operating systems, and very probably more.
>
> I'm sorry, but no, we are not going to start adding compiler-specific ifdefs/code in the base ACPICA code.
>
> I don't care what you do in the Linux-specific or gcc-specific headers, however. If this breaks a customer build, we (you) will hear about it rather quickly.
Since the change is specific to the one place ACPICA uses an
all-function-pointer structure, I made the change local:
https://github.com/acpica/acpica/pull/248
would you rather this is in the .h files instead?
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-04-03 17:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 1:04 [PATCH] ACPICA: use designated initializers Kees Cook
2016-12-17 2:17 ` Rafael J. Wysocki
2016-12-19 6:06 ` Zheng, Lv
2016-12-19 6:06 ` [Devel] " Zheng, Lv
2017-03-29 21:16 ` Kees Cook
2017-03-30 2:12 ` Zheng, Lv
2017-03-30 2:12 ` [Devel] " Zheng, Lv
2017-03-30 14:26 ` Moore, Robert
2017-03-30 14:26 ` [Devel] " Moore, Robert
2017-04-01 0:26 ` Kees Cook
2017-04-01 0:45 ` Moore, Robert
2017-04-01 0:45 ` [Devel] " Moore, Robert
2017-04-03 17:29 ` Kees Cook [this message]
2017-04-04 15:02 ` Moore, Robert
2017-04-04 15:02 ` [Devel] " Moore, Robert
2017-04-04 15:55 ` Kees Cook
2017-05-08 20:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJLQmxEcG6nLKn6fsib5meNpw4y1ZLO2F4ezA+jqF-6DA@mail.gmail.com \
--to=keescook@chromium.org \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.