From: "Moore, Robert" <robert.moore@intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: "Zheng, Lv" <lv.zheng@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"Box, David E" <david.e.box@intel.com>,
"Schmauss, Erik" <erik.schmauss@intel.com>
Subject: RE: [PATCH] ACPICA: use designated initializers
Date: Tue, 4 Apr 2017 15:02:08 +0000 [thread overview]
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F7BB@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: <CAGXu5jJLQmxEcG6nLKn6fsib5meNpw4y1ZLO2F4ezA+jqF-6DA@mail.gmail.com>
> -----Original Message-----
> From: keescook@google.com [mailto:keescook@google.com] On Behalf Of Kees
> Cook
> Sent: Monday, April 3, 2017 10:29 AM
> To: Moore, Robert <robert.moore@intel.com>
> Cc: Zheng, Lv <lv.zheng@intel.com>; linux-kernel@vger.kernel.org;
> Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len Brown
> <lenb@kernel.org>; linux-acpi@vger.kernel.org; devel@acpica.org
> Subject: Re: [PATCH] ACPICA: use designated initializers
>
> On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert <robert.moore@intel.com>
> wrote:
> > Acpica is built with many compilers, even very old ones. It runs on at
> least 12 known operating systems, and very probably more.
> >
> > I'm sorry, but no, we are not going to start adding compiler-specific
> ifdefs/code in the base ACPICA code.
> >
> > I don't care what you do in the Linux-specific or gcc-specific
> headers, however. If this breaks a customer build, we (you) will hear
> about it rather quickly.
>
> Since the change is specific to the one place ACPICA uses an all-
> function-pointer structure, I made the change local:
>
> https://github.com/acpica/acpica/pull/248
>
> would you rather this is in the .h files instead?
>
> -Kees
>
> --
> Kees Cook
> Pixel Security
[Moore, Robert]
I have some questions about this entire issue:
+ * Some compilers can handle designated initializers, which is needed
+ * under Linux kernel builds for structures that are entirely function
* pointers.
I don't understand why this is coming up now, since ACPICA has been integrated with Linux for something like the last 15 years. It's the "which is needed under Linux kernel builds" wording that concerns me the most. Are you saying that the ACPICA build for Linux is broken and does not work?
Further, there are quite a few similar dispatch tables in ACPICA, why are these not a problem?
Bob
WARNING: multiple messages have this Message-ID (diff)
From: Moore, Robert <robert.moore at intel.com>
To: devel@acpica.org
Subject: Re: [Devel] [PATCH] ACPICA: use designated initializers
Date: Tue, 04 Apr 2017 15:02:08 +0000 [thread overview]
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F7BB@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: CAGXu5jJLQmxEcG6nLKn6fsib5meNpw4y1ZLO2F4ezA+jqF-6DA@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]
> -----Original Message-----
> From: keescook(a)google.com [mailto:keescook(a)google.com] On Behalf Of Kees
> Cook
> Sent: Monday, April 3, 2017 10:29 AM
> To: Moore, Robert <robert.moore(a)intel.com>
> Cc: Zheng, Lv <lv.zheng(a)intel.com>; linux-kernel(a)vger.kernel.org;
> Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; Len Brown
> <lenb(a)kernel.org>; linux-acpi(a)vger.kernel.org; devel(a)acpica.org
> Subject: Re: [PATCH] ACPICA: use designated initializers
>
> On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert <robert.moore(a)intel.com>
> wrote:
> > Acpica is built with many compilers, even very old ones. It runs on at
> least 12 known operating systems, and very probably more.
> >
> > I'm sorry, but no, we are not going to start adding compiler-specific
> ifdefs/code in the base ACPICA code.
> >
> > I don't care what you do in the Linux-specific or gcc-specific
> headers, however. If this breaks a customer build, we (you) will hear
> about it rather quickly.
>
> Since the change is specific to the one place ACPICA uses an all-
> function-pointer structure, I made the change local:
>
> https://github.com/acpica/acpica/pull/248
>
> would you rather this is in the .h files instead?
>
> -Kees
>
> --
> Kees Cook
> Pixel Security
[Moore, Robert]
I have some questions about this entire issue:
+ * Some compilers can handle designated initializers, which is needed
+ * under Linux kernel builds for structures that are entirely function
* pointers.
I don't understand why this is coming up now, since ACPICA has been integrated with Linux for something like the last 15 years. It's the "which is needed under Linux kernel builds" wording that concerns me the most. Are you saying that the ACPICA build for Linux is broken and does not work?
Further, there are quite a few similar dispatch tables in ACPICA, why are these not a problem?
Bob
next prev parent reply other threads:[~2017-04-04 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 1:04 [PATCH] ACPICA: use designated initializers Kees Cook
2016-12-17 2:17 ` Rafael J. Wysocki
2016-12-19 6:06 ` Zheng, Lv
2016-12-19 6:06 ` [Devel] " Zheng, Lv
2017-03-29 21:16 ` Kees Cook
2017-03-30 2:12 ` Zheng, Lv
2017-03-30 2:12 ` [Devel] " Zheng, Lv
2017-03-30 14:26 ` Moore, Robert
2017-03-30 14:26 ` [Devel] " Moore, Robert
2017-04-01 0:26 ` Kees Cook
2017-04-01 0:45 ` Moore, Robert
2017-04-01 0:45 ` [Devel] " Moore, Robert
2017-04-03 17:29 ` Kees Cook
2017-04-04 15:02 ` Moore, Robert [this message]
2017-04-04 15:02 ` [Devel] " Moore, Robert
2017-04-04 15:55 ` Kees Cook
2017-05-08 20:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94F2FBAB4432B54E8AACC7DFDE6C92E37E58F7BB@ORSMSX110.amr.corp.intel.com \
--to=robert.moore@intel.com \
--cc=david.e.box@intel.com \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.