From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Hector Marco-Gisbert" <hecmargi@upv.es>,
"Ismael Ripoll" <iripoll@upv.es>,
"Russell King" <linux@arm.linux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, "x86@kernel.org" <x86@kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Andy Lutomirski" <luto@amacapital.net>,
"Oleg Nesterov" <oleg@redhat.com>,
"David A. Long" <dave.long@linaro.org>,
"Andrey Ryabinin" <a.ryabinin@samsung.com>,
"Arun Chandran" <achandran@mvista.com>,
"Yann Droneaud" <ydroneaud@opteya.com>,
"Min-Hua Chen" <orca.chen@gmail.com>,
"Paul Burton" <paul.burton@imgtec.com>,
"Alex Smith" <alex@alex-smith.me.uk>,
"Markos Chandras" <markos.chandras@imgtec.com>,
"Vineeth Vijayan" <vvijayan@mvista.com>,
"Jeff Bailey" <jeffbailey@google.com>,
"Michael Holzheu" <holzheu@linux.vnet.ibm.com>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Borislav Petkov" <bp@suse.de>, "Jan-Simon Möller" <dl9pf@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Linux MIPS Mailing List" <linux-mips@linux-mips.org>,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4 0/10] split ET_DYN ASLR from mmap ASLR
Date: Wed, 4 Mar 2015 13:58:14 -0800 [thread overview]
Message-ID: <CAGXu5jJTGms38aWJgFerjaAxPLDkXuGAx69ihzUrcWZ0BMbpqg@mail.gmail.com> (raw)
In-Reply-To: <20150304215437.GA22254@gmail.com>
On Wed, Mar 4, 2015 at 1:54 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN
>> ASLR from mmap ASLR, as already done on s390. The architectures
>> that are already randomizing mmap (arm, arm64, mips, powerpc, s390,
>> and x86), have their various forms of arch_mmap_rnd() made available
>> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures,
>> arch_randomize_brk() is collapsed as well.
>>
>> This is an alternative to the solutions in:
>> https://lkml.org/lkml/2015/2/23/442
>>
>> I've been able to test x86 and arm, and the buildbot (so far) seems
>> happy with building the rest.
>
> Ok, this looks really good - for all patches:
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
Great! Thanks for the suggestions and reviews. :)
-Kees
--
Kees Cook
Chrome OS Security
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Hector Marco-Gisbert <hecmargi@upv.es>,
Ismael Ripoll <iripoll@upv.es>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, "x86@kernel.org" <x86@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
"David A. Long" <dave.long@linaro.org>,
Andrey Ryabinin <a.ryabinin@samsung.com>,
Arun Chandran <achandran@mvista.com>,
Yann Droneaud <ydroneaud@opteya.com>,
Min-Hua Chen <orca.chen@gmail.com
Subject: Re: [PATCH v4 0/10] split ET_DYN ASLR from mmap ASLR
Date: Wed, 4 Mar 2015 13:58:14 -0800 [thread overview]
Message-ID: <CAGXu5jJTGms38aWJgFerjaAxPLDkXuGAx69ihzUrcWZ0BMbpqg@mail.gmail.com> (raw)
In-Reply-To: <20150304215437.GA22254@gmail.com>
On Wed, Mar 4, 2015 at 1:54 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN
>> ASLR from mmap ASLR, as already done on s390. The architectures
>> that are already randomizing mmap (arm, arm64, mips, powerpc, s390,
>> and x86), have their various forms of arch_mmap_rnd() made available
>> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures,
>> arch_randomize_brk() is collapsed as well.
>>
>> This is an alternative to the solutions in:
>> https://lkml.org/lkml/2015/2/23/442
>>
>> I've been able to test x86 and arm, and the buildbot (so far) seems
>> happy with building the rest.
>
> Ok, this looks really good - for all patches:
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
Great! Thanks for the suggestions and reviews. :)
-Kees
--
Kees Cook
Chrome OS Security
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Linux MIPS Mailing List" <linux-mips@linux-mips.org>,
"Arun Chandran" <achandran@mvista.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
"Min-Hua Chen" <orca.chen@gmail.com>,
"Paul Mackerras" <paulus@samba.org>,
"Ismael Ripoll" <iripoll@upv.es>,
"Yann Droneaud" <ydroneaud@opteya.com>,
linux-s390@vger.kernel.org,
"Russell King" <linux@arm.linux.org.uk>,
"Andrey Ryabinin" <a.ryabinin@samsung.com>,
"x86@kernel.org" <x86@kernel.org>,
"Hector Marco-Gisbert" <hecmargi@upv.es>,
"Ingo Molnar" <mingo@redhat.com>,
"David A. Long" <dave.long@linaro.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Borislav Petkov" <bp@suse.de>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Will Deacon" <will.deacon@arm.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Michael Holzheu" <holzheu@linux.vnet.ibm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Jeff Bailey" <jeffbailey@google.com>,
"Paul Burton" <paul.burton@imgtec.com>,
"Oleg Nesterov" <oleg@redhat.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Vineeth Vijayan" <vvijayan@mvista.com>,
"Markos Chandras" <markos.chandras@imgtec.com>,
"Jan-Simon Möller" <dl9pf@gmx.de>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, "Andrew Morton" <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"Alex Smith" <alex@alex-smith.me.uk>
Subject: Re: [PATCH v4 0/10] split ET_DYN ASLR from mmap ASLR
Date: Wed, 4 Mar 2015 13:58:14 -0800 [thread overview]
Message-ID: <CAGXu5jJTGms38aWJgFerjaAxPLDkXuGAx69ihzUrcWZ0BMbpqg@mail.gmail.com> (raw)
In-Reply-To: <20150304215437.GA22254@gmail.com>
On Wed, Mar 4, 2015 at 1:54 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN
>> ASLR from mmap ASLR, as already done on s390. The architectures
>> that are already randomizing mmap (arm, arm64, mips, powerpc, s390,
>> and x86), have their various forms of arch_mmap_rnd() made available
>> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures,
>> arch_randomize_brk() is collapsed as well.
>>
>> This is an alternative to the solutions in:
>> https://lkml.org/lkml/2015/2/23/442
>>
>> I've been able to test x86 and arm, and the buildbot (so far) seems
>> happy with building the rest.
>
> Ok, this looks really good - for all patches:
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
Great! Thanks for the suggestions and reviews. :)
-Kees
--
Kees Cook
Chrome OS Security
WARNING: multiple messages have this Message-ID (diff)
From: keescook@chromium.org (Kees Cook)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/10] split ET_DYN ASLR from mmap ASLR
Date: Wed, 4 Mar 2015 13:58:14 -0800 [thread overview]
Message-ID: <CAGXu5jJTGms38aWJgFerjaAxPLDkXuGAx69ihzUrcWZ0BMbpqg@mail.gmail.com> (raw)
In-Reply-To: <20150304215437.GA22254@gmail.com>
On Wed, Mar 4, 2015 at 1:54 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN
>> ASLR from mmap ASLR, as already done on s390. The architectures
>> that are already randomizing mmap (arm, arm64, mips, powerpc, s390,
>> and x86), have their various forms of arch_mmap_rnd() made available
>> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures,
>> arch_randomize_brk() is collapsed as well.
>>
>> This is an alternative to the solutions in:
>> https://lkml.org/lkml/2015/2/23/442
>>
>> I've been able to test x86 and arm, and the buildbot (so far) seems
>> happy with building the rest.
>
> Ok, this looks really good - for all patches:
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
Great! Thanks for the suggestions and reviews. :)
-Kees
--
Kees Cook
Chrome OS Security
next prev parent reply other threads:[~2015-03-04 21:58 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 21:10 [PATCH v4 0/10] split ET_DYN ASLR from mmap ASLR Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 01/10] arm: factor out mmap ASLR into mmap_rnd Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 02/10] x86: standardize mmap_rnd() usage Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 03/10] arm64: " Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-17 14:47 ` Will Deacon
2015-03-17 14:47 ` Will Deacon
2015-03-17 14:47 ` Will Deacon
2015-03-17 14:47 ` Will Deacon
2015-03-17 15:19 ` Kees Cook
2015-03-17 15:19 ` Kees Cook
2015-03-17 15:19 ` Kees Cook
2015-03-17 15:19 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 04/10] mips: extract logic for mmap_rnd() Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 05/10] powerpc: standardize mmap_rnd() usage Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 06/10] s390: " Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-09 17:41 ` Martin Schwidefsky
2015-03-09 17:41 ` Martin Schwidefsky
2015-03-09 17:41 ` Martin Schwidefsky
2015-03-09 17:41 ` Martin Schwidefsky
2015-03-04 21:10 ` [PATCH v4 07/10] mm: expose arch_mmap_rnd when available Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 08/10] s390: redefine randomize_et_dyn for ELF_ET_DYN_BASE Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-09 17:42 ` Martin Schwidefsky
2015-03-09 17:42 ` Martin Schwidefsky
2015-03-09 17:42 ` Martin Schwidefsky
2015-03-09 17:42 ` Martin Schwidefsky
2015-03-04 21:10 ` [PATCH v4 09/10] mm: split ET_DYN ASLR from mmap ASLR Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` [PATCH v4 10/10] mm: fold arch_randomize_brk into ARCH_HAS_ELF_RANDOMIZE Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:10 ` Kees Cook
2015-03-04 21:54 ` [PATCH v4 0/10] split ET_DYN ASLR from mmap ASLR Ingo Molnar
2015-03-04 21:54 ` Ingo Molnar
2015-03-04 21:54 ` Ingo Molnar
2015-03-04 21:54 ` Ingo Molnar
2015-03-04 21:58 ` Kees Cook [this message]
2015-03-04 21:58 ` Kees Cook
2015-03-04 21:58 ` Kees Cook
2015-03-04 21:58 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJTGms38aWJgFerjaAxPLDkXuGAx69ihzUrcWZ0BMbpqg@mail.gmail.com \
--to=keescook@chromium.org \
--cc=a.ryabinin@samsung.com \
--cc=achandran@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=alex@alex-smith.me.uk \
--cc=ben@decadent.org.uk \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=dave.long@linaro.org \
--cc=dl9pf@gmx.de \
--cc=hecmargi@upv.es \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=iripoll@upv.es \
--cc=jeffbailey@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@amacapital.net \
--cc=markos.chandras@imgtec.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=orca.chen@gmail.com \
--cc=paul.burton@imgtec.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vvijayan@mvista.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.