All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
@ 2023-09-13  8:44 ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2023-09-13  8:44 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, AngeloGioacchino Del Regno

The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
regulator, having the same voltage setting and output pin. There are
simply two enable bits that are ORed together to enable the regulator.

Having two regulators representing the same output pin is misleading
from a design matching standpoint, and also error-prone in driver
implementations.

Now that the bindings have these two merged, merge them in the device
tree as well. Neither vcn33 regulators are referenced in upstream
device trees. As far as hardware designs go, none of the Chromebooks
using MT8183 w/ MT6358 use this output.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
This was part of the series "regulator: mt6358: Remove bogus regulators
and improvements". Since the driver parts related to this patch have all
been picked up, so I'm sending this separately.

 arch/arm64/boot/dts/mediatek/mt6358.dtsi | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
index 96ba8490b629..ad5e4022e06d 100644
--- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
@@ -292,15 +292,8 @@ mt6358_vrf18_reg: ldo_vrf18 {
 				regulator-enable-ramp-delay = <120>;
 			};
 
-			mt6358_vcn33_bt_reg: ldo_vcn33_bt {
-				regulator-name = "vcn33_bt";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3500000>;
-				regulator-enable-ramp-delay = <270>;
-			};
-
-			mt6358_vcn33_wifi_reg: ldo_vcn33_wifi {
-				regulator-name = "vcn33_wifi";
+			mt6358_vcn33_reg: ldo_vcn33 {
+				regulator-name = "vcn33";
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3500000>;
 				regulator-enable-ramp-delay = <270>;
-- 
2.42.0.283.g2d96d420d3-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
@ 2023-09-13  8:44 ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2023-09-13  8:44 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, AngeloGioacchino Del Regno

The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
regulator, having the same voltage setting and output pin. There are
simply two enable bits that are ORed together to enable the regulator.

Having two regulators representing the same output pin is misleading
from a design matching standpoint, and also error-prone in driver
implementations.

Now that the bindings have these two merged, merge them in the device
tree as well. Neither vcn33 regulators are referenced in upstream
device trees. As far as hardware designs go, none of the Chromebooks
using MT8183 w/ MT6358 use this output.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
This was part of the series "regulator: mt6358: Remove bogus regulators
and improvements". Since the driver parts related to this patch have all
been picked up, so I'm sending this separately.

 arch/arm64/boot/dts/mediatek/mt6358.dtsi | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
index 96ba8490b629..ad5e4022e06d 100644
--- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
@@ -292,15 +292,8 @@ mt6358_vrf18_reg: ldo_vrf18 {
 				regulator-enable-ramp-delay = <120>;
 			};
 
-			mt6358_vcn33_bt_reg: ldo_vcn33_bt {
-				regulator-name = "vcn33_bt";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3500000>;
-				regulator-enable-ramp-delay = <270>;
-			};
-
-			mt6358_vcn33_wifi_reg: ldo_vcn33_wifi {
-				regulator-name = "vcn33_wifi";
+			mt6358_vcn33_reg: ldo_vcn33 {
+				regulator-name = "vcn33";
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3500000>;
 				regulator-enable-ramp-delay = <270>;
-- 
2.42.0.283.g2d96d420d3-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
  2023-09-13  8:44 ` Chen-Yu Tsai
@ 2023-11-27  3:07   ` Chen-Yu Tsai
  -1 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2023-11-27  3:07 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel

Hi Matthias, Angelo,

On Wed, Sep 13, 2023 at 4:45 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
> regulator, having the same voltage setting and output pin. There are
> simply two enable bits that are ORed together to enable the regulator.
>
> Having two regulators representing the same output pin is misleading
> from a design matching standpoint, and also error-prone in driver
> implementations.
>
> Now that the bindings have these two merged, merge them in the device
> tree as well. Neither vcn33 regulators are referenced in upstream
> device trees. As far as hardware designs go, none of the Chromebooks
> using MT8183 w/ MT6358 use this output.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Please remember to queue this up. All the driver changes were merged in
the last cycle.

ChenYu

> ---
> This was part of the series "regulator: mt6358: Remove bogus regulators
> and improvements". Since the driver parts related to this patch have all
> been picked up, so I'm sending this separately.
>
>  arch/arm64/boot/dts/mediatek/mt6358.dtsi | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> index 96ba8490b629..ad5e4022e06d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -292,15 +292,8 @@ mt6358_vrf18_reg: ldo_vrf18 {
>                                 regulator-enable-ramp-delay = <120>;
>                         };
>
> -                       mt6358_vcn33_bt_reg: ldo_vcn33_bt {
> -                               regulator-name = "vcn33_bt";
> -                               regulator-min-microvolt = <3300000>;
> -                               regulator-max-microvolt = <3500000>;
> -                               regulator-enable-ramp-delay = <270>;
> -                       };
> -
> -                       mt6358_vcn33_wifi_reg: ldo_vcn33_wifi {
> -                               regulator-name = "vcn33_wifi";
> +                       mt6358_vcn33_reg: ldo_vcn33 {
> +                               regulator-name = "vcn33";
>                                 regulator-min-microvolt = <3300000>;
>                                 regulator-max-microvolt = <3500000>;
>                                 regulator-enable-ramp-delay = <270>;
> --
> 2.42.0.283.g2d96d420d3-goog
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
@ 2023-11-27  3:07   ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2023-11-27  3:07 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel

Hi Matthias, Angelo,

On Wed, Sep 13, 2023 at 4:45 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
> regulator, having the same voltage setting and output pin. There are
> simply two enable bits that are ORed together to enable the regulator.
>
> Having two regulators representing the same output pin is misleading
> from a design matching standpoint, and also error-prone in driver
> implementations.
>
> Now that the bindings have these two merged, merge them in the device
> tree as well. Neither vcn33 regulators are referenced in upstream
> device trees. As far as hardware designs go, none of the Chromebooks
> using MT8183 w/ MT6358 use this output.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Please remember to queue this up. All the driver changes were merged in
the last cycle.

ChenYu

> ---
> This was part of the series "regulator: mt6358: Remove bogus regulators
> and improvements". Since the driver parts related to this patch have all
> been picked up, so I'm sending this separately.
>
>  arch/arm64/boot/dts/mediatek/mt6358.dtsi | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> index 96ba8490b629..ad5e4022e06d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -292,15 +292,8 @@ mt6358_vrf18_reg: ldo_vrf18 {
>                                 regulator-enable-ramp-delay = <120>;
>                         };
>
> -                       mt6358_vcn33_bt_reg: ldo_vcn33_bt {
> -                               regulator-name = "vcn33_bt";
> -                               regulator-min-microvolt = <3300000>;
> -                               regulator-max-microvolt = <3500000>;
> -                               regulator-enable-ramp-delay = <270>;
> -                       };
> -
> -                       mt6358_vcn33_wifi_reg: ldo_vcn33_wifi {
> -                               regulator-name = "vcn33_wifi";
> +                       mt6358_vcn33_reg: ldo_vcn33 {
> +                               regulator-name = "vcn33";
>                                 regulator-min-microvolt = <3300000>;
>                                 regulator-max-microvolt = <3500000>;
>                                 regulator-enable-ramp-delay = <270>;
> --
> 2.42.0.283.g2d96d420d3-goog
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
  2023-09-13  8:44 ` Chen-Yu Tsai
@ 2023-11-27 12:57   ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-27 12:57 UTC (permalink / raw)
  To: Chen-Yu Tsai, Matthias Brugger
  Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel

On Wed, 13 Sep 2023 16:44:56 +0800, Chen-Yu Tsai wrote:
 > The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
 > regulator, having the same voltage setting and output pin. There are
 > simply two enable bits that are ORed together to enable the regulator.
 >
 > Having two regulators representing the same output pin is misleading
 > from a design matching standpoint, and also error-prone in driver
 > implementations.
 >
 > [...]

Applied, thanks!

[1/1] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
       commit: 2a19d6609722b40d0f44337d56ee75a69a69aeab

Regards,
Angelo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
@ 2023-11-27 12:57   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-11-27 12:57 UTC (permalink / raw)
  To: Chen-Yu Tsai, Matthias Brugger
  Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel

On Wed, 13 Sep 2023 16:44:56 +0800, Chen-Yu Tsai wrote:
 > The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
 > regulator, having the same voltage setting and output pin. There are
 > simply two enable bits that are ORed together to enable the regulator.
 >
 > Having two regulators representing the same output pin is misleading
 > from a design matching standpoint, and also error-prone in driver
 > implementations.
 >
 > [...]

Applied, thanks!

[1/1] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
       commit: 2a19d6609722b40d0f44337d56ee75a69a69aeab

Regards,
Angelo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-27 12:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-13  8:44 [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators Chen-Yu Tsai
2023-09-13  8:44 ` Chen-Yu Tsai
2023-11-27  3:07 ` Chen-Yu Tsai
2023-11-27  3:07   ` Chen-Yu Tsai
2023-11-27 12:57 ` AngeloGioacchino Del Regno
2023-11-27 12:57   ` AngeloGioacchino Del Regno

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.