All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wenst@chromium.org>
To: Kewei Xu <kewei.xu@mediatek.com>
Cc: wsa@the-dreams.de, Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mediatek@lists.infradead.org,
	srv_heupstream <srv_heupstream@mediatek.com>,
	leilk.liu@mediatek.com, qii.wang@mediatek.com,
	qiangming.xia@mediatek.com, ot_daolong.zhu@mediatek.com
Subject: Re: [PATCH 0/8] Due to changes in hardware design, add patch to
Date: Thu, 15 Jul 2021 11:03:19 +0800	[thread overview]
Message-ID: <CAGXv+5FKvz7zwi1k=TZ3YTJJ+facezqN_oigRFEeR26OrejRnw@mail.gmail.com> (raw)
In-Reply-To: <1626316157-24935-1-git-send-email-kewei.xu@mediatek.com>

Hi,

On Thu, Jul 15, 2021 at 10:37 AM Kewei Xu <kewei.xu@mediatek.com> wrote:
>
> 1. In order to facilitate the review, the two series of patches submitted
>    before have been integrated together.

I'm not sure that really helps. We'll see.

> 2. Resubmit a patch to fixing the incorrect register value.

Fixes can be submitted separately, or at the very least, put at the very
front of the series.

> 3. Add modify bus speed calculation formula patch

When resubmitting patch series, please add appropriate versioning and
changelogs. This will help maintainers understand that this is a new
version of the series, and what has changed. This includes times when
the original patches weren't changed, but additional patches were added.

Please also keep the original series subject, which IIRC was about adding
support for MT8195 I2C. The subject you now used should be part of the
cover letter.

If you combine different patch series, you should use the highest version
number + 1.


Regards
ChenYu

>
> Kewei Xu (8):
>   dt-bindings: i2c: update bindings for MT8195 SoC
>   i2c: mediatek: Dump i2c/dma register when a timeout occurs
>   i2c: mediatek: fixing the incorrect register offset
>   i2c: mediatek: Reset the handshake signal between i2c and dma
>   i2c: mediatek: Add OFFSET_EXT_CONF setting back
>   dt-bindings: i2c: add attribute default-timing-adjust
>   i2c: mediatek: Isolate speed setting via dts for special devices
>   i2c: mediatek: modify bus speed calculation formula
>
>  .../devicetree/bindings/i2c/i2c-mt65xx.txt         |   3 +
>  drivers/i2c/busses/i2c-mt65xx.c                    | 229 +++++++++++++++++++--
>  2 files changed, 217 insertions(+), 15 deletions(-)
>
> --
> 1.9.1
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Kewei Xu <kewei.xu@mediatek.com>
Cc: wsa@the-dreams.de, Matthias Brugger <matthias.bgg@gmail.com>,
	 Rob Herring <robh+dt@kernel.org>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	 linux-mediatek@lists.infradead.org,
	 srv_heupstream <srv_heupstream@mediatek.com>,
	leilk.liu@mediatek.com, qii.wang@mediatek.com,
	 qiangming.xia@mediatek.com, ot_daolong.zhu@mediatek.com
Subject: Re: [PATCH 0/8] Due to changes in hardware design, add patch to
Date: Thu, 15 Jul 2021 11:03:19 +0800	[thread overview]
Message-ID: <CAGXv+5FKvz7zwi1k=TZ3YTJJ+facezqN_oigRFEeR26OrejRnw@mail.gmail.com> (raw)
In-Reply-To: <1626316157-24935-1-git-send-email-kewei.xu@mediatek.com>

Hi,

On Thu, Jul 15, 2021 at 10:37 AM Kewei Xu <kewei.xu@mediatek.com> wrote:
>
> 1. In order to facilitate the review, the two series of patches submitted
>    before have been integrated together.

I'm not sure that really helps. We'll see.

> 2. Resubmit a patch to fixing the incorrect register value.

Fixes can be submitted separately, or at the very least, put at the very
front of the series.

> 3. Add modify bus speed calculation formula patch

When resubmitting patch series, please add appropriate versioning and
changelogs. This will help maintainers understand that this is a new
version of the series, and what has changed. This includes times when
the original patches weren't changed, but additional patches were added.

Please also keep the original series subject, which IIRC was about adding
support for MT8195 I2C. The subject you now used should be part of the
cover letter.

If you combine different patch series, you should use the highest version
number + 1.


Regards
ChenYu

>
> Kewei Xu (8):
>   dt-bindings: i2c: update bindings for MT8195 SoC
>   i2c: mediatek: Dump i2c/dma register when a timeout occurs
>   i2c: mediatek: fixing the incorrect register offset
>   i2c: mediatek: Reset the handshake signal between i2c and dma
>   i2c: mediatek: Add OFFSET_EXT_CONF setting back
>   dt-bindings: i2c: add attribute default-timing-adjust
>   i2c: mediatek: Isolate speed setting via dts for special devices
>   i2c: mediatek: modify bus speed calculation formula
>
>  .../devicetree/bindings/i2c/i2c-mt65xx.txt         |   3 +
>  drivers/i2c/busses/i2c-mt65xx.c                    | 229 +++++++++++++++++++--
>  2 files changed, 217 insertions(+), 15 deletions(-)
>
> --
> 1.9.1
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wenst@chromium.org>
To: Kewei Xu <kewei.xu@mediatek.com>
Cc: wsa@the-dreams.de, Matthias Brugger <matthias.bgg@gmail.com>,
	 Rob Herring <robh+dt@kernel.org>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	 linux-mediatek@lists.infradead.org,
	 srv_heupstream <srv_heupstream@mediatek.com>,
	leilk.liu@mediatek.com, qii.wang@mediatek.com,
	 qiangming.xia@mediatek.com, ot_daolong.zhu@mediatek.com
Subject: Re: [PATCH 0/8] Due to changes in hardware design, add patch to
Date: Thu, 15 Jul 2021 11:03:19 +0800	[thread overview]
Message-ID: <CAGXv+5FKvz7zwi1k=TZ3YTJJ+facezqN_oigRFEeR26OrejRnw@mail.gmail.com> (raw)
In-Reply-To: <1626316157-24935-1-git-send-email-kewei.xu@mediatek.com>

Hi,

On Thu, Jul 15, 2021 at 10:37 AM Kewei Xu <kewei.xu@mediatek.com> wrote:
>
> 1. In order to facilitate the review, the two series of patches submitted
>    before have been integrated together.

I'm not sure that really helps. We'll see.

> 2. Resubmit a patch to fixing the incorrect register value.

Fixes can be submitted separately, or at the very least, put at the very
front of the series.

> 3. Add modify bus speed calculation formula patch

When resubmitting patch series, please add appropriate versioning and
changelogs. This will help maintainers understand that this is a new
version of the series, and what has changed. This includes times when
the original patches weren't changed, but additional patches were added.

Please also keep the original series subject, which IIRC was about adding
support for MT8195 I2C. The subject you now used should be part of the
cover letter.

If you combine different patch series, you should use the highest version
number + 1.


Regards
ChenYu

>
> Kewei Xu (8):
>   dt-bindings: i2c: update bindings for MT8195 SoC
>   i2c: mediatek: Dump i2c/dma register when a timeout occurs
>   i2c: mediatek: fixing the incorrect register offset
>   i2c: mediatek: Reset the handshake signal between i2c and dma
>   i2c: mediatek: Add OFFSET_EXT_CONF setting back
>   dt-bindings: i2c: add attribute default-timing-adjust
>   i2c: mediatek: Isolate speed setting via dts for special devices
>   i2c: mediatek: modify bus speed calculation formula
>
>  .../devicetree/bindings/i2c/i2c-mt65xx.txt         |   3 +
>  drivers/i2c/busses/i2c-mt65xx.c                    | 229 +++++++++++++++++++--
>  2 files changed, 217 insertions(+), 15 deletions(-)
>
> --
> 1.9.1
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-07-15  3:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  2:29 [PATCH 0/8] Due to changes in hardware design, add patch to Kewei Xu
2021-07-15  2:29 ` Kewei Xu
2021-07-15  2:29 ` Kewei Xu
2021-07-15  2:29 ` [PATCH 1/8] dt-bindings: i2c: update bindings for MT8195 SoC Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  4:09   ` Chen-Yu Tsai
2021-07-15  4:09     ` Chen-Yu Tsai
2021-07-15  4:09     ` Chen-Yu Tsai
2021-07-15  2:29 ` [PATCH 2/8] i2c: mediatek: Dump i2c/dma register when a timeout occurs Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  6:21   ` Chen-Yu Tsai
2021-07-15  6:21     ` Chen-Yu Tsai
2021-07-15  6:21     ` Chen-Yu Tsai
2021-07-15  2:29 ` [PATCH 3/8] i2c: mediatek: fixing the incorrect register offset Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  5:23   ` Chen-Yu Tsai
2021-07-15  5:23     ` Chen-Yu Tsai
2021-07-15  5:23     ` Chen-Yu Tsai
2021-07-16  9:09     ` Kewei Xu
2021-07-16  9:09       ` Kewei Xu
2021-07-16  9:09       ` Kewei Xu
2021-07-15  2:29 ` [PATCH 4/8] i2c: mediatek: Reset the handshake signal between i2c and dma Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29 ` [PATCH 5/8] i2c: mediatek: Add OFFSET_EXT_CONF setting back Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29 ` [PATCH 6/8] dt-bindings: i2c: add attribute default-timing-adjust Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29 ` [PATCH 7/8] i2c: mediatek: Isolate speed setting via dts for special devices Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29 ` [PATCH 8/8] i2c: mediatek: modify bus speed calculation formula Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  2:29   ` Kewei Xu
2021-07-15  7:09   ` Tzung-Bi Shih
2021-07-15  7:09     ` Tzung-Bi Shih
2021-07-15  7:09     ` Tzung-Bi Shih
2021-07-16  9:53     ` Kewei Xu
2021-07-16  9:53       ` Kewei Xu
2021-07-16  9:53       ` Kewei Xu
2021-07-15  3:03 ` Chen-Yu Tsai [this message]
2021-07-15  3:03   ` [PATCH 0/8] Due to changes in hardware design, add patch to Chen-Yu Tsai
2021-07-15  3:03   ` Chen-Yu Tsai
2021-07-17  9:05   ` Kewei Xu
2021-07-17  9:05     ` Kewei Xu
2021-07-17  9:05     ` Kewei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGXv+5FKvz7zwi1k=TZ3YTJJ+facezqN_oigRFEeR26OrejRnw@mail.gmail.com' \
    --to=wenst@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kewei.xu@mediatek.com \
    --cc=leilk.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ot_daolong.zhu@mediatek.com \
    --cc=qiangming.xia@mediatek.com \
    --cc=qii.wang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.