Re: [PATCH v2 00/16] Introduce support for MediaTek MT8192 Google Chromebooks - Chen-Yu Tsai

From: Chen-Yu Tsai <wenst@chromium.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	kernel@collabora.com,
	Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
	Fabien Parent <fparent@baylibre.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Luca Weiss <luca@z3ntu.xyz>, Maxim Kutnij <gtk3@inbox.ru>,
	Rob Herring <robh+dt@kernel.org>,
	Sam Shih <sam.shih@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 00/16] Introduce support for MediaTek MT8192 Google Chromebooks
Date: Fri, 6 May 2022 19:41:19 +0800	[thread overview]
Message-ID: <CAGXv+5Hk2u+1zkVjNEt7wdwAJyoB+-PMAuh7UKWEkDeYxp5zUQ@mail.gmail.com> (raw)
In-Reply-To: <20220505194550.3094656-1-nfraprado@collabora.com>

On Fri, May 6, 2022 at 3:46 AM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
>
> This series introduces Devicetrees for the MT8192-based Asurada platform
> as well as Asurada Spherion and Asurada Hayato boards.
>
> Support for the boards is added to the extent that is currently enabled
> in the mt8192.dtsi, as to not add any dependencies to this series.
>
> Besides the other dt-binding fixes already on linux-next to avoid new
> warnings by this series, [1] is already merged but not on next yet.
>
> This series was peer-reviewed internally before submission.
>
> [1] https://lore.kernel.org/all/20220429201325.2205799-1-nfraprado@collabora.com/
>
> v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@collabora.com/
>
> Changes in v2:
> - Added patches 1-2 for Mediatek board dt-bindings
> - Added patches 13-16 enabling hardware for Asurada that has since been
>   enabled on mt8192.dtsi
>
> Nícolas F. R. A. Prado (16):
>   dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion
>   dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato
>   arm64: dts: mediatek: Introduce MT8192-based Asurada board family
>   arm64: dts: mediatek: asurada: Document GPIO names
>   arm64: dts: mediatek: asurada: Add system-wide power supplies
>   arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses
>   arm64: dts: mediatek: asurada: Add ChromeOS EC
>   arm64: dts: mediatek: asurada: Add keyboard mapping for the top row
>   arm64: dts: mediatek: asurada: Add Cr50 TPM
>   arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad
>   arm64: dts: mediatek: asurada: Add I2C touchscreen
>   arm64: dts: mediatek: spherion: Add keyboard backlight
>   arm64: dts: mediatek: asurada: Enable XHCI
>   arm64: dts: mediatek: asurada: Enable PCIe and add WiFi
>   arm64: dts: mediatek: asurada: Add MT6359 PMIC
>   arm64: dts: mediatek: asurada: Add SPMI regulators

Tested-by: Chen-Yu Tsai <wenst@chromium.org>

I tested all the external peripherals, including touchpad, touchscreen,
keyboard (which needs a fix), USB, WiFi on both models, and the keyboard
backlight and (USB-based) Bluetooth on Spherion.

Could you also enable the SCP? Otherwise the vcodec generates big warnings
when it probes.

And also would like to see MMC. :)

Thanks
ChenYu