* [PATCH] git-bisect: allow running in a working tree subdirectory
@ 2017-01-26 18:30 marcandre.lureau
2017-01-26 18:46 ` Stefan Beller
2017-01-26 21:46 ` Johannes Sixt
0 siblings, 2 replies; 5+ messages in thread
From: marcandre.lureau @ 2017-01-26 18:30 UTC (permalink / raw)
To: git; +Cc: chriscool, Marc-André Lureau
From: Marc-André Lureau <marcandre.lureau@redhat.com>
It looks like it can do it.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
git-bisect.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-bisect.sh b/git-bisect.sh
index ae3cb013e..b0bd604d4 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -1,5 +1,6 @@
#!/bin/sh
+SUBDIRECTORY_OK=Yes
USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
LONG_USAGE='git bisect help
print this long help message.
--
2.11.0.295.gd7dffce1c.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] git-bisect: allow running in a working tree subdirectory
2017-01-26 18:30 [PATCH] git-bisect: allow running in a working tree subdirectory marcandre.lureau
@ 2017-01-26 18:46 ` Stefan Beller
2017-01-26 19:34 ` Junio C Hamano
2017-01-26 21:46 ` Johannes Sixt
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Beller @ 2017-01-26 18:46 UTC (permalink / raw)
To: marcandre.lureau, Duy Nguyen; +Cc: git, Christian Couder
+ Duy, main author of the worktree feature.
On Thu, Jan 26, 2017 at 10:30 AM, <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> It looks like it can do it.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> git-bisect.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-bisect.sh b/git-bisect.sh
> index ae3cb013e..b0bd604d4 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -1,5 +1,6 @@
> #!/bin/sh
>
> +SUBDIRECTORY_OK=Yes
> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
> LONG_USAGE='git bisect help
> print this long help message.
> --
> 2.11.0.295.gd7dffce1c.dirty
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] git-bisect: allow running in a working tree subdirectory
2017-01-26 18:46 ` Stefan Beller
@ 2017-01-26 19:34 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2017-01-26 19:34 UTC (permalink / raw)
To: Stefan Beller; +Cc: marcandre.lureau, Duy Nguyen, git, Christian Couder
Stefan Beller <sbeller@google.com> writes:
> + Duy, main author of the worktree feature.
>
> On Thu, Jan 26, 2017 at 10:30 AM, <marcandre.lureau@redhat.com> wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> It looks like it can do it.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
I do not think the OP meant by "a working tree subdirectory" using
the command in a secondary worktree. SUBDIRECTORY_OK is about "can
the command be started in a subdirectory (as opposed to requiring to
be run only at the toplevel)?"
I am slightly negative on this change, though. The subdirectory you
are sitting in when you start your bisection may disappear and reappear
as you dig the history, and I do not think the code makes anything
special to prevent the disappearing current directory from getting
in the way of bisection process.
>> git-bisect.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index ae3cb013e..b0bd604d4 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>> @@ -1,5 +1,6 @@
>> #!/bin/sh
>>
>> +SUBDIRECTORY_OK=Yes
>> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
>> LONG_USAGE='git bisect help
>> print this long help message.
>> --
>> 2.11.0.295.gd7dffce1c.dirty
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] git-bisect: allow running in a working tree subdirectory
2017-01-26 18:30 [PATCH] git-bisect: allow running in a working tree subdirectory marcandre.lureau
2017-01-26 18:46 ` Stefan Beller
@ 2017-01-26 21:46 ` Johannes Sixt
2017-01-26 23:22 ` Junio C Hamano
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Sixt @ 2017-01-26 21:46 UTC (permalink / raw)
To: marcandre.lureau; +Cc: git, chriscool
Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> It looks like it can do it.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> git-bisect.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-bisect.sh b/git-bisect.sh
> index ae3cb013e..b0bd604d4 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -1,5 +1,6 @@
> #!/bin/sh
>
> +SUBDIRECTORY_OK=Yes
> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
> LONG_USAGE='git bisect help
> print this long help message.
>
Does it also work to drive git bisect from a subdirectory and pass a
file name (or pathspec) that is relative to that subdirectory rather
than relative to the root of the worktree? Can `git bisect good` or `git
bisect bad` of later bisection steps be invoked from different
subdirectories or the root?
-- Hannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] git-bisect: allow running in a working tree subdirectory
2017-01-26 21:46 ` Johannes Sixt
@ 2017-01-26 23:22 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2017-01-26 23:22 UTC (permalink / raw)
To: Johannes Sixt; +Cc: marcandre.lureau, git, chriscool
Johannes Sixt <j6t@kdbg.org> writes:
> Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> It looks like it can do it.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> git-bisect.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index ae3cb013e..b0bd604d4 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>> @@ -1,5 +1,6 @@
>> #!/bin/sh
>>
>> +SUBDIRECTORY_OK=Yes
>> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
>> LONG_USAGE='git bisect help
>> print this long help message.
>>
>
> Does it also work to drive git bisect from a subdirectory and pass a
> file name (or pathspec) that is relative to that subdirectory rather
> than relative to the root of the worktree? Can `git bisect good` or
> `git bisect bad` of later bisection steps be invoked from different
> subdirectories or the root?
I think the answers are no and no. Entries in BISECT_NAMES and
BISECT_LOG are not getting any prefix.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-26 23:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 18:30 [PATCH] git-bisect: allow running in a working tree subdirectory marcandre.lureau
2017-01-26 18:46 ` Stefan Beller
2017-01-26 19:34 ` Junio C Hamano
2017-01-26 21:46 ` Johannes Sixt
2017-01-26 23:22 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.