Re: [PATCH 1/5] http: use strbufs instead of fixed buffers

From: Stefan Beller <sbeller@google.com>
To: Jeff King <peff@peff.net>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 1/5] http: use strbufs instead of fixed buffers
Date: Mon, 21 May 2018 13:57:22 -0700	[thread overview]
Message-ID: <CAGZ79kbPuR8w1goGu6qgMRqF+myMUhtmXYSA7Wxh8VQy8dRBig@mail.gmail.com> (raw)
In-Reply-To: <20180521194120.GA9742@sigill.intra.peff.net>

On Mon, May 21, 2018 at 12:41 PM, Jeff King <peff@peff.net> wrote:
> On Mon, May 21, 2018 at 11:11:51AM -0700, Stefan Beller wrote:
>
>> Hi Jeff,
>>
>> On Fri, May 18, 2018 at 6:56 PM, Jeff King <peff@peff.net> wrote:
>>
>> > @@ -2421,4 +2426,5 @@ void release_http_object_request(struct http_object_request *freq)
>> ..
>> > +       strbuf_release(&freq->tmpfile);
>>
>> Do we need an equivalent in release_http_pack_request as well?
>
> Yes, but isn't there one?
>
> From the original patch:
>
> --- a/http.c
> +++ b/http.c
> @@ -2082,6 +2082,7 @@ void release_http_pack_request(struct http_pack_request *preq)
>                 preq->packfile = NULL;
>         }
>         preq->slot = NULL;
> +       strbuf_release(&preq->tmpfile);
>         free(preq->url);
>         free(preq);
>  }

which is at the very top, but I was not looking this far up,
but looked for functions order that my editor had.

Clearly I have to practice code reviews, still.

Sorry for the noise.

Stefan