From: Ben Peart <peartben@gmail.com>
To: "René Scharfe" <l.s.r@web.de>, "Jeff King" <peff@peff.net>,
git@vger.kernel.org
Cc: Ben Peart <benpeart@microsoft.com>
Subject: Re: [PATCH 3/5] query_fsmonitor: use xsnprintf for formatting integers
Date: Mon, 21 May 2018 08:36:06 -0400 [thread overview]
Message-ID: <c5d9da23-447d-2878-cf4f-e9e7f12ce35f@gmail.com> (raw)
In-Reply-To: <cd6dba3c-19bb-e6c7-0c1f-5cea0c8f9d81@web.de>
On 5/19/2018 4:27 AM, René Scharfe wrote:
> Am 19.05.2018 um 03:57 schrieb Jeff King:
>> These formatted integers should always fit into their
>> 64-byte buffers. Let's use xsnprintf() to add an assertion
>> that this is the case, which makes auditing for other
>> unchecked snprintfs() easier.
>
> How about this instead?
>
> -- >8 --
>
> - snprintf(ver, sizeof(ver), "%d", version);
> - snprintf(date, sizeof(date), "%" PRIuMAX, (uintmax_t)last_update);
> - argv[1] = ver;
> - argv[2] = date;
> - argv[3] = NULL;
> - cp.argv = argv;
> + argv_array_push(&cp.args, core_fsmonitor);
> + argv_array_pushf(&cp.args, "%d", version);
> + argv_array_pushf(&cp.args, "%" PRIuMAX, (uintmax_t)last_update);
Looks good. Simpler, cleaner, less error prone.
> cp.use_shell = 1;
> cp.dir = get_git_work_tree();
>
>
next prev parent reply other threads:[~2018-05-21 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 1:54 [PATCH 0/5] snprintf truncation fixes Jeff King
2018-05-19 1:56 ` [PATCH 1/5] http: use strbufs instead of fixed buffers Jeff King
2018-05-21 18:11 ` Stefan Beller
2018-05-21 19:41 ` Jeff King
2018-05-21 20:57 ` Stefan Beller
2018-05-19 1:57 ` [PATCH 2/5] log_write_email_headers: use strbufs Jeff King
2018-05-19 1:57 ` [PATCH 3/5] query_fsmonitor: use xsnprintf for formatting integers Jeff King
2018-05-19 8:27 ` René Scharfe
2018-05-20 17:08 ` Jeff King
2018-05-21 0:58 ` Junio C Hamano
2018-05-21 12:36 ` Ben Peart [this message]
2018-05-19 1:58 ` [PATCH 4/5] shorten_unambiguous_ref: use xsnprintf Jeff King
2018-05-19 1:58 ` [PATCH 5/5] fmt_with_err: add a comment that truncation is OK Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5d9da23-447d-2878-cf4f-e9e7f12ce35f@gmail.com \
--to=peartben@gmail.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.