* [PATCH] kfence: unconditionally use unbound work queue
@ 2021-05-21 11:16 ` Marco Elver
0 siblings, 0 replies; 4+ messages in thread
From: Marco Elver @ 2021-05-21 11:16 UTC (permalink / raw)
To: elver, akpm
Cc: glider, dvyukov, linux-kernel, linux-mm, kasan-dev, Hillf Danton
Unconditionally use unbound work queue, and not just if
wq_power_efficient is true. Because if the system is idle, KFENCE may
wait, and by being run on the unbound work queue, we permit the
scheduler to make better scheduling decisions and not require pinning
KFENCE to the same CPU upon waking up.
Fixes: 36f0b35d0894 ("kfence: use power-efficient work queue to run delayed work")
Reported-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Marco Elver <elver@google.com>
---
mm/kfence/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/kfence/core.c b/mm/kfence/core.c
index 4d21ac44d5d3..d7666ace9d2e 100644
--- a/mm/kfence/core.c
+++ b/mm/kfence/core.c
@@ -636,7 +636,7 @@ static void toggle_allocation_gate(struct work_struct *work)
/* Disable static key and reset timer. */
static_branch_disable(&kfence_allocation_key);
#endif
- queue_delayed_work(system_power_efficient_wq, &kfence_timer,
+ queue_delayed_work(system_unbound_wq, &kfence_timer,
msecs_to_jiffies(kfence_sample_interval));
}
static DECLARE_DELAYED_WORK(kfence_timer, toggle_allocation_gate);
@@ -666,7 +666,7 @@ void __init kfence_init(void)
}
WRITE_ONCE(kfence_enabled, true);
- queue_delayed_work(system_power_efficient_wq, &kfence_timer, 0);
+ queue_delayed_work(system_unbound_wq, &kfence_timer, 0);
pr_info("initialized - using %lu bytes for %d objects at 0x%p-0x%p\n", KFENCE_POOL_SIZE,
CONFIG_KFENCE_NUM_OBJECTS, (void *)__kfence_pool,
(void *)(__kfence_pool + KFENCE_POOL_SIZE));
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] kfence: unconditionally use unbound work queue
@ 2021-05-21 11:16 ` Marco Elver
0 siblings, 0 replies; 4+ messages in thread
From: Marco Elver @ 2021-05-21 11:16 UTC (permalink / raw)
To: elver, akpm
Cc: glider, dvyukov, linux-kernel, linux-mm, kasan-dev, Hillf Danton
Unconditionally use unbound work queue, and not just if
wq_power_efficient is true. Because if the system is idle, KFENCE may
wait, and by being run on the unbound work queue, we permit the
scheduler to make better scheduling decisions and not require pinning
KFENCE to the same CPU upon waking up.
Fixes: 36f0b35d0894 ("kfence: use power-efficient work queue to run delayed work")
Reported-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Marco Elver <elver@google.com>
---
mm/kfence/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/kfence/core.c b/mm/kfence/core.c
index 4d21ac44d5d3..d7666ace9d2e 100644
--- a/mm/kfence/core.c
+++ b/mm/kfence/core.c
@@ -636,7 +636,7 @@ static void toggle_allocation_gate(struct work_struct *work)
/* Disable static key and reset timer. */
static_branch_disable(&kfence_allocation_key);
#endif
- queue_delayed_work(system_power_efficient_wq, &kfence_timer,
+ queue_delayed_work(system_unbound_wq, &kfence_timer,
msecs_to_jiffies(kfence_sample_interval));
}
static DECLARE_DELAYED_WORK(kfence_timer, toggle_allocation_gate);
@@ -666,7 +666,7 @@ void __init kfence_init(void)
}
WRITE_ONCE(kfence_enabled, true);
- queue_delayed_work(system_power_efficient_wq, &kfence_timer, 0);
+ queue_delayed_work(system_unbound_wq, &kfence_timer, 0);
pr_info("initialized - using %lu bytes for %d objects at 0x%p-0x%p\n", KFENCE_POOL_SIZE,
CONFIG_KFENCE_NUM_OBJECTS, (void *)__kfence_pool,
(void *)(__kfence_pool + KFENCE_POOL_SIZE));
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kfence: unconditionally use unbound work queue
2021-05-21 11:16 ` Marco Elver
@ 2021-05-21 11:23 ` Alexander Potapenko
-1 siblings, 0 replies; 4+ messages in thread
From: Alexander Potapenko @ 2021-05-21 11:23 UTC (permalink / raw)
To: Marco Elver
Cc: Andrew Morton, Dmitriy Vyukov, LKML,
Linux Memory Management List, kasan-dev, Hillf Danton
On Fri, May 21, 2021 at 1:16 PM Marco Elver <elver@google.com> wrote:
>
> Unconditionally use unbound work queue, and not just if
> wq_power_efficient is true. Because if the system is idle, KFENCE may
> wait, and by being run on the unbound work queue, we permit the
> scheduler to make better scheduling decisions and not require pinning
> KFENCE to the same CPU upon waking up.
>
> Fixes: 36f0b35d0894 ("kfence: use power-efficient work queue to run delayed work")
> Reported-by: Hillf Danton <hdanton@sina.com>
> Signed-off-by: Marco Elver <elver@google.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
> ---
> mm/kfence/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 4d21ac44d5d3..d7666ace9d2e 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -636,7 +636,7 @@ static void toggle_allocation_gate(struct work_struct *work)
> /* Disable static key and reset timer. */
> static_branch_disable(&kfence_allocation_key);
> #endif
> - queue_delayed_work(system_power_efficient_wq, &kfence_timer,
> + queue_delayed_work(system_unbound_wq, &kfence_timer,
> msecs_to_jiffies(kfence_sample_interval));
> }
> static DECLARE_DELAYED_WORK(kfence_timer, toggle_allocation_gate);
> @@ -666,7 +666,7 @@ void __init kfence_init(void)
> }
>
> WRITE_ONCE(kfence_enabled, true);
> - queue_delayed_work(system_power_efficient_wq, &kfence_timer, 0);
> + queue_delayed_work(system_unbound_wq, &kfence_timer, 0);
> pr_info("initialized - using %lu bytes for %d objects at 0x%p-0x%p\n", KFENCE_POOL_SIZE,
> CONFIG_KFENCE_NUM_OBJECTS, (void *)__kfence_pool,
> (void *)(__kfence_pool + KFENCE_POOL_SIZE));
> --
> 2.31.1.818.g46aad6cb9e-goog
>
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kfence: unconditionally use unbound work queue
@ 2021-05-21 11:23 ` Alexander Potapenko
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Potapenko @ 2021-05-21 11:23 UTC (permalink / raw)
To: Marco Elver
Cc: Andrew Morton, Dmitriy Vyukov, LKML,
Linux Memory Management List, kasan-dev, Hillf Danton
On Fri, May 21, 2021 at 1:16 PM Marco Elver <elver@google.com> wrote:
>
> Unconditionally use unbound work queue, and not just if
> wq_power_efficient is true. Because if the system is idle, KFENCE may
> wait, and by being run on the unbound work queue, we permit the
> scheduler to make better scheduling decisions and not require pinning
> KFENCE to the same CPU upon waking up.
>
> Fixes: 36f0b35d0894 ("kfence: use power-efficient work queue to run delayed work")
> Reported-by: Hillf Danton <hdanton@sina.com>
> Signed-off-by: Marco Elver <elver@google.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
> ---
> mm/kfence/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 4d21ac44d5d3..d7666ace9d2e 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -636,7 +636,7 @@ static void toggle_allocation_gate(struct work_struct *work)
> /* Disable static key and reset timer. */
> static_branch_disable(&kfence_allocation_key);
> #endif
> - queue_delayed_work(system_power_efficient_wq, &kfence_timer,
> + queue_delayed_work(system_unbound_wq, &kfence_timer,
> msecs_to_jiffies(kfence_sample_interval));
> }
> static DECLARE_DELAYED_WORK(kfence_timer, toggle_allocation_gate);
> @@ -666,7 +666,7 @@ void __init kfence_init(void)
> }
>
> WRITE_ONCE(kfence_enabled, true);
> - queue_delayed_work(system_power_efficient_wq, &kfence_timer, 0);
> + queue_delayed_work(system_unbound_wq, &kfence_timer, 0);
> pr_info("initialized - using %lu bytes for %d objects at 0x%p-0x%p\n", KFENCE_POOL_SIZE,
> CONFIG_KFENCE_NUM_OBJECTS, (void *)__kfence_pool,
> (void *)(__kfence_pool + KFENCE_POOL_SIZE));
> --
> 2.31.1.818.g46aad6cb9e-goog
>
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-21 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 11:16 [PATCH] kfence: unconditionally use unbound work queue Marco Elver
2021-05-21 11:16 ` Marco Elver
2021-05-21 11:23 ` Alexander Potapenko
2021-05-21 11:23 ` Alexander Potapenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.