From: Alexander Potapenko <glider@google.com> To: Laurent Vivier <lvivier@redhat.com> Cc: LKML <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org, Dmitriy Vyukov <dvyukov@google.com>, rusty@rustcorp.com.au, amit@kernel.org, akong@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>, "Michael S . Tsirkin" <mst@redhat.com>, Matt Mackall <mpm@selenic.com>, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 0/4] hwrng: virtio - add an internal buffer Date: Wed, 22 Sep 2021 19:50:31 +0200 [thread overview] Message-ID: <CAG_fn=Xpek=e6drdCBQXUUvd5kAh-Ui7Xfjg6CY=MNpt0KHjqg@mail.gmail.com> (raw) In-Reply-To: <20210922170903.577801-1-lvivier@redhat.com> On Wed, Sep 22, 2021 at 7:09 PM Laurent Vivier <lvivier@redhat.com> wrote: > > hwrng core uses two buffers that can be mixed in the virtio-rng queue. > > This series fixes the problem by adding an internal buffer in virtio-rng. > > Once the internal buffer is added, we can fix two other problems: > > - to be able to release the driver without waiting the device releases the > buffer > > - actually returns some data when wait=0 as we can have some already > available data > > It also tries to improve the performance by always having a buffer in > the queue of the device. Tested-by: Alexander Potapenko <glider@google.com> for the series With these four patches applied, KMSAN stops reporting boot-time errors in _mix_pool_bytes reported here: https://www.spinics.net/lists/linux-virtualization/msg46310.html > Laurent Vivier (4): > hwrng: virtio - add an internal buffer > hwrng: virtio - don't wait on cleanup > hwrng: virtio - don't waste entropy > hwrng: virtio - always add a pending request > > drivers/char/hw_random/virtio-rng.c | 84 +++++++++++++++++++++-------- > 1 file changed, 63 insertions(+), 21 deletions(-) > > -- > 2.31.1 > > -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Potapenko via Virtualization <virtualization@lists.linux-foundation.org> To: Laurent Vivier <lvivier@redhat.com> Cc: Herbert Xu <herbert@gondor.apana.org.au>, amit@kernel.org, rusty@rustcorp.com.au, LKML <linux-kernel@vger.kernel.org>, virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" <mst@redhat.com>, linux-crypto@vger.kernel.org, Matt Mackall <mpm@selenic.com>, akong@redhat.com, Dmitriy Vyukov <dvyukov@google.com> Subject: Re: [PATCH 0/4] hwrng: virtio - add an internal buffer Date: Wed, 22 Sep 2021 19:50:31 +0200 [thread overview] Message-ID: <CAG_fn=Xpek=e6drdCBQXUUvd5kAh-Ui7Xfjg6CY=MNpt0KHjqg@mail.gmail.com> (raw) In-Reply-To: <20210922170903.577801-1-lvivier@redhat.com> On Wed, Sep 22, 2021 at 7:09 PM Laurent Vivier <lvivier@redhat.com> wrote: > > hwrng core uses two buffers that can be mixed in the virtio-rng queue. > > This series fixes the problem by adding an internal buffer in virtio-rng. > > Once the internal buffer is added, we can fix two other problems: > > - to be able to release the driver without waiting the device releases the > buffer > > - actually returns some data when wait=0 as we can have some already > available data > > It also tries to improve the performance by always having a buffer in > the queue of the device. Tested-by: Alexander Potapenko <glider@google.com> for the series With these four patches applied, KMSAN stops reporting boot-time errors in _mix_pool_bytes reported here: https://www.spinics.net/lists/linux-virtualization/msg46310.html > Laurent Vivier (4): > hwrng: virtio - add an internal buffer > hwrng: virtio - don't wait on cleanup > hwrng: virtio - don't waste entropy > hwrng: virtio - always add a pending request > > drivers/char/hw_random/virtio-rng.c | 84 +++++++++++++++++++++-------- > 1 file changed, 63 insertions(+), 21 deletions(-) > > -- > 2.31.1 > > -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-09-22 17:51 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 17:08 [PATCH 0/4] hwrng: virtio - add an internal buffer Laurent Vivier 2021-09-22 17:08 ` Laurent Vivier 2021-09-22 17:09 ` [PATCH 1/4] " Laurent Vivier 2021-09-22 17:09 ` Laurent Vivier 2021-09-22 19:02 ` Michael S. Tsirkin 2021-09-22 19:02 ` Michael S. Tsirkin 2021-09-23 6:26 ` Laurent Vivier 2021-09-23 6:26 ` Laurent Vivier 2021-09-23 7:04 ` Michael S. Tsirkin 2021-09-23 7:04 ` Michael S. Tsirkin 2021-09-23 7:34 ` Laurent Vivier 2021-09-23 7:34 ` Laurent Vivier 2021-10-05 11:55 ` Michael S. Tsirkin 2021-10-05 11:55 ` Michael S. Tsirkin 2021-10-05 13:30 ` Laurent Vivier 2021-10-05 13:30 ` Laurent Vivier 2021-09-22 17:09 ` [PATCH 2/4] hwrng: virtio - don't wait on cleanup Laurent Vivier 2021-09-22 17:09 ` Laurent Vivier 2021-09-22 17:09 ` [PATCH 3/4] hwrng: virtio - don't waste entropy Laurent Vivier 2021-09-22 17:09 ` Laurent Vivier 2021-09-22 17:09 ` [PATCH 4/4] hwrng: virtio - always add a pending request Laurent Vivier 2021-09-22 17:09 ` Laurent Vivier 2021-09-22 17:50 ` Alexander Potapenko [this message] 2021-09-22 17:50 ` [PATCH 0/4] hwrng: virtio - add an internal buffer Alexander Potapenko via Virtualization 2021-10-05 11:40 ` Laurent Vivier 2021-10-05 11:40 ` Laurent Vivier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAG_fn=Xpek=e6drdCBQXUUvd5kAh-Ui7Xfjg6CY=MNpt0KHjqg@mail.gmail.com' \ --to=glider@google.com \ --cc=akong@redhat.com \ --cc=amit@kernel.org \ --cc=dvyukov@google.com \ --cc=herbert@gondor.apana.org.au \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lvivier@redhat.com \ --cc=mpm@selenic.com \ --cc=mst@redhat.com \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.