From: Chen-Yu Tsai <wens@kernel.org> To: "Johan Jonker" <jbx6244@gmail.com>, "Heiko Stübner" <heiko@sntech.de> Cc: Chen-Yu Tsai <wens@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH 1/6] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers Date: Mon, 30 Mar 2020 00:36:37 +0800 [thread overview] Message-ID: <CAGb2v65ayZwN14S-Pzu2ip1K=fgzTbNB=ZzUcpou-jtv8m6vBA@mail.gmail.com> (raw) In-Reply-To: <684a08e6-7dfe-4cb1-2ae5-c1fb4128976b@gmail.com> On Fri, Mar 27, 2020 at 5:58 PM Johan Jonker <jbx6244@gmail.com> wrote: > > Hi Chen-Yu Tsai, > > The led node names need some changes. > 'linux,default-trigger' value does not fit. > > From leds-gpio.yaml: > > patternProperties: > # The first form is preferred, but fall back to just 'led' anywhere in the > # node name to at least catch some child nodes. > "(^led-[0-9a-f]$|led)": > type: object > > Rename led nodenames to 'led-0' form > > Also include all mail lists found with: > ./scripts/get_maintainer.pl --nogit-fallback --nogit > > devicetree@vger.kernel.org Oops... > If you like change the rest of dts with leds as well... > > DTC arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml > CHECK arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml: leds: > yellow-led:linux,default-trigger:0: 'mmc0' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml: leds: > diy-led:linux,default-trigger:0: 'mmc1' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > DTC arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml > CHECK arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml: leds: > diy-led:linux,default-trigger:0: 'mmc2' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml: leds: > yellow-led:linux,default-trigger:0: 'mmc1' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] Maybe we should just get rid of linux,default-trigger then? Heiko? ChenYu > make -k ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml > > > From: Chen-Yu Tsai <wens@csie.org> > > > > With SDIO now enabled, the numbering of the existing MMC host controllers > > gets incremented by 1, as the SDIO host is the first one. > > > > Increment the numbering of the MMC LED triggers to match. > > > > Fixes: cf3c5397835f ("arm64: dts: rockchip: Enable sdio0 and uart0 on rk3399-roc-pc-mezzanine") > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts | 8 ++++++++ > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 4 ++-- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > index 2acb3d500fb9..f0686fc276be 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > @@ -38,6 +38,10 @@ vcc3v3_pcie: vcc3v3-pcie { > > }; > > }; > > > > +&diy_led { > > + linux,default-trigger = "mmc2"; > > +}; > > + > > &pcie_phy { > > status = "okay"; > > }; > > @@ -91,3 +95,7 @@ &uart0 { > > pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; > > status = "okay"; > > }; > > + > > +&yellow_led { > > + linux,default-trigger = "mmc1"; > > +}; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > index 9f225e9c3d54..bc060ac7972d 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > @@ -70,14 +70,14 @@ work-led { > > linux,default-trigger = "heartbeat"; > > }; > > > > - diy-led { > > + diy_led: diy-led { > > label = "red:diy"; > > gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; > > default-state = "off"; > > linux,default-trigger = "mmc1"; > > }; > > > > - yellow-led { > > + yellow_led: yellow-led { > > label = "yellow:yellow-led"; > > gpios = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>; > > default-state = "off"; > > -- > > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org> To: "Johan Jonker" <jbx6244@gmail.com>, "Heiko Stübner" <heiko@sntech.de> Cc: Rob Herring <robh+dt@kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Chen-Yu Tsai <wens@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 1/6] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers Date: Mon, 30 Mar 2020 00:36:37 +0800 [thread overview] Message-ID: <CAGb2v65ayZwN14S-Pzu2ip1K=fgzTbNB=ZzUcpou-jtv8m6vBA@mail.gmail.com> (raw) In-Reply-To: <684a08e6-7dfe-4cb1-2ae5-c1fb4128976b@gmail.com> On Fri, Mar 27, 2020 at 5:58 PM Johan Jonker <jbx6244@gmail.com> wrote: > > Hi Chen-Yu Tsai, > > The led node names need some changes. > 'linux,default-trigger' value does not fit. > > From leds-gpio.yaml: > > patternProperties: > # The first form is preferred, but fall back to just 'led' anywhere in the > # node name to at least catch some child nodes. > "(^led-[0-9a-f]$|led)": > type: object > > Rename led nodenames to 'led-0' form > > Also include all mail lists found with: > ./scripts/get_maintainer.pl --nogit-fallback --nogit > > devicetree@vger.kernel.org Oops... > If you like change the rest of dts with leds as well... > > DTC arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml > CHECK arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml: leds: > yellow-led:linux,default-trigger:0: 'mmc0' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml: leds: > diy-led:linux,default-trigger:0: 'mmc1' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > DTC arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml > CHECK arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml: leds: > diy-led:linux,default-trigger:0: 'mmc2' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml: leds: > yellow-led:linux,default-trigger:0: 'mmc1' is not one of ['backlight', > 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] Maybe we should just get rid of linux,default-trigger then? Heiko? ChenYu > make -k ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml > > > From: Chen-Yu Tsai <wens@csie.org> > > > > With SDIO now enabled, the numbering of the existing MMC host controllers > > gets incremented by 1, as the SDIO host is the first one. > > > > Increment the numbering of the MMC LED triggers to match. > > > > Fixes: cf3c5397835f ("arm64: dts: rockchip: Enable sdio0 and uart0 on rk3399-roc-pc-mezzanine") > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts | 8 ++++++++ > > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 4 ++-- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > index 2acb3d500fb9..f0686fc276be 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts > > @@ -38,6 +38,10 @@ vcc3v3_pcie: vcc3v3-pcie { > > }; > > }; > > > > +&diy_led { > > + linux,default-trigger = "mmc2"; > > +}; > > + > > &pcie_phy { > > status = "okay"; > > }; > > @@ -91,3 +95,7 @@ &uart0 { > > pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; > > status = "okay"; > > }; > > + > > +&yellow_led { > > + linux,default-trigger = "mmc1"; > > +}; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > index 9f225e9c3d54..bc060ac7972d 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > > @@ -70,14 +70,14 @@ work-led { > > linux,default-trigger = "heartbeat"; > > }; > > > > - diy-led { > > + diy_led: diy-led { > > label = "red:diy"; > > gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; > > default-state = "off"; > > linux,default-trigger = "mmc1"; > > }; > > > > - yellow-led { > > + yellow_led: yellow-led { > > label = "yellow:yellow-led"; > > gpios = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>; > > default-state = "off"; > > -- > > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-29 16:36 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 3:04 [PATCH 0/6] arm64: dts: rockchip: misc. cleanups Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 3:04 ` [PATCH 1/6] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 9:58 ` Johan Jonker 2020-03-27 9:58 ` Johan Jonker 2020-03-29 16:36 ` Chen-Yu Tsai [this message] 2020-03-29 16:36 ` Chen-Yu Tsai 2020-03-31 11:07 ` Robin Murphy 2020-03-31 11:07 ` Robin Murphy 2020-03-31 11:07 ` Robin Murphy 2020-04-01 20:05 ` Jacek Anaszewski 2020-04-01 20:05 ` Jacek Anaszewski 2020-04-01 20:05 ` Jacek Anaszewski 2020-04-06 9:13 ` Pavel Machek 2020-04-06 9:13 ` Pavel Machek 2020-04-13 5:33 ` Chen-Yu Tsai 2020-04-13 5:33 ` Chen-Yu Tsai 2020-04-13 5:33 ` Chen-Yu Tsai 2020-03-27 3:04 ` [PATCH 2/6] arm64: dts: rockchip: rk3328: Replace RK805 PMIC node name with "pmic" Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 12:12 ` Johan Jonker 2020-03-27 12:12 ` Johan Jonker 2020-03-27 12:15 ` Chen-Yu Tsai 2020-03-27 12:15 ` Chen-Yu Tsai 2020-03-27 3:04 ` [PATCH 3/6] arm64: dts: rockchip: rk3328: drop non-existent gmac2phy pinmux options Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 3:04 ` [PATCH 4/6] arm64: dts: rockchip: rk3328: drop #address-cells, #size-cells from grf node Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 3:04 ` [PATCH 5/6] arm64: dts: rockchip: rk3399: drop #address-cells, #size-cells from pmugrf node Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-03-27 3:04 ` [PATCH 6/6] arm64: dts: rockchip: rk3399: Rename dwc3 device nodes to make dtc happy Chen-Yu Tsai 2020-03-27 3:04 ` Chen-Yu Tsai 2020-04-19 11:36 ` [PATCH 0/6] arm64: dts: rockchip: misc. cleanups Heiko Stuebner 2020-04-19 11:36 ` Heiko Stuebner 2020-04-19 11:36 ` Heiko Stuebner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGb2v65ayZwN14S-Pzu2ip1K=fgzTbNB=ZzUcpou-jtv8m6vBA@mail.gmail.com' \ --to=wens@kernel.org \ --cc=heiko@sntech.de \ --cc=jbx6244@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.