* [PATCH] ARM: sunxi: add an help section to the Kconfig Sun8i SoC selection
@ 2017-08-08 15:36 ` Corentin Labbe
0 siblings, 0 replies; 4+ messages in thread
From: Corentin Labbe @ 2017-08-08 15:36 UTC (permalink / raw)
To: maxime.ripard, wens, linux; +Cc: linux-arm-kernel, linux-kernel, Corentin Labbe
Since sun8i regroup lots of SoCs, it is helpful to list them in the help
section of Kconfig.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
arch/arm/mach-sunxi/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index 58153cdf025b..2ffcccda2688 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -42,6 +42,9 @@ config MACH_SUN8I
default ARCH_SUNXI
select ARM_GIC
select MFD_SUN6I_PRCM
+ help
+ Select this option if you have one of the following SoC:
+ A23 A33 A83T H2+ H3 R16 V3S
config MACH_SUN9I
bool "Allwinner (sun9i) SoCs support"
--
2.13.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: sunxi: add an help section to the Kconfig Sun8i SoC selection
@ 2017-08-08 15:36 ` Corentin Labbe
0 siblings, 0 replies; 4+ messages in thread
From: Corentin Labbe @ 2017-08-08 15:36 UTC (permalink / raw)
To: linux-arm-kernel
Since sun8i regroup lots of SoCs, it is helpful to list them in the help
section of Kconfig.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
arch/arm/mach-sunxi/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index 58153cdf025b..2ffcccda2688 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -42,6 +42,9 @@ config MACH_SUN8I
default ARCH_SUNXI
select ARM_GIC
select MFD_SUN6I_PRCM
+ help
+ Select this option if you have one of the following SoC:
+ A23 A33 A83T H2+ H3 R16 V3S
config MACH_SUN9I
bool "Allwinner (sun9i) SoCs support"
--
2.13.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: sunxi: add an help section to the Kconfig Sun8i SoC selection
2017-08-08 15:36 ` Corentin Labbe
@ 2017-08-08 15:44 ` Chen-Yu Tsai
-1 siblings, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2017-08-08 15:44 UTC (permalink / raw)
To: Corentin Labbe
Cc: Maxime Ripard, Chen-Yu Tsai, Russell King, linux-arm-kernel,
linux-kernel
Hi,
On Tue, Aug 8, 2017 at 11:36 PM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> Since sun8i regroup lots of SoCs, it is helpful to list them in the help
> section of Kconfig.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/mach-sunxi/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 58153cdf025b..2ffcccda2688 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -42,6 +42,9 @@ config MACH_SUN8I
> default ARCH_SUNXI
> select ARM_GIC
> select MFD_SUN6I_PRCM
> + help
> + Select this option if you have one of the following SoC:
> + A23 A33 A83T H2+ H3 R16 V3S
IIRC Maxime was against having chip names in here, as we would end up
updating this every time a new chip gets added.
Instead, what about using Allwinner's explanation? I.e. sun8i is a
chip with only Cortex-A7's, and sun9i is a chip with Cortex-A15's.
And just tell the user to say yes if they are not sure.
ChenYu
>
> config MACH_SUN9I
> bool "Allwinner (sun9i) SoCs support"
> --
> 2.13.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: sunxi: add an help section to the Kconfig Sun8i SoC selection
@ 2017-08-08 15:44 ` Chen-Yu Tsai
0 siblings, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2017-08-08 15:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Aug 8, 2017 at 11:36 PM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> Since sun8i regroup lots of SoCs, it is helpful to list them in the help
> section of Kconfig.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/mach-sunxi/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 58153cdf025b..2ffcccda2688 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -42,6 +42,9 @@ config MACH_SUN8I
> default ARCH_SUNXI
> select ARM_GIC
> select MFD_SUN6I_PRCM
> + help
> + Select this option if you have one of the following SoC:
> + A23 A33 A83T H2+ H3 R16 V3S
IIRC Maxime was against having chip names in here, as we would end up
updating this every time a new chip gets added.
Instead, what about using Allwinner's explanation? I.e. sun8i is a
chip with only Cortex-A7's, and sun9i is a chip with Cortex-A15's.
And just tell the user to say yes if they are not sure.
ChenYu
>
> config MACH_SUN9I
> bool "Allwinner (sun9i) SoCs support"
> --
> 2.13.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-08 15:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 15:36 [PATCH] ARM: sunxi: add an help section to the Kconfig Sun8i SoC selection Corentin Labbe
2017-08-08 15:36 ` Corentin Labbe
2017-08-08 15:44 ` Chen-Yu Tsai
2017-08-08 15:44 ` Chen-Yu Tsai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.