From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/3] dmaengine: sun6i: Add support for Allwinner A23 (sun8i) variant
Date: Thu, 18 Sep 2014 09:57:42 +0800 [thread overview]
Message-ID: <CAGb2v65p4QPJY+eiLps6C2kAZjhPd99D5YYauwUjLJnnj54B1A@mail.gmail.com> (raw)
In-Reply-To: <20140917155540.GJ2166@lukather>
On Wed, Sep 17, 2014 at 11:55 PM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Tue, Sep 16, 2014 at 10:13:27PM +0800, Chen-Yu Tsai wrote:
>> >> + /*
>> >> + * sun8i variant requires us to toggle an undocumented register,
>> >> + * as seen in Allwinner's SDK.
>> >
>> > The BSP I have has this:
>> >
>> > static void sunxi_dma_hw_init(struct sunxi_dmadev *dev)
>> > {
>> > struct sunxi_dmadev *sunxi_dev = dev;
>> >
>> > clk_prepare_enable(sunxi_dev->ahb_clk);
>> > #ifdef CONFIG_ARCH_SUN8IW3
>> > writel(0x04, sunxi_dev->base + DMA_GATE);
>> > #endif
>> > }
>> >
>> > /* All is ok, and open the clock */
>> > sunxi_dma_hw_init(sunxi_dev);
>> >
>> > So I guess we can say that it's not that undocumented :)
>>
>> That's right. I meant undocumented in the user manual.
>> I did reference the SDK in the comment, didn't I? :)
>
> So something like
>
> writel(DMA_GATE_ENABLE, base->DMA_GATE_REG) wouldn't be too far off :)
Sure. Will also update the comment to reflect the naming.
ChenYu
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dmaengine: sun6i: Add support for Allwinner A23 (sun8i) variant
Date: Thu, 18 Sep 2014 09:57:42 +0800 [thread overview]
Message-ID: <CAGb2v65p4QPJY+eiLps6C2kAZjhPd99D5YYauwUjLJnnj54B1A@mail.gmail.com> (raw)
In-Reply-To: <20140917155540.GJ2166@lukather>
On Wed, Sep 17, 2014 at 11:55 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Sep 16, 2014 at 10:13:27PM +0800, Chen-Yu Tsai wrote:
>> >> + /*
>> >> + * sun8i variant requires us to toggle an undocumented register,
>> >> + * as seen in Allwinner's SDK.
>> >
>> > The BSP I have has this:
>> >
>> > static void sunxi_dma_hw_init(struct sunxi_dmadev *dev)
>> > {
>> > struct sunxi_dmadev *sunxi_dev = dev;
>> >
>> > clk_prepare_enable(sunxi_dev->ahb_clk);
>> > #ifdef CONFIG_ARCH_SUN8IW3
>> > writel(0x04, sunxi_dev->base + DMA_GATE);
>> > #endif
>> > }
>> >
>> > /* All is ok, and open the clock */
>> > sunxi_dma_hw_init(sunxi_dev);
>> >
>> > So I guess we can say that it's not that undocumented :)
>>
>> That's right. I meant undocumented in the user manual.
>> I did reference the SDK in the comment, didn't I? :)
>
> So something like
>
> writel(DMA_GATE_ENABLE, base->DMA_GATE_REG) wouldn't be too far off :)
Sure. Will also update the comment to reflect the naming.
ChenYu
next prev parent reply other threads:[~2014-09-18 1:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 13:52 [PATCH 0/3] ARM: sun8i: Add DMA controller support Chen-Yu Tsai
2014-09-13 13:52 ` Chen-Yu Tsai
[not found] ` <1410616381-30226-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-09-13 13:52 ` [PATCH 1/3] dmaengine: sun6i: support parameterized compatible strings Chen-Yu Tsai
2014-09-13 13:52 ` Chen-Yu Tsai
[not found] ` <1410616381-30226-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-09-16 10:33 ` Maxime Ripard
2014-09-16 10:33 ` Maxime Ripard
2014-09-13 13:53 ` [PATCH 2/3] dmaengine: sun6i: Add support for Allwinner A23 (sun8i) variant Chen-Yu Tsai
2014-09-13 13:53 ` Chen-Yu Tsai
[not found] ` <1410616381-30226-3-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-09-16 10:35 ` Maxime Ripard
2014-09-16 10:35 ` Maxime Ripard
2014-09-16 14:13 ` Chen-Yu Tsai
2014-09-16 14:13 ` Chen-Yu Tsai
[not found] ` <CAGb2v67jokpXHxR26YoCEB2Y_v07oQZXZfPuGJC_wO=r-SRZhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-17 15:55 ` Maxime Ripard
2014-09-17 15:55 ` Maxime Ripard
2014-09-18 1:57 ` Chen-Yu Tsai [this message]
2014-09-18 1:57 ` Chen-Yu Tsai
2014-09-13 13:53 ` [PATCH 3/3] ARM: dts: sun8i: Add DMA controller node Chen-Yu Tsai
2014-09-13 13:53 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v65p4QPJY+eiLps6C2kAZjhPd99D5YYauwUjLJnnj54B1A@mail.gmail.com \
--to=wens-jday2fn1rrm@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.