All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Akash Gajjar <Akash_Gajjar@mentor.com>
Cc: Icenowy Zheng <icenowy@aosc.io>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: allwinner: a64: add csi regulator to sopine dts
Date: Tue, 7 Aug 2018 10:52:20 +0800	[thread overview]
Message-ID: <CAGb2v66GoZJ4nXs7S0F3JXJ3Jm0ZBRXy0r2e4STqVPV5S0UVUQ@mail.gmail.com> (raw)
In-Reply-To: <1533109399-21174-1-git-send-email-Akash_Gajjar@mentor.com>

On Wed, Aug 1, 2018 at 3:43 PM, Akash Gajjar <Akash_Gajjar@mentor.com> wrote:
> sopine board has a csi. enable supply dvdd-1v8-csi, dovdd-2v8-csi and
> avdd-2v8-csi on board to access external camera connected to it.

Unless there are other uses beyond supplying the camera module, this is not
going to be accepted. Enabling power to the camera should be in the same
patch as enabling the camera itself. And since it is a module, it should
be an overlay file.


ChenYu


> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> ---
>  .../arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> index 43418bd..256229b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> @@ -68,6 +68,13 @@
>
>  #include "axp803.dtsi"
>
> +&reg_aldo1 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <2800000>;
> +       regulator-max-microvolt = <2800000>;
> +       regulator-name = "dovdd-csi";
> +};
> +
>  &reg_aldo2 {
>         regulator-always-on;
>         regulator-min-microvolt = <1800000>;
> @@ -112,6 +119,13 @@
>         regulator-name = "vdd-sys";
>  };
>
> +&reg_dldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <2800000>;
> +       regulator-max-microvolt = <2800000>;
> +       regulator-name = "avdd-csi";
> +};
> +
>  &reg_eldo1 {
>         regulator-always-on;
>         regulator-min-microvolt = <1800000>;
> @@ -119,6 +133,13 @@
>         regulator-name = "vdd-1v8-lpddr";
>  };
>
> +&reg_eldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1800000>;
> +       regulator-max-microvolt = <1800000>;
> +       regulator-name = "vdd-csi";
> +};
> +
>  &reg_fldo1 {
>         regulator-min-microvolt = <1200000>;
>         regulator-max-microvolt = <1200000>;
> --
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: allwinner: a64: add csi regulator to sopine dts
Date: Tue, 7 Aug 2018 10:52:20 +0800	[thread overview]
Message-ID: <CAGb2v66GoZJ4nXs7S0F3JXJ3Jm0ZBRXy0r2e4STqVPV5S0UVUQ@mail.gmail.com> (raw)
In-Reply-To: <1533109399-21174-1-git-send-email-Akash_Gajjar@mentor.com>

On Wed, Aug 1, 2018 at 3:43 PM, Akash Gajjar <Akash_Gajjar@mentor.com> wrote:
> sopine board has a csi. enable supply dvdd-1v8-csi, dovdd-2v8-csi and
> avdd-2v8-csi on board to access external camera connected to it.

Unless there are other uses beyond supplying the camera module, this is not
going to be accepted. Enabling power to the camera should be in the same
patch as enabling the camera itself. And since it is a module, it should
be an overlay file.


ChenYu


> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> ---
>  .../arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> index 43418bd..256229b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> @@ -68,6 +68,13 @@
>
>  #include "axp803.dtsi"
>
> +&reg_aldo1 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <2800000>;
> +       regulator-max-microvolt = <2800000>;
> +       regulator-name = "dovdd-csi";
> +};
> +
>  &reg_aldo2 {
>         regulator-always-on;
>         regulator-min-microvolt = <1800000>;
> @@ -112,6 +119,13 @@
>         regulator-name = "vdd-sys";
>  };
>
> +&reg_dldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <2800000>;
> +       regulator-max-microvolt = <2800000>;
> +       regulator-name = "avdd-csi";
> +};
> +
>  &reg_eldo1 {
>         regulator-always-on;
>         regulator-min-microvolt = <1800000>;
> @@ -119,6 +133,13 @@
>         regulator-name = "vdd-1v8-lpddr";
>  };
>
> +&reg_eldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1800000>;
> +       regulator-max-microvolt = <1800000>;
> +       regulator-name = "vdd-csi";
> +};
> +
>  &reg_fldo1 {
>         regulator-min-microvolt = <1200000>;
>         regulator-max-microvolt = <1200000>;
> --
> 2.7.4
>

  reply	other threads:[~2018-08-07  2:52 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  7:43 [PATCH] arm64: dts: allwinner: a64: add csi regulator to sopine dts Akash Gajjar
2018-08-01  7:43 ` Akash Gajjar
2018-08-01  7:43 ` Akash Gajjar
2018-08-07  2:52 ` Chen-Yu Tsai [this message]
2018-08-07  2:52   ` Chen-Yu Tsai
  -- strict thread matches above, loose matches on Subject: below --
2018-09-26  6:24 [PATCH v3] arm64: dts: rockchip: add initial dts support for Rockpro64 Akash Gajjar
2018-09-26  6:24 ` Akash Gajjar
2018-09-26  6:24 ` Akash Gajjar
2018-09-26  9:44 ` Deepak Das
2018-09-26  9:44   ` Deepak Das
2018-09-26  9:44   ` Deepak Das
2018-09-26 11:35 ` Heiko Stuebner
2018-09-26 11:35   ` Heiko Stuebner
2018-09-27 20:02 ` Rob Herring
2018-09-27 20:02   ` Rob Herring
2018-09-19 14:45 [PATCH] arm64: dts: rockchip: update pinmux setting in rk3399.dtsi Akash Gajjar
2018-09-19 14:45 ` Akash Gajjar
2018-09-19 14:45 ` Akash Gajjar
2018-09-24 12:58 ` Heiko Stuebner
2018-09-24 12:58   ` Heiko Stuebner
2018-09-19 14:43 [PATCH] arm64: dts: rockchip: add initial dts support for Rockpro64 board Akash Gajjar
2018-09-19 14:43 ` Akash Gajjar
2018-09-19 14:43 ` Akash Gajjar
2018-09-20  6:25 ` Deepak Das
2018-09-20  6:25   ` Deepak Das
2018-09-20  6:25   ` Deepak Das
2018-09-24 13:05 ` Heiko Stuebner
2018-09-24 13:05   ` Heiko Stuebner
2018-09-25 11:24 ` Rob Herring
2018-09-25 11:24   ` Rob Herring
2018-09-14 12:09 Akash Gajjar
2018-09-14 12:09 ` Akash Gajjar
2018-09-14 12:09 ` Akash Gajjar
2018-09-14 17:53 ` Heiko Stuebner
2018-09-14 17:53   ` Heiko Stuebner
2018-09-15  9:03   ` agajjar
2018-09-15  9:03     ` agajjar
2018-09-15  9:03     ` agajjar
2018-09-15 18:47     ` Heiko Stuebner
2018-09-15 18:47       ` Heiko Stuebner
2018-09-17  5:44 ` Rob Herring
2018-09-17  5:44   ` Rob Herring
2018-07-26  6:51 [PATCH] arm64: dts: allwinner: activate spi flash on pine64 LTS board Akash Gajjar
2018-07-26  6:51 ` Akash Gajjar
2018-07-26  6:51 ` Akash Gajjar
2018-07-26  7:29 ` Maxime Ripard
2018-07-26  7:29   ` Maxime Ripard
2018-07-26  7:31   ` Maxime Ripard
2018-07-26  7:31     ` Maxime Ripard
2018-07-26  8:00     ` Emmanuel Vadot
2018-07-26  8:00       ` Emmanuel Vadot
2018-07-22 15:46 [PATCH] arm64: " Akash Gajjar
2018-07-22 15:46 ` Akash Gajjar
2018-07-24 12:51 ` Maxime Ripard
2018-07-24 12:51   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v66GoZJ4nXs7S0F3JXJ3Jm0ZBRXy0r2e4STqVPV5S0UVUQ@mail.gmail.com \
    --to=wens@csie.org \
    --cc=Akash_Gajjar@mentor.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.