All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: oskari@lemmela.net
Cc: Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Lee Jones <lee.jones@linaro.org>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/7] mfd: axp20x: Add supported cells for AXP803
Date: Tue, 16 Oct 2018 12:17:37 +0800	[thread overview]
Message-ID: <CAGb2v66aJUYOkZL=b5TfnvLsbLk_mU8AQtR3BSBRM-49rh2yOA@mail.gmail.com> (raw)
In-Reply-To: <20181013080848.29894-8-oskari@lemmela.net>

On Sat, Oct 13, 2018 at 4:09 PM Oskari Lemmela <oskari@lemmela.net> wrote:
>
> AXP803 is compatible with AXP813.
> Adding cells for GPIO, ADC, AC and battery power supplies.

They are not _completely_ compatible. A better way to phrase this would be:

Parts of the AXP803 are compatible with their counterparts on the AXP813.
These include the GPIO, ADC, AC and battery power supplies.

> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>

Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@csie.org>

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] mfd: axp20x: Add supported cells for AXP803
Date: Tue, 16 Oct 2018 12:17:37 +0800	[thread overview]
Message-ID: <CAGb2v66aJUYOkZL=b5TfnvLsbLk_mU8AQtR3BSBRM-49rh2yOA@mail.gmail.com> (raw)
In-Reply-To: <20181013080848.29894-8-oskari@lemmela.net>

On Sat, Oct 13, 2018 at 4:09 PM Oskari Lemmela <oskari@lemmela.net> wrote:
>
> AXP803 is compatible with AXP813.
> Adding cells for GPIO, ADC, AC and battery power supplies.

They are not _completely_ compatible. A better way to phrase this would be:

Parts of the AXP803 are compatible with their counterparts on the AXP813.
These include the GPIO, ADC, AC and battery power supplies.

> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>

Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@csie.org>

  reply	other threads:[~2018-10-16  4:17 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13  8:08 [PATCH v4 0/7] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-10-13  8:08 ` Oskari Lemmela
2018-10-13  8:08 ` [PATCH v4 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-16  4:08   ` Chen-Yu Tsai
2018-10-16  4:08     ` Chen-Yu Tsai
2018-10-21 21:15   ` Sebastian Reichel
2018-10-21 21:15     ` Sebastian Reichel
2018-10-13  8:08 ` [PATCH v4 2/7] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-16  4:08   ` Chen-Yu Tsai
2018-10-16  4:08     ` Chen-Yu Tsai
2018-10-13  8:08 ` [PATCH v4 3/7] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-16  4:11   ` Chen-Yu Tsai
2018-10-16  4:11     ` Chen-Yu Tsai
2018-10-13  8:08 ` [PATCH v4 4/7] arm64: dts: allwinner: a64: sopine: enable " Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-16  4:14   ` Chen-Yu Tsai
2018-10-16  4:14     ` Chen-Yu Tsai
2018-10-13  8:08 ` [PATCH v4 5/7] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-17  6:12   ` Chen-Yu Tsai
2018-10-17  6:12     ` Chen-Yu Tsai
2018-10-21 21:16   ` Sebastian Reichel
2018-10-21 21:16     ` Sebastian Reichel
2018-10-13  8:08 ` [PATCH v4 6/7] mfd: axp20x: Add AC power supply cell " Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-16  4:15   ` Chen-Yu Tsai
2018-10-16  4:15     ` Chen-Yu Tsai
2018-10-16  4:15     ` Chen-Yu Tsai
2018-10-13  8:08 ` [PATCH v4 7/7] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-10-13  8:08   ` Oskari Lemmela
2018-10-16  4:17   ` Chen-Yu Tsai [this message]
2018-10-16  4:17     ` Chen-Yu Tsai
2018-10-18  6:04 ` [PATCH v4 0/7] AXP8x3 AC and battery power supply support Vasily Khoruzhick
2018-10-18  6:04   ` Vasily Khoruzhick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v66aJUYOkZL=b5TfnvLsbLk_mU8AQtR3BSBRM-49rh2yOA@mail.gmail.com' \
    --to=wens@csie.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=oskari@lemmela.net \
    --cc=quentin.schulz@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.