From: Chen-Yu Tsai <wens@csie.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH v5 05/20] ASoC: sun4i-i2s: Set sign extend sample
Date: Mon, 28 Sep 2020 14:52:05 +0800 [thread overview]
Message-ID: <CAGb2v66vJpCUc3xAHt7sHXKguc7ma+0kSjX=5Wp5VTdHeYQa5Q@mail.gmail.com> (raw)
In-Reply-To: <20200927192912.46323-6-peron.clem@gmail.com>
On Mon, Sep 28, 2020 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
>
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
>
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
>
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep consistency and avoid relying on
> default.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@csie.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Marcus Cooper <codekipper@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH v5 05/20] ASoC: sun4i-i2s: Set sign extend sample
Date: Mon, 28 Sep 2020 14:52:05 +0800 [thread overview]
Message-ID: <CAGb2v66vJpCUc3xAHt7sHXKguc7ma+0kSjX=5Wp5VTdHeYQa5Q@mail.gmail.com> (raw)
In-Reply-To: <20200927192912.46323-6-peron.clem@gmail.com>
On Mon, Sep 28, 2020 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
>
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
>
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
>
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep consistency and avoid relying on
> default.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@csie.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Marcus Cooper <codekipper@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH v5 05/20] ASoC: sun4i-i2s: Set sign extend sample
Date: Mon, 28 Sep 2020 14:52:05 +0800 [thread overview]
Message-ID: <CAGb2v66vJpCUc3xAHt7sHXKguc7ma+0kSjX=5Wp5VTdHeYQa5Q@mail.gmail.com> (raw)
In-Reply-To: <20200927192912.46323-6-peron.clem@gmail.com>
On Mon, Sep 28, 2020 at 3:29 AM Clément Péron <peron.clem@gmail.com> wrote:
>
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
>
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
>
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep consistency and avoid relying on
> default.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-28 6:52 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 19:28 [PATCH v5 00/20] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` [PATCH v5 01/20] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 4:40 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 4:40 ` Chen-Yu Tsai
2020-09-28 4:40 ` Chen-Yu Tsai
2020-09-28 14:37 ` Clément Péron
2020-09-28 14:37 ` Clément Péron
2020-09-28 14:37 ` Clément Péron
2020-09-28 14:46 ` Chen-Yu Tsai
2020-09-28 14:46 ` Chen-Yu Tsai
2020-09-28 14:46 ` Chen-Yu Tsai
2020-09-27 19:28 ` [PATCH v5 02/20] ASoC: sun4i-i2s: Change set_chan_cfg() params Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 5:00 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 5:00 ` Chen-Yu Tsai
2020-09-28 5:00 ` Chen-Yu Tsai
2020-09-28 14:48 ` Clément Péron
2020-09-28 14:48 ` Clément Péron
2020-09-28 14:48 ` Clément Péron
2020-09-27 19:28 ` [PATCH v5 03/20] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 4:37 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 4:37 ` Chen-Yu Tsai
2020-09-28 4:37 ` Chen-Yu Tsai
2020-09-28 5:02 ` Chen-Yu Tsai
2020-09-28 5:02 ` Chen-Yu Tsai
2020-09-28 5:02 ` Chen-Yu Tsai
2020-09-27 19:28 ` [PATCH v5 04/20] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 5:03 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 5:03 ` Chen-Yu Tsai
2020-09-28 5:03 ` Chen-Yu Tsai
2020-09-27 19:28 ` [PATCH v5 05/20] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 6:52 ` Chen-Yu Tsai [this message]
2020-09-28 6:52 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 6:52 ` Chen-Yu Tsai
2020-09-27 19:28 ` [PATCH v5 06/20] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 6:51 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 6:51 ` Chen-Yu Tsai
2020-09-28 6:51 ` Chen-Yu Tsai
2020-09-27 19:28 ` [PATCH v5 07/20] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-27 19:28 ` Clément Péron
2020-09-28 6:49 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 6:49 ` Chen-Yu Tsai
2020-09-28 6:49 ` Chen-Yu Tsai
2020-09-27 19:29 ` [PATCH v5 08/20] ASoC: sun4i-i2s: Fix setting of FIFO modes Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-28 6:51 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 6:51 ` Chen-Yu Tsai
2020-09-28 6:51 ` Chen-Yu Tsai
2020-09-27 19:29 ` [PATCH v5 09/20] arm64: dts: allwinner: h6: Add DAI node and soundcard for HDMI Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-28 5:32 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 5:32 ` Chen-Yu Tsai
2020-09-28 5:32 ` Chen-Yu Tsai
2020-09-28 5:42 ` Chen-Yu Tsai
2020-09-28 5:42 ` Chen-Yu Tsai
2020-09-28 5:42 ` Chen-Yu Tsai
2020-10-02 16:01 ` Clément Péron
2020-10-02 16:01 ` Clément Péron
2020-10-02 16:01 ` Clément Péron
2020-10-02 16:24 ` Maxime Ripard
2020-10-02 16:24 ` Maxime Ripard
2020-10-02 16:24 ` Maxime Ripard
2020-10-03 9:32 ` Clément Péron
2020-10-03 9:32 ` Clément Péron
2020-10-03 9:32 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 10/20] arm64: dts: allwinner: h6: Enable HDMI sound for Beelink GS1 Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-28 5:32 ` [linux-sunxi] " Chen-Yu Tsai
2020-09-28 5:32 ` Chen-Yu Tsai
2020-09-28 5:32 ` Chen-Yu Tsai
2020-09-27 19:29 ` [PATCH v5 11/20] arm: dts: sunxi: h3/h5: Add DAI node and soundcard for HDMI Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 12/20] arm64: dts: allwinner: a64: " Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 13/20] arm: sun8i: h3: Add HDMI audio to Orange Pi 2 Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 14/20] arm: sun8i: h3: Add HDMI audio to Beelink X2 Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 15/20] arm64: dts: allwinner: a64: Add HDMI audio to Pine64 Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 16/20] arm64: dts: allwinner: Enable HDMI audio on Orange Pi PC 2 Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 17/20] ARM: dts: sun8i-h3: Enable HDMI audio on Orange Pi PC/One Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 18/20] arm64: dts: sun50i-h6-orangepi-3: Enable HDMI audio Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 19/20] arm64: defconfig: Enable Allwinner i2s driver Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` [PATCH v5 20/20] ASoC: sun4i-i2s: fix coding-style for callback definition Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-27 19:29 ` Clément Péron
2020-09-28 6:52 ` [linux-sunxi] [PATCH v5 00/20] Add Allwinner H3/H5/H6/A64 HDMI audio Chen-Yu Tsai
2020-09-28 6:52 ` Chen-Yu Tsai
2020-09-28 6:52 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66vJpCUc3xAHt7sHXKguc7ma+0kSjX=5Wp5VTdHeYQa5Q@mail.gmail.com' \
--to=wens@csie.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.