All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet
Date: Tue, 22 Dec 2015 12:29:24 +0800	[thread overview]
Message-ID: <CAGb2v67+XpYwUFAVSGEGAfJ0bzubQ87Ebaf5W5Ze619mEE6uUA@mail.gmail.com> (raw)
In-Reply-To: <567854D5.7030601-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Tue, Dec 22, 2015 at 3:36 AM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Hi,
>
> On 21-12-15 17:11, Maxime Ripard wrote:
>>
>> Hi,x
>>
>> On Mon, Dec 21, 2015 at 11:46:18AM +0100, Hans de Goede wrote:
>>>>
>>>> On the side, any thoughts on how to handle the differences between
>>>> various "Q8"
>>>> tablets, like different I2C-based sensors and WiFi chips?
>>>
>>>
>>> For i2c based sensors the plan is to use devicetree overlays + an in
>>> kernel
>>> overlay manager which probes the i2c bus (checking known touchscreen /
>>> accelerometer
>>> addresses) and then picks the right touchscreen + accelerometer overlays.
>>>
>>> Wifi is somewhat more tricky I must admit, esp. since there seem to be q8
>>> a23 based
>>> tablet variants with usb wifi and others with sdio wifi. Since both
>>> busses are
>>> discoverable I'm tempted to just enable both in devicetree, and let the
>>> kernel probe
>>> and see what is actually there. This assume that the way the wifichip is
>>> powered
>>> is the same on all boards, or at least that it is safe to enable the
>>> necessary
>>> regulators on all boards ...
>>>
>>>> I'm asking because with Maxime's couple-regulator we should be able to
>>>> get the
>>>> RTL8723BS on the Q8 A23/33 v1.5 working.
>>>
>>>
>>> So this means enabled the sdio controller (should be safe on all boards?)
>>> and
>>> enabling 2 regulators to power the wifi-chip. I think it will be safe to
>>> do this
>>> even on boards where those regulators are not used, what do you think ?
>>
>>
>> Wouldn't that introduce some useless power drain on those boards?
>
>
> If nothing is attached to those regulators (which I expect to be the case
> when
> they are not used to power wifi) then I would expect the drain to be
> minimal,
> my biggest worry is some board having tied these to ground, but I don't
> think
> that is very likely.

AFAIK the AXP datasheets mention that unused DCDC outputs should be left
floating. Not sure if this applies to LDO outputs as well. But any used
outputs would have a bypass capacitor.

>From the board designs I've seen, this seems to be the common case.
I'm not an electrical engineer, but I think we're covered here.

Another thing we need to deal with is the different power sequencing
requirements for the different SDIO chips.

Regards
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet
Date: Tue, 22 Dec 2015 12:29:24 +0800	[thread overview]
Message-ID: <CAGb2v67+XpYwUFAVSGEGAfJ0bzubQ87Ebaf5W5Ze619mEE6uUA@mail.gmail.com> (raw)
In-Reply-To: <567854D5.7030601@redhat.com>

On Tue, Dec 22, 2015 at 3:36 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 21-12-15 17:11, Maxime Ripard wrote:
>>
>> Hi,x
>>
>> On Mon, Dec 21, 2015 at 11:46:18AM +0100, Hans de Goede wrote:
>>>>
>>>> On the side, any thoughts on how to handle the differences between
>>>> various "Q8"
>>>> tablets, like different I2C-based sensors and WiFi chips?
>>>
>>>
>>> For i2c based sensors the plan is to use devicetree overlays + an in
>>> kernel
>>> overlay manager which probes the i2c bus (checking known touchscreen /
>>> accelerometer
>>> addresses) and then picks the right touchscreen + accelerometer overlays.
>>>
>>> Wifi is somewhat more tricky I must admit, esp. since there seem to be q8
>>> a23 based
>>> tablet variants with usb wifi and others with sdio wifi. Since both
>>> busses are
>>> discoverable I'm tempted to just enable both in devicetree, and let the
>>> kernel probe
>>> and see what is actually there. This assume that the way the wifichip is
>>> powered
>>> is the same on all boards, or at least that it is safe to enable the
>>> necessary
>>> regulators on all boards ...
>>>
>>>> I'm asking because with Maxime's couple-regulator we should be able to
>>>> get the
>>>> RTL8723BS on the Q8 A23/33 v1.5 working.
>>>
>>>
>>> So this means enabled the sdio controller (should be safe on all boards?)
>>> and
>>> enabling 2 regulators to power the wifi-chip. I think it will be safe to
>>> do this
>>> even on boards where those regulators are not used, what do you think ?
>>
>>
>> Wouldn't that introduce some useless power drain on those boards?
>
>
> If nothing is attached to those regulators (which I expect to be the case
> when
> they are not used to power wifi) then I would expect the drain to be
> minimal,
> my biggest worry is some board having tied these to ground, but I don't
> think
> that is very likely.

AFAIK the AXP datasheets mention that unused DCDC outputs should be left
floating. Not sure if this applies to LDO outputs as well. But any used
outputs would have a bypass capacitor.

>From the board designs I've seen, this seems to be the common case.
I'm not an electrical engineer, but I think we're covered here.

Another thing we need to deal with is the different power sequencing
requirements for the different SDIO chips.

Regards
ChenYu

  parent reply	other threads:[~2015-12-22  4:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 11:42 [PATCH 1/5] ARM: dts: sun4i: Add touchscreen node to inet9f-rev03 tablet dts file Hans de Goede
2015-12-20 11:42 ` Hans de Goede
     [not found] ` <1450611782-9494-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-20 11:42   ` [PATCH 2/5] ARM: dts: sun4i: Add touchscreen node to chuwi-v7 " Hans de Goede
2015-12-20 11:42     ` Hans de Goede
     [not found]     ` <1450611782-9494-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-21  5:56       ` Chen-Yu Tsai
2015-12-21  5:56         ` Chen-Yu Tsai
2015-12-20 11:43   ` [PATCH 3/5] ARM: dts: sun4i: Add touchscreen node to inet97fv2 " Hans de Goede
2015-12-20 11:43     ` Hans de Goede
     [not found]     ` <1450611782-9494-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-21  5:58       ` Chen-Yu Tsai
2015-12-21  5:58         ` Chen-Yu Tsai
2015-12-20 11:43   ` [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet Hans de Goede
2015-12-20 11:43     ` Hans de Goede
     [not found]     ` <1450611782-9494-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-21  6:09       ` Chen-Yu Tsai
2015-12-21  6:09         ` Chen-Yu Tsai
     [not found]         ` <CAGb2v65daCCOWf7EXDkNWnxv1idXHXesOp6Et_0h-o+9drdeMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21 10:46           ` Hans de Goede
2015-12-21 10:46             ` [linux-sunxi] " Hans de Goede
     [not found]             ` <5677D87A.90805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-21 16:11               ` Maxime Ripard
2015-12-21 16:11                 ` [linux-sunxi] " Maxime Ripard
2015-12-21 19:36                 ` Hans de Goede
2015-12-21 19:36                   ` [linux-sunxi] " Hans de Goede
     [not found]                   ` <567854D5.7030601-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-22  4:29                     ` Chen-Yu Tsai [this message]
2015-12-22  4:29                       ` Chen-Yu Tsai
     [not found]                       ` <CAGb2v67+XpYwUFAVSGEGAfJ0bzubQ87Ebaf5W5Ze619mEE6uUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-22 10:50                         ` Hans de Goede
2015-12-22 10:50                           ` Hans de Goede
2016-01-04 10:11                         ` Maxime Ripard
2016-01-04 10:11                           ` [linux-sunxi] " Maxime Ripard
2015-12-21 16:10       ` Maxime Ripard
2015-12-21 16:10         ` Maxime Ripard
2015-12-20 11:43   ` [PATCH 5/5] ARM: dts: sun7i: Enable gmac on Wits Pro A20 DKT Hans de Goede
2015-12-20 11:43     ` Hans de Goede
     [not found]     ` <1450611782-9494-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-21  5:55       ` Chen-Yu Tsai
2015-12-21  5:55         ` Chen-Yu Tsai
     [not found]         ` <CAGb2v67JKRNCTspryGNiRG2zO8usMdfD=cGWzCK+eKMmyb5bvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21 16:08           ` Maxime Ripard
2015-12-21 16:08             ` Maxime Ripard
2015-12-21  5:57   ` [PATCH 1/5] ARM: dts: sun4i: Add touchscreen node to inet9f-rev03 tablet dts file Chen-Yu Tsai
2015-12-21  5:57     ` Chen-Yu Tsai
     [not found]     ` <CAGb2v67tBGSZTwVk4uQ97tqah3x83xFEPJn=rM-dBV9xgyFMAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-21 10:40       ` [linux-sunxi] " Hans de Goede
2015-12-21 10:40         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v67+XpYwUFAVSGEGAfJ0bzubQ87Ebaf5W5Ze619mEE6uUA@mail.gmail.com \
    --to=wens-jday2fn1rrm@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.