From: Chen-Yu Tsai <wens@csie.org> To: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: "Hans de Goede" <hdegoede@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>, "Boris BREZILLON" <boris.brezillon@free-electrons.com>, "Jason Cooper" <jason@lakedaemon.net>, "Tawfik Bayouk" <tawfik@marvell.com>, "Andrew Lunn" <andrew@lunn.ch>, devicetree <devicetree@vger.kernel.org>, "Antoine Ténart" <antoine.tenart@free-electrons.com>, "Mark Rutland" <mark.rutland@arm.com>, "Nadav Haklai" <nadavh@marvell.com>, linux-ide@vger.kernel.org, "Lior Amsalem" <alior@marvell.com>, "Mark Brown" <broonie@kernel.org>, "Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>, "Tejun Heo" <tj@kernel.org>, "Maxime Ripard" <maxime.ripard@free-electrons.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com> Subject: Re: [PATCH v2 2/4] Documentation: bindings: Add the regulator property to the sub-nodes AHCI bindings Date: Sat, 10 Jan 2015 00:29:32 +0800 [thread overview] Message-ID: <CAGb2v674q4Cjp9qy9CbUXe2j5pT_ez98CKxXHC8u4Diap2TT1A@mail.gmail.com> (raw) In-Reply-To: <54AFFFDC.7020307@free-electrons.com> Hi, On Sat, Jan 10, 2015 at 12:20 AM, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > Hi Hans, > > On 09/01/2015 16:46, Hans de Goede wrote: >> Hi, >> >> On 09-01-15 11:39, Gregory CLEMENT wrote: >>> It is now possible to use a regulator property for each port of the >>> AHCI controller. >>> >>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> >>> --- >>> Documentation/devicetree/bindings/ata/ahci-platform.txt | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt >>> index 4ab09f2202d4..87416d71c758 100644 >>> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt >>> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt >>> @@ -37,9 +37,10 @@ Required properties when using sub-nodes: >>> >>> >>> Sub-nodes required properties: >>> -- reg : the port number >>> -- phys : reference to the SATA PHY node >>> - >>> +- reg : the port number >>> +And at least one of the following properties: >>> +- phys : reference to the SATA PHY node >>> +- target-port<n>-supply : regulator for SATA target power for port <n> >>> >>> Examples: >>> sata@ffe08000 { >>> @@ -68,10 +69,12 @@ With sub-nodes: >>> sata0: sata-port@0 { >>> reg = <0>; >>> phys = <&sata_phy 0>; >>> + target-port0-supply = <®_sata0>; >>> }; >>> >> >> I'm sorry, but I've to NAK this, I did not follow the regulator discussion., >> thinking that it was just about the use of some utility function vs diy or >> some such, I had no idea this would impact the dt-binding. >> >> The -port%d- bit is completely unnecessary from a dt pov. Devicetree is >> supposed to be OS agnostic, we cannot make the dt-binding ugly just because >> the regulator subsys in Linux does not provide the necessary functionality. >> >> I'm afraid you will have to get back to the regulator subsys people and tell >> them that we really need an of_regulator_get, so that we can tell the >> regulator subsys we want a regulator from a specific of_node. > > I didn't cc you especially, but I cc the linux-ide mailing list. The > email was "[PATCH 2/2] regulator: core: Add the device tree version to > the regulator_get family" (see > http://thread.gmane.org/gmane.linux.kernel/1856154). > > Mark Brown didn't want a firmware specific interface. The regulator > framework allows associating only a regulator to a device and > currently, at least from the point of view of the device tree, the > port subnodes are not devices. He suggested making the child node > device. However, when I had a look on it, it didn't seem an easy > task. As you know better this code, what do you think of it? > > (I added Mark Bronw in CC of this email so he can add more explanation > if needed) Since the AHCI library code already supports the generic phy subsystem, with one phy possible for each port node, you could possibly add a generic phy that just takes a regulator, and hook it up that way. I don't know if the extra layer of indirection is good or not. Just offering an alternative. Regards, ChenYu >> >> Please CC me when you re-open the discussion with the regulator people. >> >> Regards, >> >> Hans >> > > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/4] Documentation: bindings: Add the regulator property to the sub-nodes AHCI bindings Date: Sat, 10 Jan 2015 00:29:32 +0800 [thread overview] Message-ID: <CAGb2v674q4Cjp9qy9CbUXe2j5pT_ez98CKxXHC8u4Diap2TT1A@mail.gmail.com> (raw) In-Reply-To: <54AFFFDC.7020307@free-electrons.com> Hi, On Sat, Jan 10, 2015 at 12:20 AM, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > Hi Hans, > > On 09/01/2015 16:46, Hans de Goede wrote: >> Hi, >> >> On 09-01-15 11:39, Gregory CLEMENT wrote: >>> It is now possible to use a regulator property for each port of the >>> AHCI controller. >>> >>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> >>> --- >>> Documentation/devicetree/bindings/ata/ahci-platform.txt | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt >>> index 4ab09f2202d4..87416d71c758 100644 >>> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt >>> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt >>> @@ -37,9 +37,10 @@ Required properties when using sub-nodes: >>> >>> >>> Sub-nodes required properties: >>> -- reg : the port number >>> -- phys : reference to the SATA PHY node >>> - >>> +- reg : the port number >>> +And at least one of the following properties: >>> +- phys : reference to the SATA PHY node >>> +- target-port<n>-supply : regulator for SATA target power for port <n> >>> >>> Examples: >>> sata at ffe08000 { >>> @@ -68,10 +69,12 @@ With sub-nodes: >>> sata0: sata-port at 0 { >>> reg = <0>; >>> phys = <&sata_phy 0>; >>> + target-port0-supply = <®_sata0>; >>> }; >>> >> >> I'm sorry, but I've to NAK this, I did not follow the regulator discussion., >> thinking that it was just about the use of some utility function vs diy or >> some such, I had no idea this would impact the dt-binding. >> >> The -port%d- bit is completely unnecessary from a dt pov. Devicetree is >> supposed to be OS agnostic, we cannot make the dt-binding ugly just because >> the regulator subsys in Linux does not provide the necessary functionality. >> >> I'm afraid you will have to get back to the regulator subsys people and tell >> them that we really need an of_regulator_get, so that we can tell the >> regulator subsys we want a regulator from a specific of_node. > > I didn't cc you especially, but I cc the linux-ide mailing list. The > email was "[PATCH 2/2] regulator: core: Add the device tree version to > the regulator_get family" (see > http://thread.gmane.org/gmane.linux.kernel/1856154). > > Mark Brown didn't want a firmware specific interface. The regulator > framework allows associating only a regulator to a device and > currently, at least from the point of view of the device tree, the > port subnodes are not devices. He suggested making the child node > device. However, when I had a look on it, it didn't seem an easy > task. As you know better this code, what do you think of it? > > (I added Mark Bronw in CC of this email so he can add more explanation > if needed) Since the AHCI library code already supports the generic phy subsystem, with one phy possible for each port node, you could possibly add a generic phy that just takes a regulator, and hook it up that way. I don't know if the extra layer of indirection is good or not. Just offering an alternative. Regards, ChenYu >> >> Please CC me when you re-open the discussion with the regulator people. >> >> Regards, >> >> Hans >> > > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-01-09 16:29 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-09 10:39 [PATCH v2 0/4] ata: libahci: Allow using a regulator for each port Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` [PATCH v2 1/4] ata: libahci: Clean-up the ahci_platform_en/disable_phys functions Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` [PATCH v2 3/4] ata: libahci: Allow using multiple regulators Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT [not found] ` <1420799989-10645-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-01-09 10:39 ` [PATCH v2 2/4] Documentation: bindings: Add the regulator property to the sub-nodes AHCI bindings Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 15:46 ` Hans de Goede 2015-01-09 15:46 ` Hans de Goede 2015-01-09 16:20 ` Gregory CLEMENT 2015-01-09 16:20 ` Gregory CLEMENT 2015-01-09 16:29 ` Chen-Yu Tsai [this message] 2015-01-09 16:29 ` Chen-Yu Tsai 2015-01-09 17:11 ` Mark Brown 2015-01-09 17:11 ` Mark Brown [not found] ` <20150109171131.GH2634-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2015-01-10 10:20 ` Hans de Goede 2015-01-10 10:20 ` Hans de Goede 2015-01-10 10:20 ` Hans de Goede 2015-01-10 11:17 ` Mark Brown 2015-01-10 11:17 ` Mark Brown 2015-01-10 13:51 ` Hans de Goede 2015-01-10 13:51 ` Hans de Goede 2015-01-12 12:49 ` Gregory CLEMENT 2015-01-12 12:49 ` Gregory CLEMENT 2015-01-09 10:39 ` [PATCH v2 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT 2015-01-09 10:39 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGb2v674q4Cjp9qy9CbUXe2j5pT_ez98CKxXHC8u4Diap2TT1A@mail.gmail.com \ --to=wens@csie.org \ --cc=alior@marvell.com \ --cc=andrew@lunn.ch \ --cc=antoine.tenart@free-electrons.com \ --cc=boris.brezillon@free-electrons.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel.garcia@free-electrons.com \ --cc=gregory.clement@free-electrons.com \ --cc=hdegoede@redhat.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@free-electrons.com \ --cc=nadavh@marvell.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=tawfik@marvell.com \ --cc=thomas.petazzoni@free-electrons.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.