From: Chen-Yu Tsai <wens@csie.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] panfrost: Properly undo pm_runtime_enable when deferring a probe
Date: Thu, 24 Oct 2019 11:51:12 +0800 [thread overview]
Message-ID: <CAGb2v675oCOr6JR6CXB28hrUuwBN2M9C9SS6UPNpbEAfw9ztjA@mail.gmail.com> (raw)
In-Reply-To: <20191023122157.32067-1-tomeu.vizoso@collabora.com>
On Wed, Oct 23, 2019 at 8:22 PM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>
> When deferring the probe because of a missing regulator, we were calling
> pm_runtime_disable even if pm_runtime_enable wasn't called.
>
> Move the call to pm_runtime_disable to the right place.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reported-by: Chen-Yu Tsai <wens@csie.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure")
Tested-by: Chen-Yu Tsai <wens@csie.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@csie.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2] panfrost: Properly undo pm_runtime_enable when deferring a probe
Date: Thu, 24 Oct 2019 11:51:12 +0800 [thread overview]
Message-ID: <CAGb2v675oCOr6JR6CXB28hrUuwBN2M9C9SS6UPNpbEAfw9ztjA@mail.gmail.com> (raw)
Message-ID: <20191024035112.xp4dlSr_rUOLq6JnOlzy7Qx9tRtPmEum4ls1O7zD6jQ@z> (raw)
In-Reply-To: <20191023122157.32067-1-tomeu.vizoso@collabora.com>
On Wed, Oct 23, 2019 at 8:22 PM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>
> When deferring the probe because of a missing regulator, we were calling
> pm_runtime_disable even if pm_runtime_enable wasn't called.
>
> Move the call to pm_runtime_disable to the right place.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reported-by: Chen-Yu Tsai <wens@csie.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure")
Tested-by: Chen-Yu Tsai <wens@csie.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-24 3:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 12:09 [PATCH] panfrost: Properly undo pm_runtime_enable when deferring a probe Tomeu Vizoso
2019-10-23 12:09 ` Tomeu Vizoso
2019-10-23 12:21 ` [PATCH v2] " Tomeu Vizoso
2019-10-23 12:21 ` Tomeu Vizoso
2019-10-23 12:49 ` Robin Murphy
2019-10-23 12:49 ` Robin Murphy
2019-10-23 15:49 ` Steven Price
2019-10-23 15:49 ` Steven Price
2019-10-23 17:58 ` Rob Herring
2019-10-23 17:58 ` Rob Herring
2019-10-24 3:51 ` Chen-Yu Tsai [this message]
2019-10-24 3:51 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v675oCOr6JR6CXB28hrUuwBN2M9C9SS6UPNpbEAfw9ztjA@mail.gmail.com \
--to=wens@csie.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.