From: Chen-Yu Tsai <wens@csie.org> To: Emmanuel Vadot <manu@freebsd.org> Cc: Maxime Ripard <mripard@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino Date: Fri, 17 Jan 2020 11:20:21 +0800 [thread overview] Message-ID: <CAGb2v67U6qjNf0PPMOm191UZDQvJTGZNNREc22ZsDW61KqaUEA@mail.gmail.com> (raw) In-Reply-To: <20200116194658.78893-1-manu@freebsd.org> On Fri, Jan 17, 2020 at 3:47 AM Emmanuel Vadot <manu@freebsd.org> wrote: > > Add the regulators for each bank on this boards. > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org> > --- > .../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > index 01a9a52edae4..1a25abf6065c 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > @@ -163,6 +163,17 @@ &ohci1 { > status = "okay"; > }; > > +&pio { > + vcc-pa-supply = <®_dcdc1>; > + vcc-pb-supply = <®_dcdc1>; > + vcc-pc-supply = <®_dcdc1>; > + vcc-pd-supply = <®_dcdc1>; > + vcc-pe-supply = <®_aldo1>; > + vcc-pf-supply = <®_dcdc1>; > + vcc-pg-supply = <®_dldo4>; > + vcc-ph-supply = <®_dcdc1>; > +}; > + > &r_rsb { > status = "okay"; > > @@ -175,6 +186,10 @@ axp803: pmic@3a3 { > }; > }; > > +&r_pio { > + vcc-pl-supply = <®_aldo2>; This is likely going to cause a circular dependency, because the RSB interface that is used to talk to the PMIC is also on the PL pins. (How does FreeBSD deal with this?) Instead, just add a comment describing what is really used, and set the regulator to always-on, which should already be the case. ChenYu > +}; > + > #include "axp803.dtsi" > > &ac_power_supply { > -- > 2.24.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@csie.org> To: Emmanuel Vadot <manu@freebsd.org> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, Maxime Ripard <mripard@kernel.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino Date: Fri, 17 Jan 2020 11:20:21 +0800 [thread overview] Message-ID: <CAGb2v67U6qjNf0PPMOm191UZDQvJTGZNNREc22ZsDW61KqaUEA@mail.gmail.com> (raw) In-Reply-To: <20200116194658.78893-1-manu@freebsd.org> On Fri, Jan 17, 2020 at 3:47 AM Emmanuel Vadot <manu@freebsd.org> wrote: > > Add the regulators for each bank on this boards. > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org> > --- > .../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > index 01a9a52edae4..1a25abf6065c 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts > @@ -163,6 +163,17 @@ &ohci1 { > status = "okay"; > }; > > +&pio { > + vcc-pa-supply = <®_dcdc1>; > + vcc-pb-supply = <®_dcdc1>; > + vcc-pc-supply = <®_dcdc1>; > + vcc-pd-supply = <®_dcdc1>; > + vcc-pe-supply = <®_aldo1>; > + vcc-pf-supply = <®_dcdc1>; > + vcc-pg-supply = <®_dldo4>; > + vcc-ph-supply = <®_dcdc1>; > +}; > + > &r_rsb { > status = "okay"; > > @@ -175,6 +186,10 @@ axp803: pmic@3a3 { > }; > }; > > +&r_pio { > + vcc-pl-supply = <®_aldo2>; This is likely going to cause a circular dependency, because the RSB interface that is used to talk to the PMIC is also on the PL pins. (How does FreeBSD deal with this?) Instead, just add a comment describing what is really used, and set the regulator to always-on, which should already be the case. ChenYu > +}; > + > #include "axp803.dtsi" > > &ac_power_supply { > -- > 2.24.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-17 3:20 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-16 19:46 [PATCH] arm64: dts: allwinner: a64: Add gpio bank supply for A64-Olinuxino Emmanuel Vadot 2020-01-16 19:46 ` Emmanuel Vadot 2020-01-17 3:20 ` Chen-Yu Tsai [this message] 2020-01-17 3:20 ` Chen-Yu Tsai 2020-01-18 14:27 ` Emmanuel Vadot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGb2v67U6qjNf0PPMOm191UZDQvJTGZNNREc22ZsDW61KqaUEA@mail.gmail.com \ --to=wens@csie.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=manu@freebsd.org \ --cc=mark.rutland@arm.com \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.