From: Chen-Yu Tsai <wens@csie.org> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Chen-Yu Tsai <wens@csie.org>, Hans de Goede <hdegoede@redhat.com>, Mylene Josserand <mylene.josserand@free-electrons.com>, linux-clk <linux-clk@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Subject: Re: [PATCH v2 4/7] clk: sunxi-ng: Add N-class clocks support Date: Wed, 7 Sep 2016 14:45:21 +0800 [thread overview] Message-ID: <CAGb2v67tM_3Q81=Mb1Nf0cja+oxBjJi=6mhkkpnvRM2i0BAmiQ@mail.gmail.com> (raw) In-Reply-To: <20160906121837.7517-5-maxime.ripard@free-electrons.com> On Tue, Sep 6, 2016 at 8:18 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Add support for the class with a single factor, N, being a multiplier. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Acked-by: Chen-Yu Tsai <wens@csie.org> > --- [...] > diff --git a/drivers/clk/sunxi-ng/ccu_mult.c b/drivers/clk/sunxi-ng/ccu_mult.c > new file mode 100644 > index 000000000000..119b190c0eb5 > --- /dev/null > +++ b/drivers/clk/sunxi-ng/ccu_mult.c [...] > +static int ccu_mult_set_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate) > +{ > + struct ccu_mult *cm = hw_to_ccu_mult(hw); > + unsigned long flags; > + unsigned int n; > + u32 reg; > + > + ccu_mux_helper_adjust_parent_for_prediv(&cm->common, &cm->mux, -1, > + &parent_rate); > + Git complains about extra whitespace here. You can keep my ack after fixing it. ChenYu > + ccu_mult_find_best(parent_rate, rate, 1 << cm->mult.width, &n); > + > + spin_lock_irqsave(cm->common.lock, flags); > + > + reg = readl(cm->common.base + cm->common.reg); > + reg &= ~GENMASK(cm->mult.width + cm->mult.shift - 1, cm->mult.shift); > + > + writel(reg | ((n - 1) << cm->mult.shift), > + cm->common.base + cm->common.reg); > + > + spin_unlock_irqrestore(cm->common.lock, flags); > + > + return 0; > +}
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 4/7] clk: sunxi-ng: Add N-class clocks support Date: Wed, 7 Sep 2016 14:45:21 +0800 [thread overview] Message-ID: <CAGb2v67tM_3Q81=Mb1Nf0cja+oxBjJi=6mhkkpnvRM2i0BAmiQ@mail.gmail.com> (raw) In-Reply-To: <20160906121837.7517-5-maxime.ripard@free-electrons.com> On Tue, Sep 6, 2016 at 8:18 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Add support for the class with a single factor, N, being a multiplier. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Acked-by: Chen-Yu Tsai <wens@csie.org> > --- [...] > diff --git a/drivers/clk/sunxi-ng/ccu_mult.c b/drivers/clk/sunxi-ng/ccu_mult.c > new file mode 100644 > index 000000000000..119b190c0eb5 > --- /dev/null > +++ b/drivers/clk/sunxi-ng/ccu_mult.c [...] > +static int ccu_mult_set_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate) > +{ > + struct ccu_mult *cm = hw_to_ccu_mult(hw); > + unsigned long flags; > + unsigned int n; > + u32 reg; > + > + ccu_mux_helper_adjust_parent_for_prediv(&cm->common, &cm->mux, -1, > + &parent_rate); > + Git complains about extra whitespace here. You can keep my ack after fixing it. ChenYu > + ccu_mult_find_best(parent_rate, rate, 1 << cm->mult.width, &n); > + > + spin_lock_irqsave(cm->common.lock, flags); > + > + reg = readl(cm->common.base + cm->common.reg); > + reg &= ~GENMASK(cm->mult.width + cm->mult.shift - 1, cm->mult.shift); > + > + writel(reg | ((n - 1) << cm->mult.shift), > + cm->common.base + cm->common.reg); > + > + spin_unlock_irqrestore(cm->common.lock, flags); > + > + return 0; > +}
next prev parent reply other threads:[~2016-09-07 6:45 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-06 12:18 [PATCH v2 0/7] clk: sunxi-ng: Introduce support for A23 and A33 CCUs Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 12:18 ` [PATCH v2 1/7] clk: sunxi-ng: div: Add mux table macros Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 12:18 ` [PATCH v2 2/7] clk: sunxi-ng: div: Allow to set a maximum Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 16:20 ` Chen-Yu Tsai 2016-09-06 16:20 ` Chen-Yu Tsai 2016-09-08 8:53 ` Maxime Ripard 2016-09-08 8:53 ` Maxime Ripard 2016-09-06 12:18 ` [PATCH v2 3/7] clk: sunxi-ng: mux: Add mux table macro Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 12:18 ` [PATCH v2 4/7] clk: sunxi-ng: Add N-class clocks support Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-07 6:45 ` Chen-Yu Tsai [this message] 2016-09-07 6:45 ` Chen-Yu Tsai 2016-09-06 12:18 ` [PATCH v2 5/7] clk: sunxi-ng: Add A33 CCU support Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-07 7:06 ` Chen-Yu Tsai 2016-09-07 7:06 ` Chen-Yu Tsai 2016-09-06 12:18 ` [PATCH v2 6/7] clk: sunxi-ng: Add A23 CCU Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-07 7:24 ` Chen-Yu Tsai 2016-09-07 7:24 ` Chen-Yu Tsai 2016-09-08 8:29 ` Maxime Ripard 2016-09-08 8:29 ` Maxime Ripard 2016-09-08 8:29 ` Maxime Ripard 2016-09-08 8:32 ` Chen-Yu Tsai 2016-09-08 8:32 ` Chen-Yu Tsai 2016-09-08 8:35 ` Chen-Yu Tsai 2016-09-08 8:35 ` Chen-Yu Tsai 2016-09-08 8:35 ` Chen-Yu Tsai 2016-09-08 9:20 ` Maxime Ripard 2016-09-08 9:20 ` Maxime Ripard 2016-09-06 12:18 ` [PATCH v2 7/7] ARM: sun8i: Convert the A23 and A33 to the CCU Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 12:18 ` Maxime Ripard 2016-09-06 14:08 ` Chen-Yu Tsai 2016-09-06 14:08 ` Chen-Yu Tsai 2016-09-07 20:37 ` Maxime Ripard 2016-09-07 20:37 ` Maxime Ripard 2016-09-07 20:37 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGb2v67tM_3Q81=Mb1Nf0cja+oxBjJi=6mhkkpnvRM2i0BAmiQ@mail.gmail.com' \ --to=wens@csie.org \ --cc=devicetree@vger.kernel.org \ --cc=hdegoede@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=mturquette@baylibre.com \ --cc=mylene.josserand@free-electrons.com \ --cc=sboyd@codeaurora.org \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.