Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

[Cortland Setlow Tölva]

Hi Laurent,

The deeper view on part 3 can wait - I have found an issue with 64-bit
hosts.  In linux-user/syscall_defs.h the references to struct usbdevfs_urb
and so forth are incorrect and I need to define struct target_usbdevfs_urb
for the size and the ioctl code to be calculated with the target's ABI.

I will send updated patches.

--CST

On Mon, Sep 24, 2018 at 10:22 AM Laurent Vivier <laurent@vivier.eu> wrote:

> Le 23/09/2018 à 06:44, Blake Tölva a écrit :
> > Thanks Laurent, I have updated the patch.  Should I resend the whole
> > series to the list?
>
> yes.
>
> > I believe the third patch may also need revision as the call to
> > thunk_convert at the end
> > of do_ioctl_usbdevfs_reapurb seems clunky.  Would love some comments.
> >
> I didn't read your comment before reviewing this patch. I'm going to
> have deeper view on this part.
>
> Thanks,
> Laurent
>