* [PATCH -next] drm/hisilicon: Fix non static symbol warning
@ 2016-07-13 12:43 weiyj_lk
2016-07-18 1:21 ` Xinliang Liu
0 siblings, 1 reply; 3+ messages in thread
From: weiyj_lk @ 2016-07-13 12:43 UTC (permalink / raw)
To: Xinliang Liu, Xinwei Kong, Chen Feng, David Airlie
Cc: Wei Yongjun, dri-devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warning:
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:107:5: warning:
symbol 'ade_get_channel_formats' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 805f432..2a913cc 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -104,7 +104,7 @@ static const u32 channel_formats1[] = {
DRM_FORMAT_ABGR8888
};
-u32 ade_get_channel_formats(u8 ch, const u32 **formats)
+static u32 ade_get_channel_formats(u8 ch, const u32 **formats)
{
switch (ch) {
case ADE_CH1:
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/hisilicon: Fix non static symbol warning
2016-07-13 12:43 [PATCH -next] drm/hisilicon: Fix non static symbol warning weiyj_lk
@ 2016-07-18 1:21 ` Xinliang Liu
0 siblings, 0 replies; 3+ messages in thread
From: Xinliang Liu @ 2016-07-18 1:21 UTC (permalink / raw)
To: weiyj_lk
Cc: Xinliang Liu, Xinwei Kong, Chen Feng, David Airlie, Wei Yongjun,
Linux Kernel Mailing List, dri-devel
On 13 July 2016 at 20:43, <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:107:5: warning:
> symbol 'ade_get_channel_formats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, applied to drm-hisilicon-next.
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 805f432..2a913cc 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -104,7 +104,7 @@ static const u32 channel_formats1[] = {
> DRM_FORMAT_ABGR8888
> };
>
> -u32 ade_get_channel_formats(u8 ch, const u32 **formats)
> +static u32 ade_get_channel_formats(u8 ch, const u32 **formats)
> {
> switch (ch) {
> case ADE_CH1:
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/hisilicon: Fix non static symbol warning
@ 2016-07-18 1:21 ` Xinliang Liu
0 siblings, 0 replies; 3+ messages in thread
From: Xinliang Liu @ 2016-07-18 1:21 UTC (permalink / raw)
To: weiyj_lk
Cc: Chen Feng, Wei Yongjun, dri-devel, Linux Kernel Mailing List,
Xinliang Liu
On 13 July 2016 at 20:43, <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c:107:5: warning:
> symbol 'ade_get_channel_formats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, applied to drm-hisilicon-next.
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 805f432..2a913cc 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -104,7 +104,7 @@ static const u32 channel_formats1[] = {
> DRM_FORMAT_ABGR8888
> };
>
> -u32 ade_get_channel_formats(u8 ch, const u32 **formats)
> +static u32 ade_get_channel_formats(u8 ch, const u32 **formats)
> {
> switch (ch) {
> case ADE_CH1:
>
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-18 1:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 12:43 [PATCH -next] drm/hisilicon: Fix non static symbol warning weiyj_lk
2016-07-18 1:21 ` Xinliang Liu
2016-07-18 1:21 ` Xinliang Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.