From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Jonathan Nieder <jrnieder@gmail.com>
Cc: "Matthieu Moy" <Matthieu.Moy@imag.fr>,
git@vger.kernel.org,
"Jeremie Nikaes" <jeremie.nikaes@ensimag.imag.fr>,
"Arnaud Lacurie" <arnaud.lacurie@ensimag.imag.fr>,
"Claire Fousse" <claire.fousse@ensimag.imag.fr>,
"David Amouyal" <david.amouyal@ensimag.imag.fr>,
"Matthieu Moy" <matthieu.moy@grenoble-inp.fr>,
"Sylvain Boulmé" <sylvain.boulme@imag.fr>
Subject: Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push)
Date: Mon, 29 Aug 2011 07:42:48 +0200 [thread overview]
Message-ID: <CAGdFq_iYRkfnTbYAgmX1g4uOxWb_ZYxr+TNinVfWRV-zXrnzAg@mail.gmail.com> (raw)
In-Reply-To: <7v4o14dppz.fsf@alter.siamese.dyndns.org>
Heya,
2011/8/26 Junio C Hamano <gitster@pobox.com>:
> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>> In short, the changes since v3 are:
>>
>> * Adapt to newer Git, which seem to require a "done" command at the
>> end of the fast-import stream. I don't understand why this is
>> needed, since fast-import is called without the --done flag by
>> remote-helpers, but if I don't do this, "git fetch" doesn't
>> terminate and keeps waiting ...
>
> Hmmmm, is this a regression in fast-import? Can this be bisected if so?
We agreed that making this change is the best way to go forward, since
there's so few (read: none) remote-helpers yet, the fix is trivial,
and it solves a design mistake while the api is not yet set in stone.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2011-08-29 5:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 17:11 [PATCH 1/2] fast-import: initialize variable require_explicit_termination Matthieu Moy
2011-08-26 17:11 ` [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push) Matthieu Moy
2011-08-26 17:53 ` Junio C Hamano
2011-08-29 5:42 ` Sverre Rabbelier [this message]
2011-08-29 6:05 ` Junio C Hamano
2011-08-29 6:41 ` Sverre Rabbelier
2011-08-30 3:56 ` Jonathan Nieder
2011-08-30 17:13 ` Junio C Hamano
2011-08-31 11:54 ` Matthieu Moy
2011-09-01 23:44 ` Jonathan Nieder
2011-08-31 12:05 ` done feature in remote-helpers (was Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push)) Matthieu Moy
2011-08-31 12:17 ` Sverre Rabbelier
2011-08-31 12:55 ` Matthieu Moy
2011-08-31 12:58 ` Sverre Rabbelier
2011-08-31 13:12 ` Matthieu Moy
2011-08-31 13:16 ` Sverre Rabbelier
2011-08-31 16:47 ` [PATCH] git-remote-helpers.txt: explain how import works with multiple refs Matthieu Moy
2011-08-31 18:14 ` [PATCH] (short) documentation for the testgit remote helper Matthieu Moy
2011-09-01 11:27 ` Sverre Rabbelier
2011-09-01 15:52 ` Matthieu Moy
2011-09-01 16:49 ` [PATCH 1/2 v2] Documentation/git-remote-helpers: explain how import works with multiple refs Matthieu Moy
2011-09-01 16:49 ` [PATCH 2/2 v2] (short) documentation for the testgit remote helper Matthieu Moy
2011-09-01 16:59 ` Sverre Rabbelier
2011-09-01 16:59 ` [PATCH 1/2 v2] Documentation/git-remote-helpers: explain how import works with multiple refs Sverre Rabbelier
2011-09-01 11:24 ` [PATCH] git-remote-helpers.txt: " Sverre Rabbelier
2011-09-01 23:17 ` Jonathan Nieder
2011-09-03 10:35 ` Matthieu Moy
2011-08-26 17:55 ` [PATCH v5] Add a remote helper to interact with mediawiki (fetch & push) Matthieu Moy
2011-08-31 16:55 ` [PATCH v6] " Matthieu Moy
2011-08-31 17:03 ` Sverre Rabbelier
2011-08-31 17:30 ` Matthieu Moy
2011-09-01 0:24 ` Junio C Hamano
2011-09-01 5:26 ` Matthieu Moy
2011-09-01 16:54 ` [PATCH 0/2] Git-MediaWiki Matthieu Moy
2011-09-01 16:54 ` [PATCH 1/2 v7] Add a remote helper to interact with mediawiki (fetch & push) Matthieu Moy
2011-09-01 16:54 ` [PATCH 2/2] git-remote-mediawiki: allow push to set MediaWiki metadata Matthieu Moy
2011-08-31 12:33 ` Clean termination of remote-helpers (was Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push)) Matthieu Moy
2011-08-31 13:25 ` Sverre Rabbelier
2011-08-31 14:53 ` Matthieu Moy
2011-08-31 15:00 ` Sverre Rabbelier
2011-08-26 17:51 ` [PATCH 1/2] fast-import: initialize variable require_explicit_termination Junio C Hamano
2011-08-26 17:59 ` Matthieu Moy
2011-08-26 18:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdFq_iYRkfnTbYAgmX1g4uOxWb_ZYxr+TNinVfWRV-zXrnzAg@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=arnaud.lacurie@ensimag.imag.fr \
--cc=claire.fousse@ensimag.imag.fr \
--cc=david.amouyal@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeremie.nikaes@ensimag.imag.fr \
--cc=jrnieder@gmail.com \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=sylvain.boulme@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.