Re: [PATCH v6] Add a remote helper to interact with mediawiki (fetch & push)

From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
	git@vger.kernel.org,
	Jeremie Nikaes <jeremie.nikaes@ensimag.imag.fr>,
	Arnaud Lacurie <arnaud.lacurie@ensimag.imag.fr>,
	Claire Fousse <claire.fousse@ensimag.imag.fr>,
	David Amouyal <david.amouyal@ensimag.imag.fr>
Subject: Re: [PATCH v6] Add a remote helper to interact with mediawiki (fetch & push)
Date: Thu, 01 Sep 2011 07:26:05 +0200	[thread overview]
Message-ID: <vpq39ggomtu.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vobz5xg7u.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 31 Aug 2011 17:24:05 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Here:
>>
>> +	for my $refspec (@refsspecs) {
>> +		unless ($refspec =~ m/^(\+?)([^:]*):([^:]*)$/) {
>> +			die("Invalid refspec for push. Expected <src>:<dst> or +<src>:<dst>");
>> +		}
>> +		my ($force, $local, $remote) = ($1 eq "+", $2, $3);
>>
>> At this point, $force is a boolean saying whether there were a +, and
>> $local and $remote are as you can guess.
>
> It may be slightly more Perl-ish to hoist the "0-or-1" outside the group
> and rely on $1 becoming undef, like this:
>
>         my ($force, $local, $remote) = $refspec =~ /^(\+)?([^:]*):([^:]*)$/
> 		or die(...);

Thanks, I didn't know I could do this.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/