* [Buildroot] [PATCH v3] faifa: new package
@ 2014-05-28 13:39 Maxime Hadjinlian
2014-06-08 16:34 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Hadjinlian @ 2014-05-28 13:39 UTC (permalink / raw)
To: buildroot
faifa is a library and a cli used to manage PLC hardware that use
Intellon chipset.
Almost everybody use theses chips nowadays.
Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
Changes v2 -> v3:
- Do not use AUTORECONF, uses autogen.sh instead
Changes v1 -> v2:
- Changes version from master to a sha1
---
package/Config.in | 1 +
package/faifa/Config.in | 11 +++++++++++
package/faifa/faifa.mk | 35 +++++++++++++++++++++++++++++++++++
3 files changed, 47 insertions(+)
create mode 100644 package/faifa/Config.in
create mode 100644 package/faifa/faifa.mk
diff --git a/package/Config.in b/package/Config.in
index 3bc8d24..68406e8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -913,6 +913,7 @@ source "package/dnsmasq/Config.in"
source "package/dropbear/Config.in"
source "package/ebtables/Config.in"
source "package/ethtool/Config.in"
+source "package/faifa/Config.in"
source "package/foomatic-filters/Config.in"
source "package/fping/Config.in"
source "package/gesftpserver/Config.in"
diff --git a/package/faifa/Config.in b/package/faifa/Config.in
new file mode 100644
index 0000000..99abaab
--- /dev/null
+++ b/package/faifa/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_FAIFA
+ bool "faifa"
+ select BR2_PACKAGE_LIBPCAP
+ help
+ Faifa can configure any Intellon-based Power Line Communication device
+ using Intellon INT5000 and INT6000 series chips (6000 and 6300 chips). It
+ supports all Intellon-specific management and control frames as well as
+ standard management frames.
+
+ https://dev.open-plc.org
+
diff --git a/package/faifa/faifa.mk b/package/faifa/faifa.mk
new file mode 100644
index 0000000..4435802
--- /dev/null
+++ b/package/faifa/faifa.mk
@@ -0,0 +1,35 @@
+################################################################################
+#
+# faifa
+#
+################################################################################
+
+FAIFA_VERSION = aa0b5f90b89a9fd1533137b68ebf85f5437aba53
+FAIFA_SITE = $(call github,ffainelli,faifa,$(FAIFA_VERSION))
+FAIFA_INSTALL_STAGING = YES
+FAIFA_DEPENDENCIES = libpcap
+FAIFA_LICENSE = GPLv2
+FAIFA_LICENSE_FILES = COPYING
+
+define FAIFA_RUN_AUTOGEN
+ cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef
+FAIFA_PRE_CONFIGURE_HOOKS += FAIFA_RUN_AUTOGEN
+
+define FAIFA_INSTALL_TARGET_CMDS
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+ PREFIX=/usr \
+ STRIP=/bin/true \
+ DESTDIR=$(TARGET_DIR) \
+ install
+endef
+
+define FAIFA_INSTALL_STAGING_CMDS
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+ PREFIX=/usr \
+ STRIP=/bin/true \
+ DESTDIR=$(STAGING_DIR) \
+ install
+endef
+
+$(eval $(autotools-package))
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3] faifa: new package
2014-05-28 13:39 [Buildroot] [PATCH v3] faifa: new package Maxime Hadjinlian
@ 2014-06-08 16:34 ` Thomas Petazzoni
2014-06-08 17:08 ` Samuel Martin
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-06-08 16:34 UTC (permalink / raw)
To: buildroot
Dear Maxime Hadjinlian,
On Wed, 28 May 2014 15:39:06 +0200, Maxime Hadjinlian wrote:
> diff --git a/package/faifa/Config.in b/package/faifa/Config.in
> new file mode 100644
> index 0000000..99abaab
> --- /dev/null
> +++ b/package/faifa/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_FAIFA
> + bool "faifa"
> + select BR2_PACKAGE_LIBPCAP
> + help
> + Faifa can configure any Intellon-based Power Line Communication device
> + using Intellon INT5000 and INT6000 series chips (6000 and 6300 chips). It
> + supports all Intellon-specific management and control frames as well as
> + standard management frames.
These lines are too long and had to be wrapped to a shorter length.
I had to add a !BR2_PREFER_STATIC_LIB dependency, because this package
always builds a shared library.
> +FAIFA_VERSION = aa0b5f90b89a9fd1533137b68ebf85f5437aba53
> +FAIFA_SITE = $(call github,ffainelli,faifa,$(FAIFA_VERSION))
> +FAIFA_INSTALL_STAGING = YES
> +FAIFA_DEPENDENCIES = libpcap
> +FAIFA_LICENSE = GPLv2
GPLv2+.
> +FAIFA_LICENSE_FILES = COPYING
> +
> +define FAIFA_RUN_AUTOGEN
> + cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> +endef
> +FAIFA_PRE_CONFIGURE_HOOKS += FAIFA_RUN_AUTOGEN
I've added a comment above this to explain what's going on, and added
the missing host-autoconf dependency.
> +
> +define FAIFA_INSTALL_TARGET_CMDS
> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> + PREFIX=/usr \
> + STRIP=/bin/true \
> + DESTDIR=$(TARGET_DIR) \
> + install
> +endef
> +
> +define FAIFA_INSTALL_STAGING_CMDS
> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> + PREFIX=/usr \
> + STRIP=/bin/true \
> + DESTDIR=$(STAGING_DIR) \
> + install
> +endef
The indentation was wrong, it should use tabs.
Committed with those issues fixed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3] faifa: new package
2014-06-08 16:34 ` Thomas Petazzoni
@ 2014-06-08 17:08 ` Samuel Martin
2014-06-08 17:16 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Samuel Martin @ 2014-06-08 17:08 UTC (permalink / raw)
To: buildroot
Maxime, Thomas, all,
On Sun, Jun 8, 2014 at 6:34 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Maxime Hadjinlian,
>
> On Wed, 28 May 2014 15:39:06 +0200, Maxime Hadjinlian wrote:
>
>> diff --git a/package/faifa/Config.in b/package/faifa/Config.in
>> new file mode 100644
>> index 0000000..99abaab
>> --- /dev/null
>> +++ b/package/faifa/Config.in
>> @@ -0,0 +1,11 @@
>> +config BR2_PACKAGE_FAIFA
>> + bool "faifa"
>> + select BR2_PACKAGE_LIBPCAP
>> + help
>> + Faifa can configure any Intellon-based Power Line Communication device
>> + using Intellon INT5000 and INT6000 series chips (6000 and 6300 chips). It
>> + supports all Intellon-specific management and control frames as well as
>> + standard management frames.
>
> These lines are too long and had to be wrapped to a shorter length.
>
> I had to add a !BR2_PREFER_STATIC_LIB dependency, because this package
> always builds a shared library.
>
>
>> +FAIFA_VERSION = aa0b5f90b89a9fd1533137b68ebf85f5437aba53
>> +FAIFA_SITE = $(call github,ffainelli,faifa,$(FAIFA_VERSION))
>> +FAIFA_INSTALL_STAGING = YES
>> +FAIFA_DEPENDENCIES = libpcap
>> +FAIFA_LICENSE = GPLv2
>
> GPLv2+.
>
>> +FAIFA_LICENSE_FILES = COPYING
>> +
>> +define FAIFA_RUN_AUTOGEN
>> + cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
>> +endef
>> +FAIFA_PRE_CONFIGURE_HOOKS += FAIFA_RUN_AUTOGEN
>
> I've added a comment above this to explain what's going on, and added
> the missing host-autoconf dependency.
>
>> +
>> +define FAIFA_INSTALL_TARGET_CMDS
>> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> + PREFIX=/usr \
>> + STRIP=/bin/true \
>> + DESTDIR=$(TARGET_DIR) \
>> + install
>> +endef
>> +
>> +define FAIFA_INSTALL_STAGING_CMDS
>> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> + PREFIX=/usr \
>> + STRIP=/bin/true \
>> + DESTDIR=$(STAGING_DIR) \
>> + install
>> +endef
Just nit and late, but why do you need override the whole commands?
All of this could have been set in the FAIFA_INSTALL_TARGET_OPT
variable (respectively in FAIFA_INSTALL_STAGING_OPT):
FAIFA_INSTALL_TARGET_OPT = \
PREFIX=/usr \
STRIP=/bin/true \
DESTDIR=$(TARGET_DIR) \
install
Just nitpicking ;-)
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3] faifa: new package
2014-06-08 17:08 ` Samuel Martin
@ 2014-06-08 17:16 ` Thomas Petazzoni
2014-06-08 18:54 ` Maxime Hadjinlian
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-06-08 17:16 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sun, 8 Jun 2014 19:08:32 +0200, Samuel Martin wrote:
> Just nit and late, but why do you need override the whole commands?
> All of this could have been set in the FAIFA_INSTALL_TARGET_OPT
> variable (respectively in FAIFA_INSTALL_STAGING_OPT):
>
> FAIFA_INSTALL_TARGET_OPT = \
> PREFIX=/usr \
> STRIP=/bin/true \
> DESTDIR=$(TARGET_DIR) \
> install
>
> Just nitpicking ;-)
True. I believe it doesn't make a lot of difference in terms of code
factorization, so to me, both solutions are almost equivalent.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3] faifa: new package
2014-06-08 17:16 ` Thomas Petazzoni
@ 2014-06-08 18:54 ` Maxime Hadjinlian
0 siblings, 0 replies; 5+ messages in thread
From: Maxime Hadjinlian @ 2014-06-08 18:54 UTC (permalink / raw)
To: buildroot
Hi Thomas, Samuel,
Thanks a lot for your fixes.
On Sun, Jun 8, 2014 at 7:16 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Samuel Martin,
>
> On Sun, 8 Jun 2014 19:08:32 +0200, Samuel Martin wrote:
>
>> Just nit and late, but why do you need override the whole commands?
>> All of this could have been set in the FAIFA_INSTALL_TARGET_OPT
>> variable (respectively in FAIFA_INSTALL_STAGING_OPT):
>>
>> FAIFA_INSTALL_TARGET_OPT = \
>> PREFIX=/usr \
>> STRIP=/bin/true \
>> DESTDIR=$(TARGET_DIR) \
>> install
>>
>> Just nitpicking ;-)
>
> True. I believe it doesn't make a lot of difference in terms of code
> factorization, so to me, both solutions are almost equivalent.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-08 18:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-28 13:39 [Buildroot] [PATCH v3] faifa: new package Maxime Hadjinlian
2014-06-08 16:34 ` Thomas Petazzoni
2014-06-08 17:08 ` Samuel Martin
2014-06-08 17:16 ` Thomas Petazzoni
2014-06-08 18:54 ` Maxime Hadjinlian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.