[PATCH] bb.fetch2.svn: correctly pass workdir when fetching

[PATCH] bb.fetch2.svn: correctly pass workdir when fetching

[Christopher Larson]

From: Christopher Larson <chris_larson@mentor.com>

The ud.pkgdir argument was being passed as the 'quiet' argument to
runfetchcmd, not the 'workdir' argument, resulting in fetching the svn module
into the root of DL_DIR, not where it belongs.

Cc: Matt Madison <matt@madison.systems>
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 lib/bb/fetch2/svn.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bb/fetch2/svn.py b/lib/bb/fetch2/svn.py
index 9ff9410..6ca79d3 100644
--- a/lib/bb/fetch2/svn.py
+++ b/lib/bb/fetch2/svn.py
@@ -141,7 +141,7 @@ class Svn(FetchMethod):
             bb.utils.mkdirhier(ud.pkgdir)
             logger.debug(1, "Running %s", svnfetchcmd)
             bb.fetch2.check_network_access(d, svnfetchcmd, ud.url)
-            runfetchcmd(svnfetchcmd, d, ud.pkgdir)
+            runfetchcmd(svnfetchcmd, d, workdir=ud.pkgdir)
 
         scmdata = ud.parm.get("scmdata", "")
         if scmdata == "keep":
-- 
2.8.0

Re: [PATCH] bb.fetch2.svn: correctly pass workdir when fetching

[Matt Madison]

Thanks.  I think that's the only instance I missed.

-Matt

On Wed, Aug 31, 2016 at 12:57 PM, Christopher Larson <kergoth@gmail.com> wrote:
> From: Christopher Larson <chris_larson@mentor.com>
>
> The ud.pkgdir argument was being passed as the 'quiet' argument to
> runfetchcmd, not the 'workdir' argument, resulting in fetching the svn module
> into the root of DL_DIR, not where it belongs.
>
> Cc: Matt Madison <matt@madison.systems>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>  lib/bb/fetch2/svn.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/bb/fetch2/svn.py b/lib/bb/fetch2/svn.py
> index 9ff9410..6ca79d3 100644
> --- a/lib/bb/fetch2/svn.py
> +++ b/lib/bb/fetch2/svn.py
> @@ -141,7 +141,7 @@ class Svn(FetchMethod):
>              bb.utils.mkdirhier(ud.pkgdir)
>              logger.debug(1, "Running %s", svnfetchcmd)
>              bb.fetch2.check_network_access(d, svnfetchcmd, ud.url)
> -            runfetchcmd(svnfetchcmd, d, ud.pkgdir)
> +            runfetchcmd(svnfetchcmd, d, workdir=ud.pkgdir)
>
>          scmdata = ud.parm.get("scmdata", "")
>          if scmdata == "keep":
> --
> 2.8.0
>