All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB
@ 2021-05-17 22:40 Marek Vasut
  2021-05-18  7:37 ` Oleksandr Suvorov
  2021-06-09 13:44 ` sbabic
  0 siblings, 2 replies; 5+ messages in thread
From: Marek Vasut @ 2021-05-17 22:40 UTC (permalink / raw)
  To: u-boot

Uncompressed aarch64 kernel Image are rather large, increase the bootm
size limit to 64 MiB to cater for that.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Max Krummenacher <max.krummenacher@toradex.com>
Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
 include/configs/verdin-imx8mm.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
index e2a817891c2..7be5e5ddf11 100644
--- a/include/configs/verdin-imx8mm.h
+++ b/include/configs/verdin-imx8mm.h
@@ -16,6 +16,8 @@
 #define CONFIG_SYS_UBOOT_BASE	\
 	(QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512)
 
+#define CONFIG_SYS_BOOTM_LEN           SZ_64M
+
 #ifdef CONFIG_SPL_BUILD
 #define CONFIG_SPL_STACK		0x920000
 #define CONFIG_SPL_BSS_START_ADDR	0x910000
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB
  2021-05-17 22:40 [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB Marek Vasut
@ 2021-05-18  7:37 ` Oleksandr Suvorov
  2021-05-18  8:45   ` Marek Vasut
  2021-06-09 13:44 ` sbabic
  1 sibling, 1 reply; 5+ messages in thread
From: Oleksandr Suvorov @ 2021-05-18  7:37 UTC (permalink / raw)
  To: u-boot

On Tue, May 18, 2021 at 1:40 AM Marek Vasut <marex@denx.de> wrote:
>
> Uncompressed aarch64 kernel Image are rather large, increase the bootm
> size limit to 64 MiB to cater for that.
>
> Signed-off-by: Marek Vasut <marex@denx.de>

Marek, thanks for your fix!

There is a typo in the comment message:
"kernel Image are rather large" probably should be either "kernel
Images are rather large" or "kernel Image is rather large".

With that:
Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Max Krummenacher <max.krummenacher@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
>  include/configs/verdin-imx8mm.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
> index e2a817891c2..7be5e5ddf11 100644
> --- a/include/configs/verdin-imx8mm.h
> +++ b/include/configs/verdin-imx8mm.h
> @@ -16,6 +16,8 @@
>  #define CONFIG_SYS_UBOOT_BASE  \
>         (QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512)
>
> +#define CONFIG_SYS_BOOTM_LEN           SZ_64M
> +
>  #ifdef CONFIG_SPL_BUILD
>  #define CONFIG_SPL_STACK               0x920000
>  #define CONFIG_SPL_BSS_START_ADDR      0x910000
> --
> 2.30.2
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Ebenaustrasse 10 | 6048 Horw | Switzerland | T: +41 41 500 48 00

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB
  2021-05-18  7:37 ` Oleksandr Suvorov
@ 2021-05-18  8:45   ` Marek Vasut
  2021-05-18  9:27     ` Oleksandr Suvorov
  0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2021-05-18  8:45 UTC (permalink / raw)
  To: u-boot

On 5/18/21 9:37 AM, Oleksandr Suvorov wrote:
> On Tue, May 18, 2021 at 1:40 AM Marek Vasut <marex@denx.de> wrote:
>>
>> Uncompressed aarch64 kernel Image are rather large, increase the bootm
>> size limit to 64 MiB to cater for that.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> Marek, thanks for your fix!
> 
> There is a typo in the comment message:
> "kernel Image are rather large" probably should be either "kernel
> Images are rather large" or "kernel Image is rather large".

The Image is the filename (aarch64 image) and it is plural, so I think 
its neither of the options.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB
  2021-05-18  8:45   ` Marek Vasut
@ 2021-05-18  9:27     ` Oleksandr Suvorov
  0 siblings, 0 replies; 5+ messages in thread
From: Oleksandr Suvorov @ 2021-05-18  9:27 UTC (permalink / raw)
  To: u-boot

On Tue, May 18, 2021 at 11:45 AM Marek Vasut <marex@denx.de> wrote:
>
> On 5/18/21 9:37 AM, Oleksandr Suvorov wrote:
> > On Tue, May 18, 2021 at 1:40 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> Uncompressed aarch64 kernel Image are rather large, increase the bootm
> >> size limit to 64 MiB to cater for that.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >
> > Marek, thanks for your fix!
> >
> > There is a typo in the comment message:
> > "kernel Image are rather large" probably should be either "kernel
> > Images are rather large" or "kernel Image is rather large".
>
> The Image is the filename (aarch64 image) and it is plural, so I think
> its neither of the options.

Oh, I didn't notice the capital letter "I" :) Sorry about that.
Reviewed w/o conditions :)


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Ebenaustrasse 10 | 6048 Horw | Switzerland | T: +41 41 500 48 00

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB
  2021-05-17 22:40 [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB Marek Vasut
  2021-05-18  7:37 ` Oleksandr Suvorov
@ 2021-06-09 13:44 ` sbabic
  1 sibling, 0 replies; 5+ messages in thread
From: sbabic @ 2021-06-09 13:44 UTC (permalink / raw)
  To: Marek Vasut, U-Boot

> Uncompressed aarch64 kernel Image are rather large, increase the bootm
> size limit to 64 MiB to cater for that.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Max Krummenacher <max.krummenacher@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-09 13:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 22:40 [PATCH] ARM: imx8m: verdin-imx8mm: Increase bootm size to 64 MiB Marek Vasut
2021-05-18  7:37 ` Oleksandr Suvorov
2021-05-18  8:45   ` Marek Vasut
2021-05-18  9:27     ` Oleksandr Suvorov
2021-06-09 13:44 ` sbabic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.