sfc: Fix reading non-legacy supported link modes

sfc: Fix reading non-legacy supported link modes

[Erik Ekman]

Upstream commit 041c61488236a5a84789083e3d9f0a51139b6edf

Initially this just fixed 50G and 100G modes which felt rare enough to
not apply this to stable (also it got merged before I really had
thought about it).

The testing mentioned in the change was actually from my development
of c62041c5ba ("sfc: Export fibre-specific supported link modes"). I
failed to mention the link between the two changes however and this
commit ended up in net-next (just merged) while the second ended up in
5.15 via the net branch. The result is that for 5.15 even 10G cards
only show 1G as supported:

$ ethtool ext
    Settings for ext:
    Supported ports: [ FIBRE ]
    Supported link modes:   1000baseT/Full
    Supported pause frame use: Symmetric Receive-only
[..]

So this commit is needed at least for 5.15 to fix that.

Fixes:  c62041c5ba ("sfc: Export fibre-specific supported link modes")

It can also be applied further back if we want to fix the 50/100G
modes (from v4.16 I believe):

Fixes: 5abb5e7f916 ("sfc: add bits for 25/50/100G supported/advertised speeds")

Thanks/
Erik

Re: sfc: Fix reading non-legacy supported link modes

[Greg KH]

On Tue, Nov 02, 2021 at 09:58:22PM +0100, Erik Ekman wrote:
> Upstream commit 041c61488236a5a84789083e3d9f0a51139b6edf
> 
> Initially this just fixed 50G and 100G modes which felt rare enough to
> not apply this to stable (also it got merged before I really had
> thought about it).
> 
> The testing mentioned in the change was actually from my development
> of c62041c5ba ("sfc: Export fibre-specific supported link modes"). I
> failed to mention the link between the two changes however and this
> commit ended up in net-next (just merged) while the second ended up in
> 5.15 via the net branch. The result is that for 5.15 even 10G cards
> only show 1G as supported:
> 
> $ ethtool ext
>     Settings for ext:
>     Supported ports: [ FIBRE ]
>     Supported link modes:   1000baseT/Full
>     Supported pause frame use: Symmetric Receive-only
> [..]
> 
> So this commit is needed at least for 5.15 to fix that.
> 
> Fixes:  c62041c5ba ("sfc: Export fibre-specific supported link modes")
> 
> It can also be applied further back if we want to fix the 50/100G
> modes (from v4.16 I believe):
> 
> Fixes: 5abb5e7f916 ("sfc: add bits for 25/50/100G supported/advertised speeds")

I have queued this up for 5.10.y, 5.14.y, and 5.15.y now, but I need a
backported version for 5.4.y and 4.19.y please.

thanks,

greg k-h

Re: sfc: Fix reading non-legacy supported link modes

[Erik Ekman]

On Wed, 3 Nov 2021 at 10:41, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Nov 02, 2021 at 09:58:22PM +0100, Erik Ekman wrote:
> > Upstream commit 041c61488236a5a84789083e3d9f0a51139b6edf
> >
> > Initially this just fixed 50G and 100G modes which felt rare enough to
> > not apply this to stable (also it got merged before I really had
> > thought about it).
> >
> > The testing mentioned in the change was actually from my development
> > of c62041c5ba ("sfc: Export fibre-specific supported link modes"). I
> > failed to mention the link between the two changes however and this
> > commit ended up in net-next (just merged) while the second ended up in
> > 5.15 via the net branch. The result is that for 5.15 even 10G cards
> > only show 1G as supported:
> >
> > $ ethtool ext
> >     Settings for ext:
> >     Supported ports: [ FIBRE ]
> >     Supported link modes:   1000baseT/Full
> >     Supported pause frame use: Symmetric Receive-only
> > [..]
> >
> > So this commit is needed at least for 5.15 to fix that.
> >
> > Fixes:  c62041c5ba ("sfc: Export fibre-specific supported link modes")
> >
> > It can also be applied further back if we want to fix the 50/100G
> > modes (from v4.16 I believe):
> >
> > Fixes: 5abb5e7f916 ("sfc: add bits for 25/50/100G supported/advertised speeds")
>
> I have queued this up for 5.10.y, 5.14.y, and 5.15.y now, but I need a
> backported version for 5.4.y and 4.19.y please.

Thank you! I sent the backported patch in another thread. (Plus some
noise, git send-email is hard)

/Erik