* [PATCH] net: gem: Disable broadcast setting
@ 2021-10-15 13:03 Michal Simek
2021-10-16 18:25 ` Ramon Fried
2021-10-21 6:54 ` Michal Simek
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2021-10-15 13:03 UTC (permalink / raw)
To: u-boot, git; +Cc: Joe Hershberger, Ramon Fried
There is no need for GEM to accepts broadcast packets because they are not
handled by u-boot anyway. That's why use HW IP feature and don't waste time
on these packats which will be dropped anyway.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/net/zynq_gem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index ff599822673c..c309c3c95499 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -60,6 +60,7 @@
#define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */
#define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */
#define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */
+#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */
#define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */
#define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */
#define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */
@@ -77,6 +78,7 @@
#define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \
ZYNQ_GEM_NWCFG_FDEN | \
+ ZYNQ_GEM_NWCFG_NO_BRDC | \
ZYNQ_GEM_NWCFG_FSREM | \
ZYNQ_GEM_NWCFG_MDCCLKDIV)
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: gem: Disable broadcast setting
2021-10-15 13:03 [PATCH] net: gem: Disable broadcast setting Michal Simek
@ 2021-10-16 18:25 ` Ramon Fried
2021-10-21 6:54 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Ramon Fried @ 2021-10-16 18:25 UTC (permalink / raw)
To: Michal Simek; +Cc: U-Boot Mailing List, git, Joe Hershberger
On Fri, Oct 15, 2021 at 4:03 PM Michal Simek <michal.simek@xilinx.com> wrote:
>
> There is no need for GEM to accepts broadcast packets because they are not
> handled by u-boot anyway. That's why use HW IP feature and don't waste time
> on these packats which will be dropped anyway.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/net/zynq_gem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index ff599822673c..c309c3c95499 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -60,6 +60,7 @@
> #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */
> #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */
> #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */
> +#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */
> #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */
> #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */
> #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */
> @@ -77,6 +78,7 @@
>
> #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \
> ZYNQ_GEM_NWCFG_FDEN | \
> + ZYNQ_GEM_NWCFG_NO_BRDC | \
> ZYNQ_GEM_NWCFG_FSREM | \
> ZYNQ_GEM_NWCFG_MDCCLKDIV)
>
> --
> 2.33.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: gem: Disable broadcast setting
2021-10-15 13:03 [PATCH] net: gem: Disable broadcast setting Michal Simek
2021-10-16 18:25 ` Ramon Fried
@ 2021-10-21 6:54 ` Michal Simek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2021-10-21 6:54 UTC (permalink / raw)
To: Michal Simek, u-boot, git; +Cc: Joe Hershberger, Ramon Fried
On 10/15/21 15:03, Michal Simek wrote:
> There is no need for GEM to accepts broadcast packets because they are not
> handled by u-boot anyway. That's why use HW IP feature and don't waste time
> on these packats which will be dropped anyway.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/net/zynq_gem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index ff599822673c..c309c3c95499 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -60,6 +60,7 @@
> #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */
> #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */
> #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */
> +#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */
> #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */
> #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */
> #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */
> @@ -77,6 +78,7 @@
>
> #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \
> ZYNQ_GEM_NWCFG_FDEN | \
> + ZYNQ_GEM_NWCFG_NO_BRDC | \
> ZYNQ_GEM_NWCFG_FSREM | \
> ZYNQ_GEM_NWCFG_MDCCLKDIV)
>
>
Applied.
M
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-21 6:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 13:03 [PATCH] net: gem: Disable broadcast setting Michal Simek
2021-10-16 18:25 ` Ramon Fried
2021-10-21 6:54 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.