All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN
@ 2021-03-30 12:34 Patrick Delaunay
  2021-03-30 14:12 ` Marek Vasut
  0 siblings, 1 reply; 5+ messages in thread
From: Patrick Delaunay @ 2021-03-30 12:34 UTC (permalink / raw)
  To: u-boot

Remove the define EQOS_DESCRIPTOR_ALIGN unused since the
commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size")

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 drivers/net/dwc_eth_qos.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index e8242ca4e1..0b1e95e98b 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -240,8 +240,6 @@ struct eqos_tegra186_regs {
 #define EQOS_AUTO_CAL_STATUS_ACTIVE			BIT(31)
 
 /* Descriptors */
-/* We assume ARCH_DMA_MINALIGN >= 16; 16 is the EQOS HW minimum */
-#define EQOS_DESCRIPTOR_ALIGN	ARCH_DMA_MINALIGN
 #define EQOS_DESCRIPTORS_TX	4
 #define EQOS_DESCRIPTORS_RX	4
 #define EQOS_DESCRIPTORS_NUM	(EQOS_DESCRIPTORS_TX + EQOS_DESCRIPTORS_RX)
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN
  2021-03-30 12:34 [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN Patrick Delaunay
@ 2021-03-30 14:12 ` Marek Vasut
  2021-03-31 14:43   ` Ramon Fried
  0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2021-03-30 14:12 UTC (permalink / raw)
  To: u-boot

On 3/30/21 2:34 PM, Patrick Delaunay wrote:
> Remove the define EQOS_DESCRIPTOR_ALIGN unused since the
> commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size")
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Acked-by: Marek Vasut <marex@denx.de>

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN
  2021-03-30 14:12 ` Marek Vasut
@ 2021-03-31 14:43   ` Ramon Fried
  2021-07-05 17:50     ` Patrick DELAUNAY
  0 siblings, 1 reply; 5+ messages in thread
From: Ramon Fried @ 2021-03-31 14:43 UTC (permalink / raw)
  To: u-boot

On Tue, Mar 30, 2021 at 5:12 PM Marek Vasut <marex@denx.de> wrote:
>
> On 3/30/21 2:34 PM, Patrick Delaunay wrote:
> > Remove the define EQOS_DESCRIPTOR_ALIGN unused since the
> > commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size")
> >
> > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> Thanks
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN
  2021-03-31 14:43   ` Ramon Fried
@ 2021-07-05 17:50     ` Patrick DELAUNAY
  2021-07-06  2:24       ` Ramon Fried
  0 siblings, 1 reply; 5+ messages in thread
From: Patrick DELAUNAY @ 2021-07-05 17:50 UTC (permalink / raw)
  To: Ramon Fried
  Cc: U-Boot Mailing List, Joe Hershberger, U-Boot STM32, Marek Vasut,
	Patrice CHOTARD

Hi Ramon,

On 3/31/21 4:43 PM, Ramon Fried wrote:
> On Tue, Mar 30, 2021 at 5:12 PM Marek Vasut <marex@denx.de> wrote:
>> On 3/30/21 2:34 PM, Patrick Delaunay wrote:
>>> Remove the define EQOS_DESCRIPTOR_ALIGN unused since the
>>> commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size")
>>>
>>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Acked-by: Marek Vasut <marex@denx.de>
>>
>> Thanks
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
It seens this patch is not applied on u-boot-net/network_master or on 
u-boot/next

even if it is accepted in patchwork.

http://patchwork.ozlabs.org/project/uboot/patch/20210330143429.1.I654d7aeb07f9cd0602752861d06f4c17e9a0ee17@changeid/


Any reason ?

or it is just a error in patchwork and the patch is forgotten...


best regards.

Patrick





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN
  2021-07-05 17:50     ` Patrick DELAUNAY
@ 2021-07-06  2:24       ` Ramon Fried
  0 siblings, 0 replies; 5+ messages in thread
From: Ramon Fried @ 2021-07-06  2:24 UTC (permalink / raw)
  To: Patrick DELAUNAY
  Cc: U-Boot Mailing List, Joe Hershberger, U-Boot STM32, Marek Vasut,
	Patrice CHOTARD

On Mon, Jul 5, 2021 at 8:50 PM Patrick DELAUNAY
<patrick.delaunay@foss.st.com> wrote:
>
> Hi Ramon,
>
> On 3/31/21 4:43 PM, Ramon Fried wrote:
> > On Tue, Mar 30, 2021 at 5:12 PM Marek Vasut <marex@denx.de> wrote:
> >> On 3/30/21 2:34 PM, Patrick Delaunay wrote:
> >>> Remove the define EQOS_DESCRIPTOR_ALIGN unused since the
> >>> commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size")
> >>>
> >>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> >> Acked-by: Marek Vasut <marex@denx.de>
> >>
> >> Thanks
> > Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
> It seens this patch is not applied on u-boot-net/network_master or on
> u-boot/next
>
> even if it is accepted in patchwork.
>
> http://patchwork.ozlabs.org/project/uboot/patch/20210330143429.1.I654d7aeb07f9cd0602752861d06f4c17e9a0ee17@changeid/
>
>
> Any reason ?
>
> or it is just a error in patchwork and the patch is forgotten...
>
>
> best regards.
>
> Patrick
>
>
>
>
Hi Patrick.
The patch was introduced just a bit before I started maintaining a
tree, up until then the patches were picked by Tom.
I applied it to my tree.
Thanks,
Ramon.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-06  2:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 12:34 [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN Patrick Delaunay
2021-03-30 14:12 ` Marek Vasut
2021-03-31 14:43   ` Ramon Fried
2021-07-05 17:50     ` Patrick DELAUNAY
2021-07-06  2:24       ` Ramon Fried

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.