* [PATCH] net: bootp: Correct VCI string transmission
@ 2021-10-12 11:01 Walter Stoll
2021-10-14 15:10 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Walter Stoll @ 2021-10-12 11:01 UTC (permalink / raw)
To: u-boot; +Cc: Walter Stoll
The VCI string sent during bootp of U-Boot-SPL is corrupt. This is
because the byte counter is not adjusted within the bootp_extended()
function when the VCI string is added. We fix this.
Signed-off-by: Walter Stoll <walter.stoll@duagon.com>
---
net/bootp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bootp.c b/net/bootp.c
index 655b9cceb6..58e30cd6b0 100644
--- a/net/bootp.c
+++ b/net/bootp.c
@@ -647,7 +647,7 @@ static int bootp_extended(u8 *e)
*e++ = (576 - 312 + OPT_FIELD_SIZE) & 0xff;
#endif
- add_vci(e);
+ e = add_vci(e);
#if defined(CONFIG_BOOTP_SUBNETMASK)
*e++ = 1; /* Subnet mask request */
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: bootp: Correct VCI string transmission
2021-10-12 11:01 [PATCH] net: bootp: Correct VCI string transmission Walter Stoll
@ 2021-10-14 15:10 ` Simon Glass
2021-10-28 18:47 ` Ramon Fried
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2021-10-14 15:10 UTC (permalink / raw)
To: Walter Stoll; +Cc: U-Boot Mailing List
On Tue, 12 Oct 2021 at 05:50, Walter Stoll <walter.stoll@duagon.com> wrote:
>
> The VCI string sent during bootp of U-Boot-SPL is corrupt. This is
> because the byte counter is not adjusted within the bootp_extended()
> function when the VCI string is added. We fix this.
>
> Signed-off-by: Walter Stoll <walter.stoll@duagon.com>
> ---
> net/bootp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bootp.c b/net/bootp.c
> index 655b9cceb6..58e30cd6b0 100644
> --- a/net/bootp.c
> +++ b/net/bootp.c
> @@ -647,7 +647,7 @@ static int bootp_extended(u8 *e)
> *e++ = (576 - 312 + OPT_FIELD_SIZE) & 0xff;
> #endif
>
> - add_vci(e);
> + e = add_vci(e);
>
> #if defined(CONFIG_BOOTP_SUBNETMASK)
> *e++ = 1; /* Subnet mask request */
> --
> 2.33.0
>
Reviewed-by: Simon Glass <sjg@chromium.org>
Gosh that add_vci() could use a clean-up
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: bootp: Correct VCI string transmission
2021-10-14 15:10 ` Simon Glass
@ 2021-10-28 18:47 ` Ramon Fried
0 siblings, 0 replies; 3+ messages in thread
From: Ramon Fried @ 2021-10-28 18:47 UTC (permalink / raw)
To: Simon Glass; +Cc: Walter Stoll, U-Boot Mailing List
On Thu, Oct 14, 2021 at 6:13 PM Simon Glass <sjg@chromium.org> wrote:
>
> On Tue, 12 Oct 2021 at 05:50, Walter Stoll <walter.stoll@duagon.com> wrote:
> >
> > The VCI string sent during bootp of U-Boot-SPL is corrupt. This is
> > because the byte counter is not adjusted within the bootp_extended()
> > function when the VCI string is added. We fix this.
> >
> > Signed-off-by: Walter Stoll <walter.stoll@duagon.com>
> > ---
> > net/bootp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/bootp.c b/net/bootp.c
> > index 655b9cceb6..58e30cd6b0 100644
> > --- a/net/bootp.c
> > +++ b/net/bootp.c
> > @@ -647,7 +647,7 @@ static int bootp_extended(u8 *e)
> > *e++ = (576 - 312 + OPT_FIELD_SIZE) & 0xff;
> > #endif
> >
> > - add_vci(e);
> > + e = add_vci(e);
> >
> > #if defined(CONFIG_BOOTP_SUBNETMASK)
> > *e++ = 1; /* Subnet mask request */
> > --
> > 2.33.0
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Gosh that add_vci() could use a clean-up
applied to u-boot-net/next
Thanks,
Ramon.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-28 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 11:01 [PATCH] net: bootp: Correct VCI string transmission Walter Stoll
2021-10-14 15:10 ` Simon Glass
2021-10-28 18:47 ` Ramon Fried
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.