* [PATCH] net: phy: genphy_init can be static
@ 2021-09-18 11:55 Vladimir Oltean
2021-09-18 12:09 ` Bin Meng
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Oltean @ 2021-09-18 11:55 UTC (permalink / raw)
To: u-boot; +Cc: Joe Hershberger, Ramon Fried
To avoid a warning with W=1 about this function not having a previous
prototype, declare it as static, because it is not used outside of this
translation module.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/phy/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 69acb6946061..c9fc20855ba1 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -463,7 +463,7 @@ static struct phy_driver genphy_driver = {
.shutdown = genphy_shutdown,
};
-int genphy_init(void)
+static int genphy_init(void)
{
return phy_register(&genphy_driver);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: genphy_init can be static
2021-09-18 11:55 [PATCH] net: phy: genphy_init can be static Vladimir Oltean
@ 2021-09-18 12:09 ` Bin Meng
2021-09-28 13:28 ` Ramon Fried
0 siblings, 1 reply; 3+ messages in thread
From: Bin Meng @ 2021-09-18 12:09 UTC (permalink / raw)
To: Vladimir Oltean; +Cc: U-Boot Mailing List, Joe Hershberger, Ramon Fried
On Sat, Sep 18, 2021 at 7:55 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> To avoid a warning with W=1 about this function not having a previous
> prototype, declare it as static, because it is not used outside of this
> translation module.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/net/phy/phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: genphy_init can be static
2021-09-18 12:09 ` Bin Meng
@ 2021-09-28 13:28 ` Ramon Fried
0 siblings, 0 replies; 3+ messages in thread
From: Ramon Fried @ 2021-09-28 13:28 UTC (permalink / raw)
To: Bin Meng; +Cc: Vladimir Oltean, U-Boot Mailing List, Joe Hershberger
On Sat, Sep 18, 2021 at 3:09 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Sat, Sep 18, 2021 at 7:55 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> >
> > To avoid a warning with W=1 about this function not having a previous
> > prototype, declare it as static, because it is not used outside of this
> > translation module.
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> > drivers/net/phy/phy.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-28 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-18 11:55 [PATCH] net: phy: genphy_init can be static Vladimir Oltean
2021-09-18 12:09 ` Bin Meng
2021-09-28 13:28 ` Ramon Fried
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.