From: Yegor Yefremov <yegorslists@googlemail.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: netdev <netdev@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: [net PATCH 1/1] drivers: net: cpsw: Add default vlan for dual emac case also
Date: Wed, 9 Apr 2014 15:42:33 +0200 [thread overview]
Message-ID: <CAGm1_ku3Fc=Lh8K17M=PCZT491KP-UvFR0BE6mvb5zrr8ybc9Q@mail.gmail.com> (raw)
In-Reply-To: <1397023480-4181-1-git-send-email-mugunthanvnm@ti.com>
On Wed, Apr 9, 2014 at 8:04 AM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> Dual EMAC works with VLAN segregation of the ports, so default vlan needs
> to be added in dual EMAC case else default vlan will be tagged for all
> egress packets and vlan unaware switches/servers will drop packets
> from the EVM.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> drivers/net/ethernet/ti/cpsw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 5d5fec6..6133e4a 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1201,8 +1201,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
> for_each_slave(priv, cpsw_slave_open, priv);
>
> /* Add default VLAN */
> - if (!priv->data.dual_emac)
> - cpsw_add_default_vlan(priv);
> + cpsw_add_default_vlan(priv);
>
> if (!cpsw_common_res_usage_state(priv)) {
> /* setup tx dma to fixed prio and zero offset */
> --
> 1.9.0
Tested-by: Yegor Yefremov <yegorslists@googlemail.com>
next prev parent reply other threads:[~2014-04-09 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 6:04 [net PATCH 1/1] drivers: net: cpsw: Add default vlan for dual emac case also Mugunthan V N
2014-04-09 13:42 ` Yegor Yefremov [this message]
2014-04-09 18:56 ` David Miller
2014-04-15 13:46 ` Yegor Yefremov
2014-04-16 5:57 ` Mugunthan V N
2014-04-16 13:58 ` Yegor Yefremov
2014-05-02 8:58 ` Yegor Yefremov
2014-05-05 14:20 ` Mugunthan V N
2014-05-19 8:46 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGm1_ku3Fc=Lh8K17M=PCZT491KP-UvFR0BE6mvb5zrr8ybc9Q@mail.gmail.com' \
--to=yegorslists@googlemail.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.