All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] tcping: new package
@ 2013-09-11 15:07 Arnaud Rébillout
  2013-09-12 16:44 ` Thomas Petazzoni
  0 siblings, 1 reply; 8+ messages in thread
From: Arnaud Rébillout @ 2013-09-11 15:07 UTC (permalink / raw)
  To: buildroot

tcping does a TCP connect to the given ip/port combination. The user can
specify a timeout in seconds. This is useful in shell scripts running in
firewalled environments. Often SYNs are just being dropped by firewalls,
thus connection establishment will be retried several times (for
minutes) until a TCP timeout is reached. With tcping it is possible to
check first if the desired port is reachable and then start connection
establishment.

http://www.linuxco.de/tcping/tcping.html
Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
---
 package/Config.in        |  1 +
 package/tcping/Config.in |  7 +++++++
 package/tcping/tcping.mk | 27 +++++++++++++++++++++++++++
 3 files changed, 35 insertions(+)
 create mode 100644 package/tcping/Config.in
 create mode 100644 package/tcping/tcping.mk

diff --git a/package/Config.in b/package/Config.in
index 2351839..fc1ec87 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -854,6 +854,7 @@ source "package/squid/Config.in"
 source "package/strongswan/Config.in"
 source "package/stunnel/Config.in"
 source "package/tcpdump/Config.in"
+source "package/tcping/Config.in"
 source "package/tcpreplay/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/tftpd/Config.in"
diff --git a/package/tcping/Config.in b/package/tcping/Config.in
new file mode 100644
index 0000000..d440c56
--- /dev/null
+++ b/package/tcping/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_TCPING
+	bool "tcping"
+	help
+	  tcping does a TCP connect to the given ip/port combination. 
+
+	  http://www.linuxco.de/tcping/tcping.html
+
diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
new file mode 100644
index 0000000..67bb30a
--- /dev/null
+++ b/package/tcping/tcping.mk
@@ -0,0 +1,27 @@
+#############################################################
+#
+# tcping
+#
+#############################################################
+TCPING_VERSION = 1.3.5
+TCPING_SOURCE = tcping-$(TCPING_VERSION).tar.gz
+TCPING_SITE = http://www.linuxco.de/tcping
+TCPING_LICENSE = GPLv3+
+
+define TCPING_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux
+endef
+
+define TCPING_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/tcping $(TARGET_DIR)/usr/bin/tcping
+endef
+
+define TCPING_UNINSTALL_TARGET_CMDS
+	rm -f $(TARGET_DIR)/usr/bin/tcping
+endef
+
+define TCPING_CLEAN_CMDS
+	-$(MAKE) -C $(@D) clean
+endef
+
+$(eval $(generic-package))
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-11 15:07 [Buildroot] [PATCH] tcping: new package Arnaud Rébillout
@ 2013-09-12 16:44 ` Thomas Petazzoni
  2013-09-13  7:29   ` Arnaud Rébillout
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2013-09-12 16:44 UTC (permalink / raw)
  To: buildroot

Dear Arnaud R?billout,

Thanks for this contribution! A few comments below, if you could fix
them and resend an updated version, that'd be great!

> http://www.linuxco.de/tcping/tcping.html
> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>

First, leave one empty line before the Signed-off-by line.

On Wed, 11 Sep 2013 17:07:57 +0200, Arnaud R?billout wrote:

> diff --git a/package/tcping/Config.in b/package/tcping/Config.in
> new file mode 100644
> index 0000000..d440c56
> --- /dev/null
> +++ b/package/tcping/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_TCPING
> +	bool "tcping"
> +	help
> +	  tcping does a TCP connect to the given ip/port combination. 

I believe you could put here a slightly longer description, such as the
one you've written in your commit log.

> +	  http://www.linuxco.de/tcping/tcping.html
> +
> diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
> new file mode 100644
> index 0000000..67bb30a
> --- /dev/null
> +++ b/package/tcping/tcping.mk
> @@ -0,0 +1,27 @@
> +#############################################################
> +#
> +# tcping
> +#
> +#############################################################

There should be 80 # dashes, and an empty line between this header and
the first variable.

> +TCPING_VERSION = 1.3.5
> +TCPING_SOURCE = tcping-$(TCPING_VERSION).tar.gz

This last line is not needed since it is the default value.

> +TCPING_SITE = http://www.linuxco.de/tcping
> +TCPING_LICENSE = GPLv3+

You should add another line here for the licensing informations:

TCPING_LICENSE_FILES = LICENSE

this will automatically consider the file called 'LICENSE' in the
tcping source tree as the license file.

> +define TCPING_BUILD_CMDS
> +	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux
> +endef

It's quite unfortunate that the Makefile uses the non-standard CCFLAGS
instead of CFLAGS, but ok.

> +define TCPING_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/tcping $(TARGET_DIR)/usr/bin/tcping
> +endef
> +
> +define TCPING_UNINSTALL_TARGET_CMDS
> +	rm -f $(TARGET_DIR)/usr/bin/tcping
> +endef
> +
> +define TCPING_CLEAN_CMDS
> +	-$(MAKE) -C $(@D) clean
> +endef

You can remove the uninstall and clean commands, we are going to remove
them soon.

Other than that, looks good! Thanks again!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-12 16:44 ` Thomas Petazzoni
@ 2013-09-13  7:29   ` Arnaud Rébillout
  2013-09-13  7:31     ` Arnaud Rébillout
  2013-09-13  7:33     ` Arnaud Rébillout
  0 siblings, 2 replies; 8+ messages in thread
From: Arnaud Rébillout @ 2013-09-13  7:29 UTC (permalink / raw)
  To: buildroot

Dear Thomas Petazzoni,

thanks for your feedback, the corrected version will come soon.

Best regards

On 09/12/2013 06:44 PM, Thomas Petazzoni wrote:
> Dear Arnaud R?billout,
>
> Thanks for this contribution! A few comments below, if you could fix
> them and resend an updated version, that'd be great!
>
>> http://www.linuxco.de/tcping/tcping.html
>> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
> First, leave one empty line before the Signed-off-by line.
>
> On Wed, 11 Sep 2013 17:07:57 +0200, Arnaud R?billout wrote:
>
>> diff --git a/package/tcping/Config.in b/package/tcping/Config.in
>> new file mode 100644
>> index 0000000..d440c56
>> --- /dev/null
>> +++ b/package/tcping/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_TCPING
>> +	bool "tcping"
>> +	help
>> +	  tcping does a TCP connect to the given ip/port combination.
> I believe you could put here a slightly longer description, such as the
> one you've written in your commit log.
>
>> +	  http://www.linuxco.de/tcping/tcping.html
>> +
>> diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
>> new file mode 100644
>> index 0000000..67bb30a
>> --- /dev/null
>> +++ b/package/tcping/tcping.mk
>> @@ -0,0 +1,27 @@
>> +#############################################################
>> +#
>> +# tcping
>> +#
>> +#############################################################
> There should be 80 # dashes, and an empty line between this header and
> the first variable.
>
>> +TCPING_VERSION = 1.3.5
>> +TCPING_SOURCE = tcping-$(TCPING_VERSION).tar.gz
> This last line is not needed since it is the default value.
>
>> +TCPING_SITE = http://www.linuxco.de/tcping
>> +TCPING_LICENSE = GPLv3+
> You should add another line here for the licensing informations:
>
> TCPING_LICENSE_FILES = LICENSE
>
> this will automatically consider the file called 'LICENSE' in the
> tcping source tree as the license file.
>
>> +define TCPING_BUILD_CMDS
>> +	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux
>> +endef
> It's quite unfortunate that the Makefile uses the non-standard CCFLAGS
> instead of CFLAGS, but ok.
>
>> +define TCPING_INSTALL_TARGET_CMDS
>> +	$(INSTALL) -D -m 0755 $(@D)/tcping $(TARGET_DIR)/usr/bin/tcping
>> +endef
>> +
>> +define TCPING_UNINSTALL_TARGET_CMDS
>> +	rm -f $(TARGET_DIR)/usr/bin/tcping
>> +endef
>> +
>> +define TCPING_CLEAN_CMDS
>> +	-$(MAKE) -C $(@D) clean
>> +endef
> You can remove the uninstall and clean commands, we are going to remove
> them soon.
>
> Other than that, looks good! Thanks again!
>
> Thomas


-- 
Arnaud R?billout
SYSCOM Instruments SA
rue de l'industrie 21
CH-1450 Sainte-Croix
Switzerland
Tel: +41 (0)24 455 44 11

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-13  7:29   ` Arnaud Rébillout
@ 2013-09-13  7:31     ` Arnaud Rébillout
  2013-09-13  7:33     ` Arnaud Rébillout
  1 sibling, 0 replies; 8+ messages in thread
From: Arnaud Rébillout @ 2013-09-13  7:31 UTC (permalink / raw)
  To: buildroot

tcping does a TCP connect to the given ip/port combination. The user can
specify a timeout in seconds. This is useful in shell scripts running in
firewalled environments. Often SYNs are just being dropped by firewalls,
thus connection establishment will be retried several times (for minutes)
until a TCP timeout is reached. With tcping it is possible to check first
if the desired port is reachable and then start connection establishment.

http://www.linuxco.de/tcping/tcping.html

Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
---
 package/Config.in        |  1 +
 package/tcping/Config.in | 11 +++++++++++
 package/tcping/tcping.mk | 20 ++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/tcping/Config.in
 create mode 100644 package/tcping/tcping.mk

diff --git a/package/Config.in b/package/Config.in
index 2351839..fc1ec87 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -854,6 +854,7 @@ source "package/squid/Config.in"
 source "package/strongswan/Config.in"
 source "package/stunnel/Config.in"
 source "package/tcpdump/Config.in"
+source "package/tcping/Config.in"
 source "package/tcpreplay/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/tftpd/Config.in"
diff --git a/package/tcping/Config.in b/package/tcping/Config.in
new file mode 100644
index 0000000..93cf322
--- /dev/null
+++ b/package/tcping/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_TCPING
+	bool "tcping"
+	help
+	  tcping does a TCP connect to the given ip/port combination. The user can
+	  specify a timeout in seconds. This is useful in shell scripts running in
+	  firewalled environments. Often SYNs are just being dropped by firewalls,
+	  thus connection establishment will be retried several times (for minutes)
+	  until a TCP timeout is reached. With tcping it is possible to check first
+	  if the desired port is reachable and then start connection establishment.
+
+	  http://www.linuxco.de/tcping/tcping.html
diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
new file mode 100644
index 0000000..1472ad4
--- /dev/null
+++ b/package/tcping/tcping.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# tcping
+#
+################################################################################
+
+TCPING_VERSION = 1.3.5
+TCPING_SITE = http://www.linuxco.de/tcping
+TCPING_LICENSE = GPLv3+
+TCPING_LICENSE_FILES = LICENSE
+
+define TCPING_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux
+endef
+
+define TCPING_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/tcping $(TARGET_DIR)/usr/bin/tcping
+endef
+
+$(eval $(generic-package))
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-13  7:29   ` Arnaud Rébillout
  2013-09-13  7:31     ` Arnaud Rébillout
@ 2013-09-13  7:33     ` Arnaud Rébillout
  2013-09-13  9:24       ` Peter Korsgaard
  1 sibling, 1 reply; 8+ messages in thread
From: Arnaud Rébillout @ 2013-09-13  7:33 UTC (permalink / raw)
  To: buildroot

tcping does a TCP connect to the given ip/port combination. The user can
specify a timeout in seconds. This is useful in shell scripts running in
firewalled environments. Often SYNs are just being dropped by firewalls,
thus connection establishment will be retried several times (for minutes)
until a TCP timeout is reached. With tcping it is possible to check first
if the desired port is reachable and then start connection establishment.

http://www.linuxco.de/tcping/tcping.html

Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
---
 package/Config.in        |  1 +
 package/tcping/Config.in | 11 +++++++++++
 package/tcping/tcping.mk | 20 ++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/tcping/Config.in
 create mode 100644 package/tcping/tcping.mk

diff --git a/package/Config.in b/package/Config.in
index 2351839..fc1ec87 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -854,6 +854,7 @@ source "package/squid/Config.in"
 source "package/strongswan/Config.in"
 source "package/stunnel/Config.in"
 source "package/tcpdump/Config.in"
+source "package/tcping/Config.in"
 source "package/tcpreplay/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/tftpd/Config.in"
diff --git a/package/tcping/Config.in b/package/tcping/Config.in
new file mode 100644
index 0000000..93cf322
--- /dev/null
+++ b/package/tcping/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_TCPING
+	bool "tcping"
+	help
+	  tcping does a TCP connect to the given ip/port combination. The user can
+	  specify a timeout in seconds. This is useful in shell scripts running in
+	  firewalled environments. Often SYNs are just being dropped by firewalls,
+	  thus connection establishment will be retried several times (for minutes)
+	  until a TCP timeout is reached. With tcping it is possible to check first
+	  if the desired port is reachable and then start connection establishment.
+
+	  http://www.linuxco.de/tcping/tcping.html
diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
new file mode 100644
index 0000000..1472ad4
--- /dev/null
+++ b/package/tcping/tcping.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# tcping
+#
+################################################################################
+
+TCPING_VERSION = 1.3.5
+TCPING_SITE = http://www.linuxco.de/tcping
+TCPING_LICENSE = GPLv3+
+TCPING_LICENSE_FILES = LICENSE
+
+define TCPING_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux
+endef
+
+define TCPING_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/tcping $(TARGET_DIR)/usr/bin/tcping
+endef
+
+$(eval $(generic-package))
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-13  7:33     ` Arnaud Rébillout
@ 2013-09-13  9:24       ` Peter Korsgaard
  2013-09-13  9:27         ` Arnaud Rébillout
  0 siblings, 1 reply; 8+ messages in thread
From: Peter Korsgaard @ 2013-09-13  9:24 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnaud" == Arnaud R?billout <rebillout@syscom.ch> writes:

Hi,

 Arnaud> tcping does a TCP connect to the given ip/port combination. The user can
 Arnaud> specify a timeout in seconds. This is useful in shell scripts running in
 Arnaud> firewalled environments. Often SYNs are just being dropped by firewalls,
 Arnaud> thus connection establishment will be retried several times (for minutes)
 Arnaud> until a TCP timeout is reached. With tcping it is possible to check first
 Arnaud> if the desired port is reachable and then start connection establishment.

 Arnaud> http://www.linuxco.de/tcping/tcping.html

 Arnaud> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
 Arnaud> ---

Please clearly mark patch version and what you have changed to ease
review. The way to do this is to add the revision after PATCH in subject
(E.G. [PATCHv2]) and to write a small change long here under the ---
line.

 Arnaud>  package/Config.in        |  1 +
 Arnaud>  package/tcping/Config.in | 11 +++++++++++
 Arnaud>  package/tcping/tcping.mk | 20 ++++++++++++++++++++
 Arnaud>  3 files changed, 32 insertions(+)
 Arnaud>  create mode 100644 package/tcping/Config.in
 Arnaud>  create mode 100644 package/tcping/tcping.mk

 Arnaud> diff --git a/package/Config.in b/package/Config.in
 Arnaud> index 2351839..fc1ec87 100644
 Arnaud> --- a/package/Config.in
 Arnaud> +++ b/package/Config.in
 Arnaud> @@ -854,6 +854,7 @@ source "package/squid/Config.in"
 Arnaud>  source "package/strongswan/Config.in"
 Arnaud>  source "package/stunnel/Config.in"
 Arnaud>  source "package/tcpdump/Config.in"
 Arnaud> +source "package/tcping/Config.in"
 Arnaud>  source "package/tcpreplay/Config.in"
 Arnaud>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 Arnaud>  source "package/tftpd/Config.in"
 Arnaud> diff --git a/package/tcping/Config.in b/package/tcping/Config.in
 Arnaud> new file mode 100644
 Arnaud> index 0000000..93cf322
 Arnaud> --- /dev/null
 Arnaud> +++ b/package/tcping/Config.in
 Arnaud> @@ -0,0 +1,11 @@
 Arnaud> +config BR2_PACKAGE_TCPING
 Arnaud> +	bool "tcping"
 Arnaud> +	help
 Arnaud> +	  tcping does a TCP connect to the given ip/port combination. The user can
 Arnaud> +	  specify a timeout in seconds. This is useful in shell scripts running in
 Arnaud> +	  firewalled environments. Often SYNs are just being dropped by firewalls,
 Arnaud> +	  thus connection establishment will be retried several times (for minutes)
 Arnaud> +	  until a TCP timeout is reached. With tcping it is possible to check first
 Arnaud> +	  if the desired port is reachable and then start connection establishment.
 Arnaud> +

The help lines are too long. Please wrap after ~column 70 so it fits
into menuconfig with a normal 80char window.

 Arnaud> +	  http://www.linuxco.de/tcping/tcping.html
 Arnaud> diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
 Arnaud> new file mode 100644
 Arnaud> index 0000000..1472ad4
 Arnaud> --- /dev/null
 Arnaud> +++ b/package/tcping/tcping.mk
 Arnaud> @@ -0,0 +1,20 @@
 Arnaud> +################################################################################
 Arnaud> +#
 Arnaud> +# tcping
 Arnaud> +#
 Arnaud> +################################################################################
 Arnaud> +
 Arnaud> +TCPING_VERSION = 1.3.5
 Arnaud> +TCPING_SITE = http://www.linuxco.de/tcping
 Arnaud> +TCPING_LICENSE = GPLv3+
 Arnaud> +TCPING_LICENSE_FILES = LICENSE
 Arnaud> +
 Arnaud> +define TCPING_BUILD_CMDS
 Arnaud> +	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux

You should also pass TARGET_LDFLAGS. As the Makefile is really simple I
just added it to CCFLAGS.

Committed with these minor fixes, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-13  9:24       ` Peter Korsgaard
@ 2013-09-13  9:27         ` Arnaud Rébillout
  2013-09-13  9:39           ` Yegor Yefremov
  0 siblings, 1 reply; 8+ messages in thread
From: Arnaud Rébillout @ 2013-09-13  9:27 UTC (permalink / raw)
  To: buildroot

Thanks for the recommandation ! I'll keep that in mind for the next patch !

On 09/13/2013 11:24 AM, Peter Korsgaard wrote:
>>>>>> "Arnaud" == Arnaud R?billout <rebillout@syscom.ch> writes:
> Hi,
>
>   Arnaud> tcping does a TCP connect to the given ip/port combination. The user can
>   Arnaud> specify a timeout in seconds. This is useful in shell scripts running in
>   Arnaud> firewalled environments. Often SYNs are just being dropped by firewalls,
>   Arnaud> thus connection establishment will be retried several times (for minutes)
>   Arnaud> until a TCP timeout is reached. With tcping it is possible to check first
>   Arnaud> if the desired port is reachable and then start connection establishment.
>
>   Arnaud> http://www.linuxco.de/tcping/tcping.html
>
>   Arnaud> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
>   Arnaud> ---
>
> Please clearly mark patch version and what you have changed to ease
> review. The way to do this is to add the revision after PATCH in subject
> (E.G. [PATCHv2]) and to write a small change long here under the ---
> line.
>
>   Arnaud>  package/Config.in        |  1 +
>   Arnaud>  package/tcping/Config.in | 11 +++++++++++
>   Arnaud>  package/tcping/tcping.mk | 20 ++++++++++++++++++++
>   Arnaud>  3 files changed, 32 insertions(+)
>   Arnaud>  create mode 100644 package/tcping/Config.in
>   Arnaud>  create mode 100644 package/tcping/tcping.mk
>
>   Arnaud> diff --git a/package/Config.in b/package/Config.in
>   Arnaud> index 2351839..fc1ec87 100644
>   Arnaud> --- a/package/Config.in
>   Arnaud> +++ b/package/Config.in
>   Arnaud> @@ -854,6 +854,7 @@ source "package/squid/Config.in"
>   Arnaud>  source "package/strongswan/Config.in"
>   Arnaud>  source "package/stunnel/Config.in"
>   Arnaud>  source "package/tcpdump/Config.in"
>   Arnaud> +source "package/tcping/Config.in"
>   Arnaud>  source "package/tcpreplay/Config.in"
>   Arnaud>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>   Arnaud>  source "package/tftpd/Config.in"
>   Arnaud> diff --git a/package/tcping/Config.in b/package/tcping/Config.in
>   Arnaud> new file mode 100644
>   Arnaud> index 0000000..93cf322
>   Arnaud> --- /dev/null
>   Arnaud> +++ b/package/tcping/Config.in
>   Arnaud> @@ -0,0 +1,11 @@
>   Arnaud> +config BR2_PACKAGE_TCPING
>   Arnaud> +	bool "tcping"
>   Arnaud> +	help
>   Arnaud> +	  tcping does a TCP connect to the given ip/port combination. The user can
>   Arnaud> +	  specify a timeout in seconds. This is useful in shell scripts running in
>   Arnaud> +	  firewalled environments. Often SYNs are just being dropped by firewalls,
>   Arnaud> +	  thus connection establishment will be retried several times (for minutes)
>   Arnaud> +	  until a TCP timeout is reached. With tcping it is possible to check first
>   Arnaud> +	  if the desired port is reachable and then start connection establishment.
>   Arnaud> +
>
> The help lines are too long. Please wrap after ~column 70 so it fits
> into menuconfig with a normal 80char window.
>
>   Arnaud> +	  http://www.linuxco.de/tcping/tcping.html
>   Arnaud> diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
>   Arnaud> new file mode 100644
>   Arnaud> index 0000000..1472ad4
>   Arnaud> --- /dev/null
>   Arnaud> +++ b/package/tcping/tcping.mk
>   Arnaud> @@ -0,0 +1,20 @@
>   Arnaud> +################################################################################
>   Arnaud> +#
>   Arnaud> +# tcping
>   Arnaud> +#
>   Arnaud> +################################################################################
>   Arnaud> +
>   Arnaud> +TCPING_VERSION = 1.3.5
>   Arnaud> +TCPING_SITE = http://www.linuxco.de/tcping
>   Arnaud> +TCPING_LICENSE = GPLv3+
>   Arnaud> +TCPING_LICENSE_FILES = LICENSE
>   Arnaud> +
>   Arnaud> +define TCPING_BUILD_CMDS
>   Arnaud> +	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux
>
> You should also pass TARGET_LDFLAGS. As the Makefile is really simple I
> just added it to CCFLAGS.
>
> Committed with these minor fixes, thanks.
>


-- 
Arnaud R?billout
SYSCOM Instruments SA
rue de l'industrie 21
CH-1450 Sainte-Croix
Switzerland
Tel: +41 (0)24 455 44 11

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] tcping: new package
  2013-09-13  9:27         ` Arnaud Rébillout
@ 2013-09-13  9:39           ` Yegor Yefremov
  0 siblings, 0 replies; 8+ messages in thread
From: Yegor Yefremov @ 2013-09-13  9:39 UTC (permalink / raw)
  To: buildroot

On Fri, Sep 13, 2013 at 11:27 AM, Arnaud R?billout <rebillout@syscom.ch> wrote:
> Thanks for the recommandation ! I'll keep that in mind for the next patch !

I've written a small howto about working with git and patches:
http://libbits.wordpress.com/2011/12/27/managing-patch-series-with-git/

BR documentation has even more info about this subject:
http://buildroot.uclibc.org/downloads/manual/manual.html#_contributing_to_buildroot

Yegor

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-09-13  9:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-11 15:07 [Buildroot] [PATCH] tcping: new package Arnaud Rébillout
2013-09-12 16:44 ` Thomas Petazzoni
2013-09-13  7:29   ` Arnaud Rébillout
2013-09-13  7:31     ` Arnaud Rébillout
2013-09-13  7:33     ` Arnaud Rébillout
2013-09-13  9:24       ` Peter Korsgaard
2013-09-13  9:27         ` Arnaud Rébillout
2013-09-13  9:39           ` Yegor Yefremov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.