* [Buildroot] [PATCH] fluxbox: select xmodmap
@ 2012-10-16 6:49 yegorslists at googlemail.com
2012-10-16 17:24 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: yegorslists at googlemail.com @ 2012-10-16 6:49 UTC (permalink / raw)
To: buildroot
From: Yegor Yefremov <yegorslists@googlemail.com>
Fluxbox uses xmodmap in its startup script.
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
package/fluxbox/Config.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/package/fluxbox/Config.in b/package/fluxbox/Config.in
index e4d6c37..7a3a255 100644
--- a/package/fluxbox/Config.in
+++ b/package/fluxbox/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_FLUXBOX
depends on BR2_PACKAGE_XORG7
depends on BR2_INSTALL_LIBSTDCPP
select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XAPP_XMODMAP
help
The Fluxbox lightweight window manager for X
--
1.7.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] fluxbox: select xmodmap
2012-10-16 6:49 [Buildroot] [PATCH] fluxbox: select xmodmap yegorslists at googlemail.com
@ 2012-10-16 17:24 ` Thomas Petazzoni
2012-10-16 19:33 ` Yegor Yefremov
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2012-10-16 17:24 UTC (permalink / raw)
To: buildroot
On Tue, 16 Oct 2012 08:49:09 +0200, yegorslists at googlemail.com wrote:
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_FLUXBOX
> depends on BR2_PACKAGE_XORG7
> depends on BR2_INSTALL_LIBSTDCPP
> select BR2_PACKAGE_XLIB_LIBX11
> + select BR2_PACKAGE_XAPP_XMODMAP
> help
> The Fluxbox lightweight window manager for X
When a dependency like this is a runtime dependency, I generally like
to have a short comment on top of it. It's kind of likely that someone
will read fluxbox.mk, not see xmodmap in FLUXBOX_DEPENDENCIES, and
therefore wonder why this "select" is around. For sure, Git history is
here, but I think something like:
# Runtime dependency, needed by startup script
select BR2_PACKAGE_XAPP_XMODMAP
Doesn't harm too much and can be quite useful in the future.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] fluxbox: select xmodmap
2012-10-16 17:24 ` Thomas Petazzoni
@ 2012-10-16 19:33 ` Yegor Yefremov
0 siblings, 0 replies; 3+ messages in thread
From: Yegor Yefremov @ 2012-10-16 19:33 UTC (permalink / raw)
To: buildroot
On Tue, Oct 16, 2012 at 7:24 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> On Tue, 16 Oct 2012 08:49:09 +0200, yegorslists at googlemail.com wrote:
>
>> @@ -3,6 +3,7 @@ config BR2_PACKAGE_FLUXBOX
>> depends on BR2_PACKAGE_XORG7
>> depends on BR2_INSTALL_LIBSTDCPP
>> select BR2_PACKAGE_XLIB_LIBX11
>> + select BR2_PACKAGE_XAPP_XMODMAP
>> help
>> The Fluxbox lightweight window manager for X
>
> When a dependency like this is a runtime dependency, I generally like
> to have a short comment on top of it. It's kind of likely that someone
> will read fluxbox.mk, not see xmodmap in FLUXBOX_DEPENDENCIES, and
> therefore wonder why this "select" is around. For sure, Git history is
> here, but I think something like:
>
> # Runtime dependency, needed by startup script
> select BR2_PACKAGE_XAPP_XMODMAP
>
> Doesn't harm too much and can be quite useful in the future.
O.K. Thanks for review. I will resend the patch.
Yegor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-16 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-16 6:49 [Buildroot] [PATCH] fluxbox: select xmodmap yegorslists at googlemail.com
2012-10-16 17:24 ` Thomas Petazzoni
2012-10-16 19:33 ` Yegor Yefremov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.