[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

[yegorslists at googlemail.com]

From: Yegor Yefremov <yegorslists@googlemail.com>

Depending on how setup.py reads requirements files empty elements can occur.
This patch takes care, that such elements will be ignored and don't crash
the scanpypi script.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 utils/scanpypi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/utils/scanpypi b/utils/scanpypi
index d043135..7392c50 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -299,7 +299,9 @@ class BuildrootPackage():
                         for req in self.pkg_req]
 
         # get rid of commented lines and also strip the package strings
-        self.pkg_req = [item.strip() for item in self.pkg_req if item[0] != '#']
+        print("Req: {}".format(self.pkg_req))
+        self.pkg_req = [item.strip() for item in self.pkg_req
+                        if len(item) > 0 and item[0] != '#']
 
         req_not_found = self.pkg_req
         self.pkg_req = map(pkg_buildroot_name, self.pkg_req)
-- 
2.1.4

[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

[Matthew Weber]

Yegor,

On Tue, Jan 23, 2018 at 2:13 AM,  <yegorslists@googlemail.com> wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Depending on how setup.py reads requirements files empty elements can occur.
> This patch takes care, that such elements will be ignored and don't crash
> the scanpypi script.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

I used this new python package for testing
(https://patchwork.ozlabs.org/patch/864829/)

Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>

[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

[Yegor Yefremov]

On Tue, Jan 23, 2018 at 3:27 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Yegor,
>
> On Tue, Jan 23, 2018 at 2:13 AM,  <yegorslists@googlemail.com> wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> Depending on how setup.py reads requirements files empty elements can occur.
>> This patch takes care, that such elements will be ignored and don't crash
>> the scanpypi script.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> I used this new python package for testing
> (https://patchwork.ozlabs.org/patch/864829/)
>
> Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>

Thanks for testing.

Yegor

[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

[Peter Korsgaard]

>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > Depending on how setup.py reads requirements files empty elements can occur.
 > This patch takes care, that such elements will be ignored and don't crash
 > the scanpypi script.

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
 > ---
 >  utils/scanpypi | 4 +++-
 >  1 file changed, 3 insertions(+), 1 deletion(-)

 > diff --git a/utils/scanpypi b/utils/scanpypi
 > index d043135..7392c50 100755
 > --- a/utils/scanpypi
 > +++ b/utils/scanpypi
 > @@ -299,7 +299,9 @@ class BuildrootPackage():
 >                          for req in self.pkg_req]
 
 >          # get rid of commented lines and also strip the package strings
 > -        self.pkg_req = [item.strip() for item in self.pkg_req if item[0] != '#']
 > +        print("Req: {}".format(self.pkg_req))

What is this print for? Just debugging? Did you mean to add it?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

[Yegor Yefremov]

On Fri, Jan 26, 2018 at 1:43 PM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:
>
>  > From: Yegor Yefremov <yegorslists@googlemail.com>
>  > Depending on how setup.py reads requirements files empty elements can occur.
>  > This patch takes care, that such elements will be ignored and don't crash
>  > the scanpypi script.
>
>  > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>  > ---
>  >  utils/scanpypi | 4 +++-
>  >  1 file changed, 3 insertions(+), 1 deletion(-)
>
>  > diff --git a/utils/scanpypi b/utils/scanpypi
>  > index d043135..7392c50 100755
>  > --- a/utils/scanpypi
>  > +++ b/utils/scanpypi
>  > @@ -299,7 +299,9 @@ class BuildrootPackage():
>  >                          for req in self.pkg_req]
>
>  >          # get rid of commented lines and also strip the package strings
>  > -        self.pkg_req = [item.strip() for item in self.pkg_req if item[0] != '#']
>  > +        print("Req: {}".format(self.pkg_req))
>
> What is this print for? Just debugging? Did you mean to add it?

You're right. It was for debugging. I'll send v2.

Yegor