[Buildroot] [PATCH] boot/uboot: default to kconfig buildsystem for latest version

[Buildroot] [PATCH] boot/uboot: default to kconfig buildsystem for latest version

[Yann E. MORIN]

By default, the builsystem for uboot defaults to 'legacy', while the
default version is very well capable of using the 'kconfig' buildsystem
instead.

Having the 'legacy' buildsystem be the default in that case makes it
quite inconvenient for users: they would expect to be able to use e.g.
uboot-menuconfig et al. with the default uboot version.

Switch to using 'kconfig' when we use the latest version. Keep the
'legacy' as default for everything else.

Also, invert the 'legacy' and 'kconfig' entries in the choice: it is
nicer to have the recent and future-proodf entry first.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 boot/uboot/Config.in | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index b980745d1b..95c17e3986 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -6,20 +6,21 @@ config BR2_TARGET_UBOOT
 if BR2_TARGET_UBOOT
 choice
 	prompt "Build system"
+	default BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG if BR2_TARGET_UBOOT_LATEST_VERSION
 	default BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
 
-config BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
-	bool "Legacy"
-	help
-	  Select this option if you use an old U-Boot (older than
-	  2015.04), so that we use the old build system.
-
 config BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
 	bool "Kconfig"
 	help
 	  Select this option if you use a recent U-Boot version (2015.04
 	  or newer), so that we use the Kconfig build system.
 
+config BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
+	bool "Legacy"
+	help
+	  Select this option if you use an old U-Boot (older than
+	  2015.04), so that we use the old build system.
+
 endchoice
 
 if BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
-- 
2.14.1

[Buildroot] [PATCH] boot/uboot: default to kconfig buildsystem for latest version

[Petr Vorel]

Hi Yann,

> By default, the builsystem for uboot defaults to 'legacy', while the
> default version is very well capable of using the 'kconfig' buildsystem
> instead.

> Having the 'legacy' buildsystem be the default in that case makes it
> quite inconvenient for users: they would expect to be able to use e.g.
> uboot-menuconfig et al. with the default uboot version.

> Switch to using 'kconfig' when we use the latest version. Keep the
> 'legacy' as default for everything else.

> Also, invert the 'legacy' and 'kconfig' entries in the choice: it is
> nicer to have the recent and future-proodf entry first.

> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

Good idea :).

Kind regards,
Petr

[Buildroot] [PATCH] boot/uboot: default to kconfig buildsystem for latest version

[Yegor Yefremov]

On Wed, Apr 25, 2018 at 8:39 AM, Petr Vorel <petr.vorel@gmail.com> wrote:
> Hi Yann,
>
>> By default, the builsystem for uboot defaults to 'legacy', while the
>> default version is very well capable of using the 'kconfig' buildsystem
>> instead.
>
>> Having the 'legacy' buildsystem be the default in that case makes it
>> quite inconvenient for users: they would expect to be able to use e.g.
>> uboot-menuconfig et al. with the default uboot version.
>
>> Switch to using 'kconfig' when we use the latest version. Keep the
>> 'legacy' as default for everything else.
>
>> Also, invert the 'legacy' and 'kconfig' entries in the choice: it is
>> nicer to have the recent and future-proodf entry first.
>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Tested-by: Petr Vorel <petr.vorel@gmail.com>
>
> Good idea :).

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor

[Buildroot] [PATCH] boot/uboot: default to kconfig buildsystem for latest version

[Thomas Petazzoni]

Hello,

On Tue, 24 Apr 2018 18:34:10 +0200, Yann E. MORIN wrote:
> By default, the builsystem for uboot defaults to 'legacy', while the
> default version is very well capable of using the 'kconfig' buildsystem
> instead.
> 
> Having the 'legacy' buildsystem be the default in that case makes it
> quite inconvenient for users: they would expect to be able to use e.g.
> uboot-menuconfig et al. with the default uboot version.
> 
> Switch to using 'kconfig' when we use the latest version. Keep the
> 'legacy' as default for everything else.
> 
> Also, invert the 'legacy' and 'kconfig' entries in the choice: it is
> nicer to have the recent and future-proodf entry first.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  boot/uboot/Config.in | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com