* [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX
@ 2016-03-24 8:03 yegorslists
2016-03-31 5:22 ` Yegor Yefremov
2016-03-31 8:10 ` Matwey V. Kornilov
0 siblings, 2 replies; 3+ messages in thread
From: yegorslists @ 2016-03-24 8:03 UTC (permalink / raw)
To: linux-serial
Cc: gregkh, peter, bigeasy, linux-kernel, u.kleine-koenig,
Yegor Yefremov, Matwey V. Kornilov
From: Yegor Yefremov <yegorslists@googlemail.com>
When in half-duplex mode RX will be disabled before TX, but not
enabled after deactivating transmitter. This patch enables
UART_IER_RLSI and UART_IER_RDI interrupts after TX is over.
Cc: Matwey V. Kornilov <matwey@sai.msu.ru>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
---
Changes:
v2: change subject and add 'Fixes' tag
drivers/tty/serial/8250/8250_port.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index e213da0..00ad263 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -1403,9 +1403,18 @@ static void __do_stop_tx_rs485(struct uart_8250_port *p)
/*
* Empty the RX FIFO, we are not interested in anything
* received during the half-duplex transmission.
+ * Enable previously disabled RX interrupts.
*/
- if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX))
+ if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) {
serial8250_clear_fifos(p);
+
+ serial8250_rpm_get(p);
+
+ p->ier |= UART_IER_RLSI | UART_IER_RDI;
+ serial_port_out(&p->port, UART_IER, p->ier);
+
+ serial8250_rpm_put(p);
+ }
}
static void serial8250_em485_handle_stop_tx(unsigned long arg)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX
2016-03-24 8:03 [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX yegorslists
@ 2016-03-31 5:22 ` Yegor Yefremov
2016-03-31 8:10 ` Matwey V. Kornilov
1 sibling, 0 replies; 3+ messages in thread
From: Yegor Yefremov @ 2016-03-31 5:22 UTC (permalink / raw)
To: linux-serial
Cc: Greg KH, Peter Hurley, Sebastian Andrzej Siewior, kernel list,
Uwe Kleine-König, Yegor Yefremov, Matwey V. Kornilov
On Thu, Mar 24, 2016 at 9:03 AM, <yegorslists@googlemail.com> wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> When in half-duplex mode RX will be disabled before TX, but not
> enabled after deactivating transmitter. This patch enables
> UART_IER_RLSI and UART_IER_RDI interrupts after TX is over.
>
> Cc: Matwey V. Kornilov <matwey@sai.msu.ru>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Transferring from Acked-by from v1:
Acked-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
> Changes:
> v2: change subject and add 'Fixes' tag
>
> drivers/tty/serial/8250/8250_port.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index e213da0..00ad263 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -1403,9 +1403,18 @@ static void __do_stop_tx_rs485(struct uart_8250_port *p)
> /*
> * Empty the RX FIFO, we are not interested in anything
> * received during the half-duplex transmission.
> + * Enable previously disabled RX interrupts.
> */
> - if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX))
> + if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) {
> serial8250_clear_fifos(p);
> +
> + serial8250_rpm_get(p);
> +
> + p->ier |= UART_IER_RLSI | UART_IER_RDI;
> + serial_port_out(&p->port, UART_IER, p->ier);
> +
> + serial8250_rpm_put(p);
> + }
> }
>
> static void serial8250_em485_handle_stop_tx(unsigned long arg)
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX
2016-03-24 8:03 [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX yegorslists
2016-03-31 5:22 ` Yegor Yefremov
@ 2016-03-31 8:10 ` Matwey V. Kornilov
1 sibling, 0 replies; 3+ messages in thread
From: Matwey V. Kornilov @ 2016-03-31 8:10 UTC (permalink / raw)
To: Yegor Yefremov
Cc: linux-serial, Greg KH, Peter Hurley, bigeasy, linux-kernel,
Uwe Kleine-König
2016-03-24 11:03 GMT+03:00 <yegorslists@googlemail.com>:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> When in half-duplex mode RX will be disabled before TX, but not
> enabled after deactivating transmitter. This patch enables
> UART_IER_RLSI and UART_IER_RDI interrupts after TX is over.
>
> Cc: Matwey V. Kornilov <matwey@sai.msu.ru>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Acked-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
> Changes:
> v2: change subject and add 'Fixes' tag
>
> drivers/tty/serial/8250/8250_port.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index e213da0..00ad263 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -1403,9 +1403,18 @@ static void __do_stop_tx_rs485(struct uart_8250_port *p)
> /*
> * Empty the RX FIFO, we are not interested in anything
> * received during the half-duplex transmission.
> + * Enable previously disabled RX interrupts.
> */
> - if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX))
> + if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) {
> serial8250_clear_fifos(p);
> +
> + serial8250_rpm_get(p);
> +
> + p->ier |= UART_IER_RLSI | UART_IER_RDI;
> + serial_port_out(&p->port, UART_IER, p->ier);
> +
> + serial8250_rpm_put(p);
> + }
> }
>
> static void serial8250_em485_handle_stop_tx(unsigned long arg)
> --
> 2.1.4
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-31 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-24 8:03 [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX yegorslists
2016-03-31 5:22 ` Yegor Yefremov
2016-03-31 8:10 ` Matwey V. Kornilov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.