All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCHv2 09/12] staging: ti-soc-thermal: fix several kernel-doc warnings and error
Date: Wed, 20 Mar 2013 07:50:39 -0500	[thread overview]
Message-ID: <CAGo_u6oi6+rPfO+A4ryeWJrJGPQ2zquhckYfJcvSvYzLoxEtvQ@mail.gmail.com> (raw)
In-Reply-To: <5149A3E2.2030505@ti.com>

On Wed, Mar 20, 2013 at 6:56 AM, Eduardo Valentin
<eduardo.valentin@ti.com> wrote:
> On 19-03-2013 15:22, Nishanth Menon wrote:
>>
>> On 10:54-20130319, Eduardo Valentin wrote:
[..]
>> You may still want to fix warnings generated by:
>> ./scripts/kernel-doc -v
>> drivers/staging/ti-soc-thermal/ti-bandgap.c>/dev/null
>> For example - the following changes are required for proper error return
>> documentation (following diff is just an hint):
>
>
> Although I think the above is a good thing to be done, I don't think it is
> considered mandatory, and for this reason, I don't believe the above should
> block this patch. Basically because, after this patch, at least kernel-doc
> runs successfully.
>
> Besides, there is very few evidence that ppl out there care much about "-v".
> A quick grep+awk would inform you this. If you consider the population of C
> files (around 35.4K files) inside the tree (simple find * | grep .*\\.[c,h]$
> in your tree), only around 12.0% has structured comments. Out of the files
> that have structured comments, only about 11.0% has 0 warnings (including 0
> warnings with -v), that's something like ~500 files. A considerable amount
> don't care about "-v" (34% out of the files with structured comments).
> Actually most of them don't care about warnings (89% out of the files with
> structured comments) at all. :-)

Yep, commit 4092bac7

>
> That said, I am going to send a separate patch to fix the "-v" later on.
> Including your chunks below.

Thanks.
Regards,
Nishanth Menon

  reply	other threads:[~2013-03-20 12:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 14:54 [PATCHv2 00/12] staging: [omap,ti-soc]-thermal: fixes and renaming Eduardo Valentin
2013-03-19 14:54 ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 01/12] staging: omap-thermal: fix return value Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 02/12] staging: omap-thermal: rename bg_ptr to bgp Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 03/12] staging: rename omap-thermal driver to ti-soc-thermal Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 04/12] staging: ti-soc-thermal: rename Kconfig options Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 05/12] staging: ti-soc-thermal: rename symbols to use better prefix Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 06/12] staging: ti-soc-thermal: make unexported functions local Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 07/12] staging: ti-soc-thermal: split writable data from readonly data Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 08/12] stating: ti-soc-thermal: use sizeof(*pointer) while allocating Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 09/12] staging: ti-soc-thermal: fix several kernel-doc warnings and error Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 19:22   ` Nishanth Menon
2013-03-19 19:22     ` Nishanth Menon
2013-03-20 11:56     ` Eduardo Valentin
2013-03-20 11:56       ` Eduardo Valentin
2013-03-20 12:50       ` Nishanth Menon [this message]
2013-03-25 18:22   ` Greg KH
2013-03-26  0:24     ` Eduardo Valentin
2013-03-26  0:24       ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 10/12] staging: ti-soc-thermal: fix condition to apply hyst Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 11/12] staging: ti-soc-thermal: fix bitfield writing while updating thresholds Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-19 14:54 ` [PATCHv2 12/12] staging: ti-soc-thermal: propagate error code Eduardo Valentin
2013-03-19 14:54   ` Eduardo Valentin
2013-03-20  9:15 ` [PATCHv2 00/12] staging: [omap,ti-soc]-thermal: fixes and renaming Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGo_u6oi6+rPfO+A4ryeWJrJGPQ2zquhckYfJcvSvYzLoxEtvQ@mail.gmail.com \
    --to=nm@ti.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=eduardo.valentin@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.