* [PATCH] musb-new: Use predefined configuration data for SUN50I_H6
@ 2020-05-08 12:29 Roman Stratiienko
2020-05-14 6:44 ` Roman Stratiienko
0 siblings, 1 reply; 4+ messages in thread
From: Roman Stratiienko @ 2020-05-08 12:29 UTC (permalink / raw)
To: u-boot
Same was done in the kernel for all devices compatible with
'allwinner,sun8i-a33-musb' at [1] and [2].
Fixes musb initialization on H6 SOC.
[1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
[2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
---
CC: Ondrej Jirman <megous@megous.com>
CC: Icenowy Zheng <icenowy@aosc.io>
CC: Marek Vasut <marex@denx.de>
CC: linux-sunxi at googlegroups.com
Hello community,
'$ fastboot usb 0' command works, but host still doesn't see any USB devices.
Does anyone have any suggestions where to look?
---
drivers/usb/musb-new/musb_regs.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb-new/musb_regs.h b/drivers/usb/musb-new/musb_regs.h
index c4d7203b85..5f012f3b41 100644
--- a/drivers/usb/musb-new/musb_regs.h
+++ b/drivers/usb/musb-new/musb_regs.h
@@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
static inline u8 musb_read_configdata(void __iomem *mbase)
{
#if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
- defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
+ defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
+ defined CONFIG_MACH_SUN50I_H6
+
/* <Sigh> allwinner saves a reg, and we need to hardcode this */
return 0xde;
#else
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] musb-new: Use predefined configuration data for SUN50I_H6
2020-05-08 12:29 [PATCH] musb-new: Use predefined configuration data for SUN50I_H6 Roman Stratiienko
@ 2020-05-14 6:44 ` Roman Stratiienko
2020-06-13 19:33 ` Roman Stratiienko
0 siblings, 1 reply; 4+ messages in thread
From: Roman Stratiienko @ 2020-05-14 6:44 UTC (permalink / raw)
To: u-boot
CC: jagan at amarulasolutions.com
??, 8 ??? 2020 ?. ? 15:29, Roman Stratiienko <r.stratiienko@gmail.com>:
>
> Same was done in the kernel for all devices compatible with
> 'allwinner,sun8i-a33-musb' at [1] and [2].
>
> Fixes musb initialization on H6 SOC.
>
> [1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
> [2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440
>
> Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
> ---
> CC: Ondrej Jirman <megous@megous.com>
> CC: Icenowy Zheng <icenowy@aosc.io>
> CC: Marek Vasut <marex@denx.de>
> CC: linux-sunxi at googlegroups.com
>
> Hello community,
>
> '$ fastboot usb 0' command works, but host still doesn't see any USB devices.
> Does anyone have any suggestions where to look?
> ---
> drivers/usb/musb-new/musb_regs.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb-new/musb_regs.h b/drivers/usb/musb-new/musb_regs.h
> index c4d7203b85..5f012f3b41 100644
> --- a/drivers/usb/musb-new/musb_regs.h
> +++ b/drivers/usb/musb-new/musb_regs.h
> @@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
> static inline u8 musb_read_configdata(void __iomem *mbase)
> {
> #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
> - defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
> + defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
> + defined CONFIG_MACH_SUN50I_H6
> +
> /* <Sigh> allwinner saves a reg, and we need to hardcode this */
> return 0xde;
> #else
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] musb-new: Use predefined configuration data for SUN50I_H6
2020-05-14 6:44 ` Roman Stratiienko
@ 2020-06-13 19:33 ` Roman Stratiienko
2020-09-21 9:06 ` Roman Stratiienko
0 siblings, 1 reply; 4+ messages in thread
From: Roman Stratiienko @ 2020-06-13 19:33 UTC (permalink / raw)
To: u-boot
??, 14 ??? 2020 ?. ? 09:44, Roman Stratiienko <r.stratiienko@gmail.com>:
>
> CC: jagan at amarulasolutions.com
>
> ??, 8 ??? 2020 ?. ? 15:29, Roman Stratiienko <r.stratiienko@gmail.com>:
> >
> > Same was done in the kernel for all devices compatible with
> > 'allwinner,sun8i-a33-musb' at [1] and [2].
> >
> > Fixes musb initialization on H6 SOC.
> >
> > [1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
> > [2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440
> >
> > Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
> > ---
> > CC: Ondrej Jirman <megous@megous.com>
> > CC: Icenowy Zheng <icenowy@aosc.io>
> > CC: Marek Vasut <marex@denx.de>
> > CC: linux-sunxi at googlegroups.com
> >
> > Hello community,
> >
> > '$ fastboot usb 0' command works, but host still doesn't see any USB devices.
> > Does anyone have any suggestions where to look?
Hello,
Second issue was fixed with commit 462a9c7a9cce ("phy: sun4i-usb:
Align H6 initialization logic with the kernel") <merged>
This patch is required to fix download gadget support for H6 SOC.
Please review/merge.
> > ---
> > drivers/usb/musb-new/musb_regs.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/musb-new/musb_regs.h b/drivers/usb/musb-new/musb_regs.h
> > index c4d7203b85..5f012f3b41 100644
> > --- a/drivers/usb/musb-new/musb_regs.h
> > +++ b/drivers/usb/musb-new/musb_regs.h
> > @@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
> > static inline u8 musb_read_configdata(void __iomem *mbase)
> > {
> > #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
> > - defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
> > + defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
> > + defined CONFIG_MACH_SUN50I_H6
> > +
> > /* <Sigh> allwinner saves a reg, and we need to hardcode this */
> > return 0xde;
> > #else
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] musb-new: Use predefined configuration data for SUN50I_H6
2020-06-13 19:33 ` Roman Stratiienko
@ 2020-09-21 9:06 ` Roman Stratiienko
0 siblings, 0 replies; 4+ messages in thread
From: Roman Stratiienko @ 2020-09-21 9:06 UTC (permalink / raw)
To: u-boot
CC: linux-sunxi at googlegroups.com
??, 13 ???. 2020 ?. ? 22:33, Roman Stratiienko <r.stratiienko@gmail.com>:
>
> ??, 14 ??? 2020 ?. ? 09:44, Roman Stratiienko <r.stratiienko@gmail.com>:
> >
> > CC: jagan at amarulasolutions.com
> >
> > ??, 8 ??? 2020 ?. ? 15:29, Roman Stratiienko <r.stratiienko@gmail.com>:
> > >
> > > Same was done in the kernel for all devices compatible with
> > > 'allwinner,sun8i-a33-musb' at [1] and [2].
> > >
> > > Fixes musb initialization on H6 SOC.
> > >
> > > [1] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n726
> > > [2] - https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/usb/musb/sunxi.c?h=v5.6.11#n440
> > >
> > > Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
> > > ---
> > > CC: Ondrej Jirman <megous@megous.com>
> > > CC: Icenowy Zheng <icenowy@aosc.io>
> > > CC: Marek Vasut <marex@denx.de>
> > > CC: linux-sunxi at googlegroups.com
> > >
> > > Hello community,
> > >
> > > '$ fastboot usb 0' command works, but host still doesn't see any USB devices.
> > > Does anyone have any suggestions where to look?
>
> Hello,
>
> Second issue was fixed with commit 462a9c7a9cce ("phy: sun4i-usb:
> Align H6 initialization logic with the kernel") <merged>
> This patch is required to fix download gadget support for H6 SOC.
> Please review/merge.
>
> > > ---
> > > drivers/usb/musb-new/musb_regs.h | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/musb-new/musb_regs.h b/drivers/usb/musb-new/musb_regs.h
> > > index c4d7203b85..5f012f3b41 100644
> > > --- a/drivers/usb/musb-new/musb_regs.h
> > > +++ b/drivers/usb/musb-new/musb_regs.h
> > > @@ -432,7 +432,9 @@ static inline u8 musb_read_ulpi_buscontrol(void __iomem *mbase)
> > > static inline u8 musb_read_configdata(void __iomem *mbase)
> > > {
> > > #if defined CONFIG_MACH_SUN8I_A33 || defined CONFIG_MACH_SUN8I_A83T || \
> > > - defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I
> > > + defined CONFIG_MACH_SUNXI_H3_H5 || defined CONFIG_MACH_SUN50I || \
> > > + defined CONFIG_MACH_SUN50I_H6
> > > +
> > > /* <Sigh> allwinner saves a reg, and we need to hardcode this */
> > > return 0xde;
> > > #else
> > > --
> > > 2.25.1
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-21 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 12:29 [PATCH] musb-new: Use predefined configuration data for SUN50I_H6 Roman Stratiienko
2020-05-14 6:44 ` Roman Stratiienko
2020-06-13 19:33 ` Roman Stratiienko
2020-09-21 9:06 ` Roman Stratiienko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.