All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Mayer <markus.mayer@broadcom.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Mark Rutland <mark.rutland@arm.com>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
	Linux HWMON List <linux-hwmon@vger.kernel.org>,
	Device Tree List <devicetree@vger.kernel.org>,
	ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors
Date: Wed, 3 May 2017 15:29:10 -0700	[thread overview]
Message-ID: <CAGt4E5s0uoLjeEhk_srxbr=f_sf-NSVXbW_HEJfjnSiAQU8o=Q@mail.gmail.com> (raw)
In-Reply-To: <90f011d6-9241-e860-7a0e-2fb52c2337ce@gmail.com>

Hi Rob,

On 27 April 2017 at 15:00, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 04/27/2017 02:57 PM, Rob Herring wrote:
>>>>> +Optional properties:
>>>>> +  - cell-index: the index of the DPFE instance; will default to 0 if not set
>>
>> Don't use cell-index. It's not a valid property for FDT (only real
>> OpenFirmware).
>
> My bad, I was advising Markus to use this property since it was largely
> used throughout Documentation/devicetree/bindings/. What would be a more
> appropriate way to have the same information? Aliases?

Hopefully this will be the last time we need to pester you about this.
What should we be using instead of cell-index to identify multiple
instances of a device?

To give you an idea of what the code looks like right now:

ret = of_property_read_u32(dev->of_node, "cell-index", &index);
if (ret)
    index = 0;
[...]
dev_set_name(dpfe_dev, "dpfe%u", index);
ret = device_register(dpfe_dev);

Enumerating the devices like this is what we are after.

Thanks,
-Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Mayer <markus.mayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jean Delvare <jdelvare-IBi9RG/b67k@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Broadcom Kernel List
	<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Linux HWMON List
	<linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Device Tree List
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	ARM Kernel List
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors
Date: Wed, 3 May 2017 15:29:10 -0700	[thread overview]
Message-ID: <CAGt4E5s0uoLjeEhk_srxbr=f_sf-NSVXbW_HEJfjnSiAQU8o=Q@mail.gmail.com> (raw)
In-Reply-To: <90f011d6-9241-e860-7a0e-2fb52c2337ce-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi Rob,

On 27 April 2017 at 15:00, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 04/27/2017 02:57 PM, Rob Herring wrote:
>>>>> +Optional properties:
>>>>> +  - cell-index: the index of the DPFE instance; will default to 0 if not set
>>
>> Don't use cell-index. It's not a valid property for FDT (only real
>> OpenFirmware).
>
> My bad, I was advising Markus to use this property since it was largely
> used throughout Documentation/devicetree/bindings/. What would be a more
> appropriate way to have the same information? Aliases?

Hopefully this will be the last time we need to pester you about this.
What should we be using instead of cell-index to identify multiple
instances of a device?

To give you an idea of what the code looks like right now:

ret = of_property_read_u32(dev->of_node, "cell-index", &index);
if (ret)
    index = 0;
[...]
dev_set_name(dpfe_dev, "dpfe%u", index);
ret = device_register(dpfe_dev);

Enumerating the devices like this is what we are after.

Thanks,
-Markus
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: markus.mayer@broadcom.com (Markus Mayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors
Date: Wed, 3 May 2017 15:29:10 -0700	[thread overview]
Message-ID: <CAGt4E5s0uoLjeEhk_srxbr=f_sf-NSVXbW_HEJfjnSiAQU8o=Q@mail.gmail.com> (raw)
In-Reply-To: <90f011d6-9241-e860-7a0e-2fb52c2337ce@gmail.com>

Hi Rob,

On 27 April 2017 at 15:00, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 04/27/2017 02:57 PM, Rob Herring wrote:
>>>>> +Optional properties:
>>>>> +  - cell-index: the index of the DPFE instance; will default to 0 if not set
>>
>> Don't use cell-index. It's not a valid property for FDT (only real
>> OpenFirmware).
>
> My bad, I was advising Markus to use this property since it was largely
> used throughout Documentation/devicetree/bindings/. What would be a more
> appropriate way to have the same information? Aliases?

Hopefully this will be the last time we need to pester you about this.
What should we be using instead of cell-index to identify multiple
instances of a device?

To give you an idea of what the code looks like right now:

ret = of_property_read_u32(dev->of_node, "cell-index", &index);
if (ret)
    index = 0;
[...]
dev_set_name(dpfe_dev, "dpfe%u", index);
ret = device_register(dpfe_dev);

Enumerating the devices like this is what we are after.

Thanks,
-Markus

  reply	other threads:[~2017-05-03 22:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 20:17 [PATCH 0/2] HWMON driver for Broadcom STB DPFE Markus Mayer
2017-04-18 20:17 ` Markus Mayer
2017-04-18 20:17 ` Markus Mayer
2017-04-18 20:17 ` [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors Markus Mayer
2017-04-18 20:17   ` Markus Mayer
2017-04-25 19:29   ` Markus Mayer
2017-04-25 19:29     ` Markus Mayer
2017-04-27 18:28     ` Markus Mayer
2017-04-27 18:28       ` Markus Mayer
2017-04-27 18:28       ` Markus Mayer
2017-04-27 21:57       ` Rob Herring
2017-04-27 21:57         ` Rob Herring
2017-04-27 21:57         ` Rob Herring
2017-04-27 22:00         ` Florian Fainelli
2017-04-27 22:00           ` Florian Fainelli
2017-05-03 22:29           ` Markus Mayer [this message]
2017-05-03 22:29             ` Markus Mayer
2017-05-03 22:29             ` Markus Mayer
2017-04-18 20:17 ` [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE Markus Mayer
2017-04-18 20:17   ` Markus Mayer
2017-04-18 20:58   ` Guenter Roeck
2017-04-18 20:58     ` Guenter Roeck
2017-04-18 22:29     ` Florian Fainelli
2017-04-18 22:29       ` Florian Fainelli
2017-04-18 22:47       ` Guenter Roeck
2017-04-18 22:47         ` Guenter Roeck
2017-04-18 22:47         ` Guenter Roeck
2017-04-19  0:15         ` Markus Mayer
2017-04-19  0:15           ` Markus Mayer
2017-04-19  0:15           ` Markus Mayer
2017-04-19  0:26           ` Florian Fainelli
2017-04-19  0:26             ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGt4E5s0uoLjeEhk_srxbr=f_sf-NSVXbW_HEJfjnSiAQU8o=Q@mail.gmail.com' \
    --to=markus.mayer@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.