All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balsam CHIHI <bchihi@baylibre.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: rafael@kernel.org, rui.zhang@intel.com,
	daniel.lezcano@linaro.org, amitk@kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
	krzk+dt@kernel.org, matthias.bgg@gmail.com,
	p.zabel@pengutronix.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
	fan.chen@mediatek.com, louis.yu@mediatek.com,
	rex-bc.chen@mediatek.com, abailon@baylibre.com
Subject: Re: [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195
Date: Mon, 1 Aug 2022 14:33:31 +0200	[thread overview]
Message-ID: <CAGuA+ooqk-tf5FVfEbA0WdjTOo2fPJi-+AaHDC9jXgw=3vKq0g@mail.gmail.com> (raw)
In-Reply-To: <20220729201421.fxybo57g46ftghgd@notapiano>

On Fri, Jul 29, 2022 at 10:14 PM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> On Tue, Jul 26, 2022 at 03:55:05PM +0200, Balsam CHIHI wrote:
> > This adds the efuse node. This will be required by the thermal driver
> > to get the calibration data.
> >
> > Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index 0ff34edcf8c8..4fbf24b5d202 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -1236,6 +1236,22 @@ nor_flash: spi@1132c000 {
> >                       status = "disabled";
> >               };
> >
> > +             efuse: efuse@11c10000 {
> > +                     compatible = "mediatek,efuse";
> > +                     reg = <0 0x11c10000 0 0x1000>;
> > +                     #address-cells = <1>;
> > +                     #size-cells = <1>;
> > +                     lvts_efuse_data1: lvts1-calib@1bc {
> > +                             reg = <0x1bc 0x14>;
> > +                     };
> > +                     lvts_efuse_data2: lvts2-calib@1d0 {
> > +                             reg = <0x1d0 0x38>;
> > +                     };
> > +                     svs_calibration: calib@580 {
> > +                             reg = <0x580 0x64>;
> > +                     };
> > +             };
> > +
>
> This commit doesn't apply, there's already an efuse node on mt8195.dtsi. Please
> rebase.
>
> Thanks,
> Nícolas

Hello Nícolas,

Thank you so much for the review.
I rebased on top of the latest kernel version "linux-5.19.0" but I
can't find efuse node on mt8195.dtsi.
But, this node is indeed present on mt8192.dtsi.

Best regards,
Balsam

WARNING: multiple messages have this Message-ID (diff)
From: Balsam CHIHI <bchihi@baylibre.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: rafael@kernel.org, rui.zhang@intel.com,
	daniel.lezcano@linaro.org,  amitk@kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
	 krzk+dt@kernel.org, matthias.bgg@gmail.com,
	p.zabel@pengutronix.de,  devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
	 fan.chen@mediatek.com, louis.yu@mediatek.com,
	rex-bc.chen@mediatek.com,  abailon@baylibre.com
Subject: Re: [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195
Date: Mon, 1 Aug 2022 14:33:31 +0200	[thread overview]
Message-ID: <CAGuA+ooqk-tf5FVfEbA0WdjTOo2fPJi-+AaHDC9jXgw=3vKq0g@mail.gmail.com> (raw)
In-Reply-To: <20220729201421.fxybo57g46ftghgd@notapiano>

On Fri, Jul 29, 2022 at 10:14 PM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> On Tue, Jul 26, 2022 at 03:55:05PM +0200, Balsam CHIHI wrote:
> > This adds the efuse node. This will be required by the thermal driver
> > to get the calibration data.
> >
> > Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index 0ff34edcf8c8..4fbf24b5d202 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -1236,6 +1236,22 @@ nor_flash: spi@1132c000 {
> >                       status = "disabled";
> >               };
> >
> > +             efuse: efuse@11c10000 {
> > +                     compatible = "mediatek,efuse";
> > +                     reg = <0 0x11c10000 0 0x1000>;
> > +                     #address-cells = <1>;
> > +                     #size-cells = <1>;
> > +                     lvts_efuse_data1: lvts1-calib@1bc {
> > +                             reg = <0x1bc 0x14>;
> > +                     };
> > +                     lvts_efuse_data2: lvts2-calib@1d0 {
> > +                             reg = <0x1d0 0x38>;
> > +                     };
> > +                     svs_calibration: calib@580 {
> > +                             reg = <0x580 0x64>;
> > +                     };
> > +             };
> > +
>
> This commit doesn't apply, there's already an efuse node on mt8195.dtsi. Please
> rebase.
>
> Thanks,
> Nícolas

Hello Nícolas,

Thank you so much for the review.
I rebased on top of the latest kernel version "linux-5.19.0" but I
can't find efuse node on mt8195.dtsi.
But, this node is indeed present on mt8192.dtsi.

Best regards,
Balsam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-01 12:46 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 13:55 [PATCH v8 0/6] Add LVTS architecture thermal Balsam CHIHI
2022-07-26 13:55 ` Balsam CHIHI
2022-07-26 13:55 ` [PATCH v8 1/6] thermal: mediatek: Relocate driver to mediatek folder Balsam CHIHI
2022-07-26 13:55   ` Balsam CHIHI
2022-07-27  8:17   ` AngeloGioacchino Del Regno
2022-07-27  8:17     ` AngeloGioacchino Del Regno
2022-07-27  8:24   ` AngeloGioacchino Del Regno
2022-07-27  8:24     ` AngeloGioacchino Del Regno
2022-07-27  9:03     ` Balsam CHIHI
2022-07-27  9:03       ` Balsam CHIHI
2022-07-28  8:53   ` Daniel Lezcano
2022-07-28  8:53     ` Daniel Lezcano
2022-07-29 15:19     ` Balsam CHIHI
2022-07-29 15:19       ` Balsam CHIHI
2022-07-29 15:21       ` Balsam CHIHI
2022-07-29 15:21         ` Balsam CHIHI
2022-07-29 15:35         ` Daniel Lezcano
2022-07-29 15:35           ` Daniel Lezcano
2022-08-03  8:41           ` Balsam CHIHI
2022-08-03  8:41             ` Balsam CHIHI
2022-08-03 10:51             ` Daniel Lezcano
2022-08-03 10:51               ` Daniel Lezcano
2022-07-26 13:55 ` [PATCH v8 2/6] dt-bindings: thermal: Add binding document for LVTS thermal controllers Balsam CHIHI
2022-07-26 13:55   ` Balsam CHIHI
2022-07-26 20:09   ` Rob Herring
2022-07-26 20:09     ` Rob Herring
2022-07-27  9:02     ` Balsam CHIHI
2022-07-27  9:02       ` Balsam CHIHI
2022-07-29 15:15     ` Balsam CHIHI
2022-07-29 15:15       ` Balsam CHIHI
2022-08-10 18:25       ` Rob Herring
2022-08-10 18:25         ` Rob Herring
2022-07-27  8:17   ` AngeloGioacchino Del Regno
2022-07-27  8:17     ` AngeloGioacchino Del Regno
2022-07-27  9:02     ` Balsam CHIHI
2022-07-27  9:02       ` Balsam CHIHI
2022-07-26 13:55 ` [PATCH v8 3/6] thermal: mediatek: Add LVTS drivers for SoC theraml zones for mt8192 Balsam CHIHI
2022-07-26 13:55   ` Balsam CHIHI
2022-07-27  9:23   ` AngeloGioacchino Del Regno
2022-07-27  9:23     ` AngeloGioacchino Del Regno
2022-07-29 15:38     ` Balsam CHIHI
2022-07-29 15:38       ` Balsam CHIHI
2022-07-29 20:30   ` Nícolas F. R. A. Prado
2022-07-29 20:30     ` Nícolas F. R. A. Prado
2022-07-26 13:55 ` [PATCH v8 4/6] thermal: mediatek: Add thermal zone settings for mt8195 Balsam CHIHI
2022-07-26 13:55   ` Balsam CHIHI
2022-07-26 13:55 ` [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195 Balsam CHIHI
2022-07-26 13:55   ` Balsam CHIHI
2022-07-29 20:14   ` Nícolas F. R. A. Prado
2022-07-29 20:14     ` Nícolas F. R. A. Prado
2022-08-01 12:33     ` Balsam CHIHI [this message]
2022-08-01 12:33       ` Balsam CHIHI
2022-08-01 13:57       ` Nícolas F. R. A. Prado
2022-08-01 13:57         ` Nícolas F. R. A. Prado
2022-07-26 13:55 ` [PATCH v8 6/6] arm64: dts: mt8195: Add thermal zone Balsam CHIHI
2022-07-26 13:55   ` Balsam CHIHI
2022-07-29 20:22   ` Nícolas F. R. A. Prado
2022-07-29 20:22     ` Nícolas F. R. A. Prado
2022-07-29 20:33 ` [PATCH v8 0/6] Add LVTS architecture thermal Nícolas F. R. A. Prado
2022-07-29 20:33   ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGuA+ooqk-tf5FVfEbA0WdjTOo2fPJi-+AaHDC9jXgw=3vKq0g@mail.gmail.com' \
    --to=bchihi@baylibre.com \
    --cc=abailon@baylibre.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fan.chen@mediatek.com \
    --cc=james.lo@mediatek.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=louis.yu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mka@chromium.org \
    --cc=nfraprado@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rafael@kernel.org \
    --cc=rex-bc.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.