[PATCH] dns_resolver: correct documentation error in dns resolver

[PATCH] dns_resolver: correct documentation error in dns resolver

[Bharath SM]

Fix error in dns_resolver documentation

Signed-off-by: Bharath SM <bharathsm@microsoft.com>
---
 Documentation/networking/dns_resolver.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/dns_resolver.rst
b/Documentation/networking/dns_resolver.rst
index add4d59a99a5..99bf72a6ed45 100644
--- a/Documentation/networking/dns_resolver.rst
+++ b/Documentation/networking/dns_resolver.rst
@@ -152,4 +152,4 @@ Debugging
 Debugging messages can be turned on dynamically by writing a 1 into the
 following file::

-       /sys/module/dnsresolver/parameters/debug
+       /sys/module/dns_resolver/parameters/debug
--
2.25.1

Re: [PATCH] dns_resolver: correct documentation error in dns resolver

[Bagas Sanjaya]

On 3/13/23 02:42, Bharath SM wrote:
> Fix error in dns_resolver documentation
> 

I can't tell what the error you fix is unless I see the diff below.
At a first glance, I though that you fix Sphinx warnings.

Also, is this patch [PATCH net]?

> diff --git a/Documentation/networking/dns_resolver.rst
> b/Documentation/networking/dns_resolver.rst
> index add4d59a99a5..99bf72a6ed45 100644
> --- a/Documentation/networking/dns_resolver.rst
> +++ b/Documentation/networking/dns_resolver.rst
> @@ -152,4 +152,4 @@ Debugging
>  Debugging messages can be turned on dynamically by writing a 1 into the
>  following file::
> 
> -       /sys/module/dnsresolver/parameters/debug
> +       /sys/module/dns_resolver/parameters/debug

Fixing incorrect sysfs path, right?

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Re: [PATCH] dns_resolver: correct documentation error in dns resolver

[Jakub Kicinski]

On Mon, 13 Mar 2023 10:44:39 +0700 Bagas Sanjaya wrote:
> On 3/13/23 02:42, Bharath SM wrote:
> > Fix error in dns_resolver documentation
> >   
> 
> I can't tell what the error you fix is unless I see the diff below.
> At a first glance, I though that you fix Sphinx warnings.
> 
> Also, is this patch [PATCH net]?

No strong preference, dns_resolver is sort of in between network
filesystems and actual networking. So Ack for linux-doc taking this
directly if that's easier.

Re: [PATCH] dns_resolver: correct documentation error in dns resolver

[Bharath SM]

> > I can't tell what the error you fix is unless I see the diff below.
> > At a first glance, I though that you fix Sphinx warnings.
Fixing incorrect sysfs path, right?

yes, It fixes the incorrect sysfs path in dns_resolver documentation.

On Mon, Mar 13, 2023 at 11:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 13 Mar 2023 10:44:39 +0700 Bagas Sanjaya wrote:
> > On 3/13/23 02:42, Bharath SM wrote:
> > > Fix error in dns_resolver documentation
> > >
> >
> > I can't tell what the error you fix is unless I see the diff below.
> > At a first glance, I though that you fix Sphinx warnings.
> >
> > Also, is this patch [PATCH net]?
>
> No strong preference, dns_resolver is sort of in between network
> filesystems and actual networking. So Ack for linux-doc taking this
> directly if that's easier.

Re: [PATCH] dns_resolver: correct documentation error in dns resolver

[Bagas Sanjaya]

On 3/14/23 01:56, Bharath SM wrote:
>>> I can't tell what the error you fix is unless I see the diff below.
>>> At a first glance, I though that you fix Sphinx warnings.
> Fixing incorrect sysfs path, right?
> 
> yes, It fixes the incorrect sysfs path in dns_resolver documentation.
> 

OK. Can you please send v2 with patch description mentioning above?

Also, can you configure your email client to have a reply below the
quote and not on above (aka top-posting)? When replying, you may also
need to trim unnecessary context lines, leaving the appropriate ones
intact.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Re: [PATCH] dns_resolver: correct documentation error in dns resolver

[David Howells]

Bharath SM <bharathsm.hsk@gmail.com> wrote:

> Fix error in dns_resolver documentation
> 
> Signed-off-by: Bharath SM <bharathsm@microsoft.com>

Acked-by: David Howells <dhowells@redhat.com>

Re: [PATCH] dns_resolver: correct documentation error in dns resolver

[Bharath SM]

On Tue, Mar 14, 2023 at 1:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 3/14/23 01:56, Bharath SM wrote:
> >>> I can't tell what the error you fix is unless I see the diff below.
> >>> At a first glance, I though that you fix Sphinx warnings.
> > Fixing incorrect sysfs path, right?
> >
> > yes, It fixes the incorrect sysfs path in dns_resolver documentation.
> >
>
> OK. Can you please send v2 with patch description mentioning above?
>
> Also, can you configure your email client to have a reply below the
> quote and not on above (aka top-posting)? When replying, you may also
> need to trim unnecessary context lines, leaving the appropriate ones
> intact.

Thanks for your feedback. I have sent patch v2 to the mailing list.
New subject: "[PATCH v2] dns_resolver: correct documentation error in
dns resolver"