Adding dependent service as Entity-manager to Ipmb-fru-service

Adding dependent service as Entity-manager to Ipmb-fru-service

[Kumar Thangavel]

[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]

Classification: Confidential
Hi All,

           Ipmb-fru-device deamon trying to read some dbus objects from entity-manager to get the ipmb bus details. Entity-manager daemon initially taking some time to load all the dbus objects. But Ipmb-fru-device deamon starts at system startup.

           Since, Entity-manager deamon initially taking some time to load all the dbus objects, ipmb-fru-device getting the below error.

          Error :
          "ipmb-fru-device[345]:   what():  sd_bus_call: org.freedesktop.DBus.Error.UnknownObject: Unknown object '/xyz/openbmc_project/inventory/system/board/Yosemite_V2_Baseboard/IpmbBus1'."

         When we restart EM deamon once, this error got resolved.

         I tried to add EM service as dependent service to Ipmb-fru-device service. Added EM service in "Wants", "After" fields in Ipmb-fru-service service.

         But, still EM deamon taking some time load all the dbus objects.

         So, Could you please let us know to how to add the EM as dependent service. Or Please let us know if any other approach.

Thanks,
Kumar.
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________

[-- Attachment #2: Type: text/html, Size: 5205 bytes --]

RE: Adding dependent service as Entity-manager to Ipmb-fru-service

[Kumar Thangavel]

[-- Attachment #1: Type: text/plain, Size: 2555 bytes --]

Classification: Public
Changing classification as Public.

From: Kumar Thangavel
Sent: Monday, June 21, 2021 2:58 PM
To: openbmc@lists.ozlabs.org
Cc: Ed Tanous <ed@tanous.net>; Patrick Williams <patrick@stwcx.xyz>; Velumani T-ERS,HCLTech <velumanit@hcl.com>
Subject: Adding dependent service as Entity-manager to Ipmb-fru-service

Classification: Confidential
Hi All,

           Ipmb-fru-device deamon trying to read some dbus objects from entity-manager to get the ipmb bus details. Entity-manager daemon initially taking some time to load all the dbus objects. But Ipmb-fru-device deamon starts at system startup.

           Since, Entity-manager deamon initially taking some time to load all the dbus objects, ipmb-fru-device getting the below error.

          Error :
          "ipmb-fru-device[345]:   what():  sd_bus_call: org.freedesktop.DBus.Error.UnknownObject: Unknown object '/xyz/openbmc_project/inventory/system/board/Yosemite_V2_Baseboard/IpmbBus1'."

         When we restart EM deamon once, this error got resolved.

         I tried to add EM service as dependent service to Ipmb-fru-device service. Added EM service in "Wants", "After" fields in Ipmb-fru-service service.

         But, still EM deamon taking some time load all the dbus objects.

         So, Could you please let us know to how to add the EM as dependent service. Or Please let us know if any other approach.

Thanks,
Kumar.
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________

[-- Attachment #2: Type: text/html, Size: 6441 bytes --]

Re: Adding dependent service as Entity-manager to Ipmb-fru-service

[Deepak Kodihalli]

Hi Kumar,

On Mon, Jun 21, 2021 at 3:02 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Public
>
> Changing classification as Public.
>
>
>
> From: Kumar Thangavel
> Sent: Monday, June 21, 2021 2:58 PM
> To: openbmc@lists.ozlabs.org
> Cc: Ed Tanous <ed@tanous.net>; Patrick Williams <patrick@stwcx.xyz>; Velumani T-ERS,HCLTech <velumanit@hcl.com>
> Subject: Adding dependent service as Entity-manager to Ipmb-fru-service
>
>
>
> Classification: Confidential
>
> Hi All,
>
>
>
>            Ipmb-fru-device deamon trying to read some dbus objects from entity-manager to get the ipmb bus details. Entity-manager daemon initially taking some time to load all the dbus objects. But Ipmb-fru-device deamon starts at system startup.
>
>
>
>            Since, Entity-manager deamon initially taking some time to load all the dbus objects, ipmb-fru-device getting the below error.
>
>
>
>           Error :
>
>           “ipmb-fru-device[345]:   what():  sd_bus_call: org.freedesktop.DBus.Error.UnknownObject: Unknown object '/xyz/openbmc_project/inventory/system/board/Yosemite_V2_Baseboard/IpmbBus1'.”
>
>
>
>          When we restart EM deamon once, this error got resolved.
>
>
>
>          I tried to add EM service as dependent service to Ipmb-fru-device service. Added EM service in “Wants”, “After” fields in Ipmb-fru-service service.
>
>
>
>          But, still EM deamon taking some time load all the dbus objects.
>
>
>
>          So, Could you please let us know to how to add the EM as dependent service. Or Please let us know if any other approach.

Isn't this supposed to be the other way around? A FRU daemon reads
EEPROMs (or other means) and hosts raw FRU information on D-Bus, and
then EM can add known D-Bus interfaces based on that. Either way, you
may not need a dependency if you go by standard D-Bus signals
(InterfacesAdded/PropertiesChanged).

Regards,
Deepak

Re: Adding dependent service as Entity-manager to Ipmb-fru-service

[Ed Tanous]

[-- Attachment #1: Type: text/plain, Size: 3153 bytes --]

On Mon, Jun 21, 2021 at 2:28 AM Kumar Thangavel <thangavel.k@hcl.com> wrote:

> Classification: *Confidential*
>
> Hi All,
>
>
>
>            Ipmb-fru-device deamon trying to read some dbus objects from
> entity-manager to get the ipmb bus details. Entity-manager daemon initially
> taking some time to load all the dbus objects. But Ipmb-fru-device deamon
> starts at system startup.
>
>
>
>            Since, Entity-manager deamon initially taking some time to load
> all the dbus objects, ipmb-fru-device getting the below error.
>
>
>
>           *Error* :
>
>           “ipmb-fru-device[345]:   what():  sd_bus_call:
> org.freedesktop.DBus.Error.UnknownObject: Unknown object
> '/xyz/openbmc_project/inventory/system/board/Yosemite_V2_Baseboard/IpmbBus1'.”
>

The easiest way to explain this would be to just point you at code.  Every
dbus-sensor daemon handles this race condition;  I'd recommend looking at
the code in the relevant main(), and see how it does it.  If you have
trouble understanding it, feel free to message back here with specific line
numbers and questions and we should hopefully be able to get you sorted out.


>
>
>          When we restart EM deamon once, this error got resolved.
>
>
>
>          I tried to add EM service as dependent service to Ipmb-fru-device
> service. Added EM service in “Wants”, “After” fields in Ipmb-fru-service
> service.
>
>
>
>          But, still EM deamon taking some time load all the dbus objects.
>

This is intentional.  Because of the way hardware gets detected, new
devices or different configurations could be loaded at any time.  Some
devices aren't detected until the host OS boots for example, so we can't
hold the service startup to wait for the entire system to be detected.


>
>
>          So, Could you please let us know to how to add the EM as
> dependent service. Or Please let us know if any other approach.
>
>
>
> Thanks,
>
> Kumar.
> ::DISCLAIMER::
> ------------------------------
> The contents of this e-mail and any attachment(s) are confidential and
> intended for the named recipient(s) only. E-mail transmission is not
> guaranteed to be secure or error-free as information could be intercepted,
> corrupted, lost, destroyed, arrive late or incomplete, or may contain
> viruses in transmission. The e mail and its contents (with or without
> referred errors) shall therefore not attach any liability on the originator
> or HCL or its affiliates. Views or opinions, if any, presented in this
> email are solely those of the author and may not necessarily reflect the
> views or opinions of HCL or its affiliates. Any form of reproduction,
> dissemination, copying, disclosure, modification, distribution and / or
> publication of this message without the prior written consent of authorized
> representative of HCL is strictly prohibited. If you have received this
> email in error please delete it and notify the sender immediately. Before
> opening any email and/or attachments, please check them for viruses and
> other defects.
> ------------------------------
>

[-- Attachment #2: Type: text/html, Size: 4964 bytes --]

Re: Adding dependent service as Entity-manager to Ipmb-fru-service

[Ed Tanous]

[-- Attachment #1: Type: text/plain, Size: 2475 bytes --]

On Mon, Jun 21, 2021 at 3:30 AM Deepak Kodihalli <
deepak.kodihalli.83@gmail.com> wrote:

> Hi Kumar,
>
> On Mon, Jun 21, 2021 at 3:02 PM Kumar Thangavel <thangavel.k@hcl.com>
> wrote:
> >
> > Classification: Public
> >
> > Changing classification as Public.
> >
> >
> >
> > From: Kumar Thangavel
> > Sent: Monday, June 21, 2021 2:58 PM
> > To: openbmc@lists.ozlabs.org
> > Cc: Ed Tanous <ed@tanous.net>; Patrick Williams <patrick@stwcx.xyz>;
> Velumani T-ERS,HCLTech <velumanit@hcl.com>
> > Subject: Adding dependent service as Entity-manager to Ipmb-fru-service
> >
> >
> >
> > Classification: Confidential
> >
> > Hi All,
> >
> >
> >
> >            Ipmb-fru-device deamon trying to read some dbus objects from
> entity-manager to get the ipmb bus details. Entity-manager daemon initially
> taking some time to load all the dbus objects. But Ipmb-fru-device deamon
> starts at system startup.
> >
> >
> >
> >            Since, Entity-manager deamon initially taking some time to
> load all the dbus objects, ipmb-fru-device getting the below error.
> >
> >
> >
> >           Error :
> >
> >           “ipmb-fru-device[345]:   what():  sd_bus_call:
> org.freedesktop.DBus.Error.UnknownObject: Unknown object
> '/xyz/openbmc_project/inventory/system/board/Yosemite_V2_Baseboard/IpmbBus1'.”
> >
> >
> >
> >          When we restart EM deamon once, this error got resolved.
> >
> >
> >
> >          I tried to add EM service as dependent service to
> Ipmb-fru-device service. Added EM service in “Wants”, “After” fields in
> Ipmb-fru-service service.
> >
> >
> >
> >          But, still EM deamon taking some time load all the dbus objects.
> >
> >
> >
> >          So, Could you please let us know to how to add the EM as
> dependent service. Or Please let us know if any other approach.
>
> Isn't this supposed to be the other way around? A FRU daemon reads
> EEPROMs (or other means) and hosts raw FRU information on D-Bus, and
> then EM can add known D-Bus interfaces based on that. Either way, you
> may not need a dependency if you go by standard D-Bus signals
> (InterfacesAdded/PropertiesChanged).
>

This is a different case for IPMB because the IPMB FRU daemon needs some
information about which devices support IPMB before it starts to check for
SDRs, as if the device doesn't support it, we could be writing bad data
into a device on accident.


>
> Regards,
> Deepak
>

[-- Attachment #2: Type: text/html, Size: 3544 bytes --]